[SOUP] The initiating page is lost after a redirection
authorcarlosgc@webkit.org <carlosgc@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 31 Dec 2013 08:32:10 +0000 (08:32 +0000)
committercarlosgc@webkit.org <carlosgc@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 31 Dec 2013 08:32:10 +0000 (08:32 +0000)
https://bugs.webkit.org/show_bug.cgi?id=126293

Reviewed by Martin Robinson.

The initiating page id is attached to the initial soup request
object, but not to the one created after a redirection.

* platform/network/soup/ResourceHandleSoup.cpp:
(WebCore::createSoupRequestAndMessageForHandle): Call
setSoupRequestInitiatingPageIDFromNetworkingContext() here if the
soup request is created successfully.
(WebCore::ResourceHandle::start): Remove the call to
setSoupRequestInitiatingPageIDFromNetworkingContext().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@161178 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/WebCore/ChangeLog
Source/WebCore/platform/network/soup/ResourceHandleSoup.cpp

index 31d40d0..2d08a33 100644 (file)
@@ -1,5 +1,22 @@
 2013-12-31  Carlos Garcia Campos  <cgarcia@igalia.com>
 
+        [SOUP] The initiating page is lost after a redirection
+        https://bugs.webkit.org/show_bug.cgi?id=126293
+
+        Reviewed by Martin Robinson.
+
+        The initiating page id is attached to the initial soup request
+        object, but not to the one created after a redirection.
+
+        * platform/network/soup/ResourceHandleSoup.cpp:
+        (WebCore::createSoupRequestAndMessageForHandle): Call
+        setSoupRequestInitiatingPageIDFromNetworkingContext() here if the
+        soup request is created successfully.
+        (WebCore::ResourceHandle::start): Remove the call to
+        setSoupRequestInitiatingPageIDFromNetworkingContext().
+
+2013-12-31  Carlos Garcia Campos  <cgarcia@igalia.com>
+
         [SOUP] Implement ResourceHandle::continueWillSendRequest()
         https://bugs.webkit.org/show_bug.cgi?id=126291
 
index d588d96..04eecde 100644 (file)
@@ -1048,6 +1048,8 @@ static bool createSoupRequestAndMessageForHandle(ResourceHandle* handle, const R
         return false;
     }
 
+    setSoupRequestInitiatingPageIDFromNetworkingContext(d->m_soupRequest.get(), d->m_context.get());
+
     return true;
 }
 
@@ -1078,8 +1080,6 @@ bool ResourceHandle::start()
         return true;
     }
 
-    setSoupRequestInitiatingPageIDFromNetworkingContext(d->m_soupRequest.get(), d->m_context.get());
-
     // Send the request only if it's not been explicitly deferred.
     if (!d->m_defersLoading)
         sendPendingRequest();