[Chromium] REGRESSION(r88030): Right-click on invalid form controls unexpectedly...
authortkent@chromium.org <tkent@chromium.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 28 Mar 2013 21:46:53 +0000 (21:46 +0000)
committertkent@chromium.org <tkent@chromium.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 28 Mar 2013 21:46:53 +0000 (21:46 +0000)
https://bugs.webkit.org/show_bug.cgi?id=113377

Reviewed by Dimitri Glazkov.

* src/ContextMenuClientImpl.cpp:
(WebKit::ContextMenuClientImpl::getCustomMenuFromDefaultItems):
We don't need to call HTMLFormElement::checkValidity here.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147161 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/WebKit/chromium/ChangeLog
Source/WebKit/chromium/src/ContextMenuClientImpl.cpp

index eb41683..0125232 100644 (file)
@@ -1,3 +1,14 @@
+2013-03-28  Kent Tamura  <tkent@chromium.org>
+
+        [Chromium] REGRESSION(r88030): Right-click on invalid form controls unexpectedly dispatches 'invalid' events
+        https://bugs.webkit.org/show_bug.cgi?id=113377
+
+        Reviewed by Dimitri Glazkov.
+
+        * src/ContextMenuClientImpl.cpp:
+        (WebKit::ContextMenuClientImpl::getCustomMenuFromDefaultItems):
+        We don't need to call HTMLFormElement::checkValidity here.
+
 2013-03-28  Sheriff Bot  <webkit.review.bot@gmail.com>
 
         Unreviewed.  Rolled Chromium DEPS to r191172.  Requested by
index d9b17cf..2ffd6e4 100644 (file)
@@ -338,7 +338,7 @@ PlatformMenuDescription ContextMenuClientImpl::getCustomMenuFromDefaultItems(
             }
         }
         HTMLFormElement* form = selectedFrame->selection()->currentForm();
-        if (form && form->checkValidity() && r.innerNonSharedNode()->hasTagName(HTMLNames::inputTag)) {
+        if (form && r.innerNonSharedNode()->hasTagName(HTMLNames::inputTag)) {
             HTMLInputElement* selectedElement = static_cast<HTMLInputElement*>(r.innerNonSharedNode());
             if (selectedElement) {
                 WebSearchableFormData ws = WebSearchableFormData(WebFormElement(form), WebInputElement(selectedElement));