[DFG] CheckTypeInfoFlags should say `eliminated` if it is removed in constant folding...
authorutatane.tea@gmail.com <utatane.tea@gmail.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Sun, 20 May 2018 10:49:20 +0000 (10:49 +0000)
committerutatane.tea@gmail.com <utatane.tea@gmail.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Sun, 20 May 2018 10:49:20 +0000 (10:49 +0000)
https://bugs.webkit.org/show_bug.cgi?id=185802

Reviewed by Saam Barati.

* dfg/DFGConstantFoldingPhase.cpp:
(JSC::DFG::ConstantFoldingPhase::foldConstants):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@232002 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/JavaScriptCore/ChangeLog
Source/JavaScriptCore/dfg/DFGConstantFoldingPhase.cpp

index 8228176..84ca10d 100644 (file)
@@ -1,3 +1,13 @@
+2018-05-20  Yusuke Suzuki  <utatane.tea@gmail.com>
+
+        [DFG] CheckTypeInfoFlags should say `eliminated` if it is removed in constant folding phase
+        https://bugs.webkit.org/show_bug.cgi?id=185802
+
+        Reviewed by Saam Barati.
+
+        * dfg/DFGConstantFoldingPhase.cpp:
+        (JSC::DFG::ConstantFoldingPhase::foldConstants):
+
 2018-05-18  Filip Pizlo  <fpizlo@apple.com>
 
         DFG should inline InstanceOf ICs
index 0e26ae8..757c9b4 100644 (file)
@@ -865,7 +865,7 @@ private:
                 ASSERT(bits);
                 if (bits == ImplementsDefaultHasInstance) {
                     if (abstractValue.m_type == SpecFunctionWithDefaultHasInstance) {
-                        changed = true;
+                        eliminated = true;
                         node->remove(m_graph);
                         break;
                     }
@@ -877,7 +877,7 @@ private:
                         // and we can read its inline type info flags. These flags don't change over the
                         // object's lifetime.
                         if ((value.asCell()->inlineTypeFlags() & bits) == bits) {
-                            changed = true;
+                            eliminated = true;
                             node->remove(m_graph);
                             break;
                         }
@@ -890,7 +890,7 @@ private:
                         ok &= (structure->typeInfo().inlineTypeFlags() & bits) == bits;
                     });
                     if (ok) {
-                        changed = true;
+                        eliminated = true;
                         node->remove(m_graph);
                         break;
                     }