[Gtk] Enable link prefetch support in the developer builds
authorzandobersek@gmail.com <zandobersek@gmail.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 13 Jun 2012 18:21:58 +0000 (18:21 +0000)
committerzandobersek@gmail.com <zandobersek@gmail.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 13 Jun 2012 18:21:58 +0000 (18:21 +0000)
https://bugs.webkit.org/show_bug.cgi?id=89011

Reviewed by Martin Robinson.

.:

Rather export an automake conditional than define a preprocessor
macro for enabling link prefetch support.

* configure.ac:

Source/WebCore:

Handle the ENABLE_LINK_PREFETCH conditional in standard way.

No new tests - covered by existing link prefetch tests.

* GNUmakefile.am:

Tools:

Enable the link prefetch support for Gtk by default in developer
builds.

* Scripts/webkitperl/FeatureList.pm:

LayoutTests:

Remove expectations for link prefetch tests that now pass and
recategorise a few failures that now fail due to missing
dumpResourceResponseMIMETypes implementation in DumpRenderTree.

* platform/gtk/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120228 268f45cc-cd09-0410-ab3c-d52691b4dbfc

ChangeLog
LayoutTests/ChangeLog
LayoutTests/platform/gtk/TestExpectations
Source/WebCore/ChangeLog
Source/WebCore/GNUmakefile.am
Tools/ChangeLog
Tools/Scripts/webkitperl/FeatureList.pm
configure.ac

index 2575bd1..1c2ad11 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,15 @@
+2012-06-13  Zan Dobersek  <zandobersek@gmail.com>
+
+        [Gtk] Enable link prefetch support in the developer builds
+        https://bugs.webkit.org/show_bug.cgi?id=89011
+
+        Reviewed by Martin Robinson.
+
+        Rather export an automake conditional than define a preprocessor
+        macro for enabling link prefetch support.
+
+        * configure.ac:
+
 2012-06-13  Robin Cao  <robin.cao@torchmobile.com.cn>
 
         [BlackBerry] Enable MEDIA_STREAM by default
index 8e407bf..baffe62 100644 (file)
@@ -1,3 +1,16 @@
+2012-06-13  Zan Dobersek  <zandobersek@gmail.com>
+
+        [Gtk] Enable link prefetch support in the developer builds
+        https://bugs.webkit.org/show_bug.cgi?id=89011
+
+        Reviewed by Martin Robinson.
+
+        Remove expectations for link prefetch tests that now pass and
+        recategorise a few failures that now fail due to missing
+        dumpResourceResponseMIMETypes implementation in DumpRenderTree.
+
+        * platform/gtk/TestExpectations:
+
 2012-06-13  Julien Chaffraix  <jchaffraix@webkit.org>
 
         Unreviewed flakiness removal.
index 902ba13..2695dce 100644 (file)
@@ -638,9 +638,7 @@ BUGWKGTK : http/tests/media/video-play-stall-seek.html = TEXT
 BUGWKGTK : http/tests/media/video-play-stall.html = TEXT
 
 BUGWKGTK : http/tests/misc/acid3.html = TEXT
-BUGWKGTK : http/tests/misc/link-rel-prefetch-and-subresource.html = TEXT
 BUGWKGTK : http/tests/misc/policy-delegate-called-twice.html = TEXT
-BUGWKGTK : http/tests/misc/prefetch-purpose.html = TEXT
 BUGWKGTK : http/tests/misc/redirect-to-external-url.html = TEXT
 BUGWKGTK : http/tests/misc/window-dot-stop.html = TEXT
 BUGWKGTK : http/tests/multipart/policy-ignore-crash.php = TEXT
@@ -818,15 +816,6 @@ BUGWK39102 : editing/spelling/context-menu-suggestions.html = TEXT
 BUGWKGTK : fast/forms/range/slider-mouse-events.html = TEXT
 BUGWKGTK : fast/forms/range/slider-zoomed.html = TEXT
 
-// Link prefetch is disabled by default
-BUGWKGTK : fast/dom/HTMLLinkElement/link-and-subresource-test.html = TEXT
-BUGWKGTK : fast/dom/HTMLLinkElement/link-and-subresource-test-nonexistent.html = TEXT
-BUGWKGTK : fast/dom/HTMLLinkElement/prefetch.html = TEXT
-BUGWKGTK : fast/dom/HTMLLinkElement/prefetch-beforeload.html = TEXT
-BUGWKGTK : fast/dom/HTMLLinkElement/prefetch-onerror.html = TEXT
-BUGWKGTK : fast/dom/HTMLLinkElement/prefetch-onload.html = TEXT
-BUGWKGTK : fast/dom/HTMLLinkElement/subresource.html = TEXT
-
 // Tests failing because the context menu is grabbing mouse events.
 BUGWK40601 : fast/events/mouse-click-events.html = TEXT
 BUGWK40601 : fast/events/mouseup-from-button2.html = TEXT
@@ -834,10 +823,14 @@ BUGWK40601 : fast/events/right-click-focus.html = TEXT
 BUGWK40601 : editing/selection/5354455-1.html = TEXT
 
 // Gtk doesn't implement dumpResourceResponseMIMETypes which is required for the preloader tests.
+BUGWK58222 : fast/dom/HTMLLinkElement/link-and-subresource-test.html = TEXT
+BUGWK58222 : fast/dom/HTMLLinkElement/prefetch.html = TEXT
+BUGWK58222 : fast/dom/HTMLLinkElement/subresource.html = TEXT
 BUGWK58222 : fast/preloader = TEXT
 BUGWK58222 : fast/preloader/scan-body-from-head-import.html = PASS
 BUGWK58222 : fast/preloader/scan-body-from-head-script.html = PASS
 BUGWK58222 : http/tests/mime/uppercase-mime-type.html = TEXT
+BUGWK58222 : http/tests/misc/prefetch-purpose.html = PASS
 
 // The middle circle on both rectangles is missing in the pixel output.
 BUGWKGTK : svg/custom/circular-marker-reference-2.svg = TEXT
index da1af67..2b4aba7 100644 (file)
@@ -1,3 +1,16 @@
+2012-06-13  Zan Dobersek  <zandobersek@gmail.com>
+
+        [Gtk] Enable link prefetch support in the developer builds
+        https://bugs.webkit.org/show_bug.cgi?id=89011
+
+        Reviewed by Martin Robinson.
+
+        Handle the ENABLE_LINK_PREFETCH conditional in standard way.
+
+        No new tests - covered by existing link prefetch tests.
+
+        * GNUmakefile.am:
+
 2012-06-13  Amy Ousterhout  <aousterh@chromium.org>
 
         Rename currentDeviceMotion to lastMotion in DeviceMotionClient
index 116f34b..1319180 100644 (file)
@@ -707,6 +707,14 @@ FEATURE_DEFINES += ENABLE_CSS3_FLEXBOX=1
 webcore_cppflags += -DENABLE_CSS3_FLEXBOX=1
 endif  # END ENABLE_CSS3_FLEXBOX
 
+# ---
+# Link prefetch support
+# ---
+if ENABLE_LINK_PREFETCH
+FEATURE_DEFINES += ENABLE_LINK_PREFETCH=1
+webcore_cppflags += -DENABLE_LINK_PREFETCH=1
+endif  # END ENABLE_LINK_PREFETCH
+
 DerivedSources/WebCore/CSSPropertyNames.cpp: DerivedSources/WebCore/CSSPropertyNames.h
 DerivedSources/WebCore/CSSPropertyNames.h: $(WEBCORE_CSS_PROPERTY_NAMES) $(WebCore)/css/makeprop.pl
        $(AM_V_GEN)
index a5a4332..a22d884 100644 (file)
@@ -1,3 +1,15 @@
+2012-06-13  Zan Dobersek  <zandobersek@gmail.com>
+
+        [Gtk] Enable link prefetch support in the developer builds
+        https://bugs.webkit.org/show_bug.cgi?id=89011
+
+        Reviewed by Martin Robinson.
+
+        Enable the link prefetch support for Gtk by default in developer
+        builds.
+
+        * Scripts/webkitperl/FeatureList.pm:
+
 2012-06-13  Csaba Osztrogon√°c  <ossy@webkit.org>
 
         Update buildbot master in autoinstaller to match build.webkit.org
index f89c826..a0b7c0f 100644 (file)
@@ -264,7 +264,7 @@ my @features = (
       define => "ENABLE_LEGACY_WEBKIT_BLOB_BUILDER", default => (isGtk() || isChromium() || isBlackBerry() || isEfl()), value => \$legacyWebKitBlobBuilderSupport },
 
     { option => "link-prefetch", desc => "Toggle Link Prefetch support",
-      define => "ENABLE_LINK_PREFETCH", default => 0, value => \$linkPrefetchSupport },
+      define => "ENABLE_LINK_PREFETCH", default => isGtk(), value => \$linkPrefetchSupport },
 
     { option => "link-prerender", desc => "Toggle Link Prerender support",
       define => "ENABLE_LINK_PRERENDER", default => 0, value => \$linkPrerenderSupport },
index 2361235..1da7975 100644 (file)
@@ -1041,10 +1041,6 @@ AC_ARG_ENABLE([link-prefetch],
   [],[enable_link_prefetch=no])
 AC_MSG_RESULT([$enable_link_prefetch])
 
-if test "$enable_link_prefetch" = "yes"; then 
-  AC_DEFINE([ENABLE_LINK_PREFETCH], [1], [Define to enable link prefetch support])
-fi
-
 # GObject Introspection
 AC_MSG_CHECKING([whether to enable GObject introspection support])
 AC_ARG_ENABLE([introspection],
@@ -1437,6 +1433,7 @@ AM_CONDITIONAL([ENABLE_OPCODE_STATS],[test "$enable_opcode_stats" = "yes"])
 AM_CONDITIONAL([ENABLE_WEBKIT2],[test "$enable_webkit2" = "yes"])
 AM_CONDITIONAL([ENABLE_PLUGIN_PROCESS],[test "$enable_plugin_process" = "yes"])
 AM_CONDITIONAL([ENABLE_SPELLCHECK],[test "$enable_spellcheck" = "yes"])
+AM_CONDITIONAL([ENABLE_LINK_PREFETCH],[test "$enable_link_prefetch" = "yes"])
 AM_CONDITIONAL([ENABLE_ANIMATION_API],[test "$enable_animation_api" = "yes"])
 AM_CONDITIONAL([ENABLE_REQUEST_ANIMATION_FRAME],[test "$enable_request_animation_frame" = "yes"])
 AM_CONDITIONAL([ENABLE_TOUCH_ICON_LOADING],[test "$enable_touch_icon_loading" = "yes"])