Remove mousemoveEventHandlingPreventsDefault internal setting and quirk
authorgraouts@webkit.org <graouts@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 26 Mar 2019 17:29:54 +0000 (17:29 +0000)
committergraouts@webkit.org <graouts@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 26 Mar 2019 17:29:54 +0000 (17:29 +0000)
https://bugs.webkit.org/show_bug.cgi?id=196254
<rdar://problem/49124334>

Unreviewed. Fix build broken by previous commit.

* dom/Event.cpp:
* dom/Event.h:
(WebCore::Event::hasEncounteredListener const): Deleted.
(WebCore::Event::setHasEncounteredListener): Deleted.
* dom/EventTarget.cpp:
(WebCore::EventTarget::innerInvokeEventListeners):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@243504 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/WebCore/ChangeLog
Source/WebCore/dom/Event.cpp
Source/WebCore/dom/Event.h
Source/WebCore/dom/EventTarget.cpp

index 06c28b6..472388e 100644 (file)
@@ -1,3 +1,18 @@
+2019-03-26  Antoine Quint  <graouts@apple.com>
+
+        Remove mousemoveEventHandlingPreventsDefault internal setting and quirk
+        https://bugs.webkit.org/show_bug.cgi?id=196254
+        <rdar://problem/49124334>
+
+        Unreviewed. Fix build broken by previous commit.
+
+        * dom/Event.cpp:
+        * dom/Event.h:
+        (WebCore::Event::hasEncounteredListener const): Deleted.
+        (WebCore::Event::setHasEncounteredListener): Deleted.
+        * dom/EventTarget.cpp:
+        (WebCore::EventTarget::innerInvokeEventListeners):
+
 2019-03-26  Zalan Bujtas  <zalan@apple.com>
 
         [ContentChangeObserver] Skip anonymous renderers when checking for "willRespondToMouseClickEvents"
index 9371190..c8469c3 100644 (file)
@@ -47,7 +47,6 @@ ALWAYS_INLINE Event::Event(MonotonicTime createTime, const AtomicString& type, I
     , m_isDefaultEventHandlerIgnored { false }
     , m_isTrusted { isTrusted == IsTrusted::Yes }
     , m_isExecutingPassiveEventListener { false }
-    , m_hasEncounteredListener { false }
     , m_eventPhase { NONE }
     , m_type { type }
     , m_createTime { createTime }
index a6c9382..1136085 100644 (file)
@@ -128,9 +128,6 @@ public:
 
     void setInPassiveListener(bool value) { m_isExecutingPassiveEventListener = value; }
 
-    bool hasEncounteredListener() const { return m_hasEncounteredListener; }
-    void setHasEncounteredListener() { m_hasEncounteredListener = true; }
-
     bool cancelBubble() const { return propagationStopped(); }
     void setCancelBubble(bool);
 
@@ -169,7 +166,6 @@ private:
     unsigned m_isDefaultEventHandlerIgnored : 1;
     unsigned m_isTrusted : 1;
     unsigned m_isExecutingPassiveEventListener : 1;
-    unsigned m_hasEncounteredListener : 1;
 
     unsigned m_eventPhase : 2;
 
index 46886de..105f121 100644 (file)
@@ -301,16 +301,6 @@ void EventTarget::innerInvokeEventListeners(Event& event, EventListenerVector li
         registeredListener->callback().handleEvent(context, event);
         InspectorInstrumentation::didHandleEvent(context);
 
-#if ENABLE(TOUCH_EVENTS)
-        if (RuntimeEnabledFeatures::sharedFeatures().mousemoveEventHandlingPreventsDefaultEnabled() && event.type() == eventNames().mousemoveEvent) {
-            if (is<Element>(event.currentTarget())) {
-                auto* element = downcast<Element>(event.currentTarget());
-                if (!is<HTMLBodyElement>(element) && !is<HTMLHtmlElement>(element))
-                    event.setHasEncounteredListener();
-            }
-        }
-#endif
-
         if (registeredListener->isPassive())
             event.setInPassiveListener(false);
     }