pluginInfo.clientLoadPolicy is used uninitialized in WebContent process
authorap@apple.com <ap@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 28 Aug 2015 01:43:14 +0000 (01:43 +0000)
committerap@apple.com <ap@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 28 Aug 2015 01:43:14 +0000 (01:43 +0000)
https://bugs.webkit.org/show_bug.cgi?id=148550

Reviewed by Tim Horton.

This fixes flakiness on plugins/plugin-javascript-access.html.

* Shared/WebCoreArgumentCoders.cpp: (IPC::ArgumentCoder<PluginInfo>::decode):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@189080 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/WebKit2/ChangeLog
Source/WebKit2/Shared/WebCoreArgumentCoders.cpp

index 729d87b..32aa33e 100644 (file)
@@ -1,3 +1,14 @@
+2015-08-27  Alexey Proskuryakov  <ap@apple.com>
+
+        pluginInfo.clientLoadPolicy is used uninitialized in WebContent process
+        https://bugs.webkit.org/show_bug.cgi?id=148550
+
+        Reviewed by Tim Horton.
+
+        This fixes flakiness on plugins/plugin-javascript-access.html.
+
+        * Shared/WebCoreArgumentCoders.cpp: (IPC::ArgumentCoder<PluginInfo>::decode):
+
 2015-08-27  Timothy Horton  <timothy_horton@apple.com>
 
         Factor out Lookup invocation
index fe253a8..d528ce2 100644 (file)
@@ -596,8 +596,7 @@ bool ArgumentCoder<PluginInfo>::decode(ArgumentDecoder& decoder, PluginInfo& plu
         return false;
     if (!decoder.decode(pluginInfo.isApplicationPlugin))
         return false;
-    PluginLoadClientPolicy clientLoadPolicy;
-    if (!decoder.decodeEnum(clientLoadPolicy))
+    if (!decoder.decodeEnum(pluginInfo.clientLoadPolicy))
         return false;
 #if PLATFORM(MAC)
     if (!decoder.decode(pluginInfo.bundleIdentifier))