Enabling the Layers tab hides the paint flashing button
authordrousso@apple.com <drousso@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 9 Jul 2019 02:19:26 +0000 (02:19 +0000)
committerdrousso@apple.com <drousso@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 9 Jul 2019 02:19:26 +0000 (02:19 +0000)
https://bugs.webkit.org/show_bug.cgi?id=199549

Reviewed by Joseph Pecoraro.

Still show the Compositing Borders and Paint Flashing navigation items in the Elements tab
even when the Layers tab is enabled (just like the Layers details sidebar).

* UserInterface/Views/DOMTreeContentView.js:
(WI.DOMTreeContentView.prototype.get navigationItems):
(WI.DOMTreeContentView.prototype._updateCompositingBordersButtonToMatchPageSettings):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@247248 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/WebInspectorUI/ChangeLog
Source/WebInspectorUI/UserInterface/Views/DOMTreeContentView.js

index e106d7d..23d22f4 100644 (file)
@@ -1,5 +1,19 @@
 2019-07-08  Devin Rousso  <drousso@apple.com>
 
+        Enabling the Layers tab hides the paint flashing button
+        https://bugs.webkit.org/show_bug.cgi?id=199549
+
+        Reviewed by Joseph Pecoraro.
+
+        Still show the Compositing Borders and Paint Flashing navigation items in the Elements tab
+        even when the Layers tab is enabled (just like the Layers details sidebar).
+
+        * UserInterface/Views/DOMTreeContentView.js:
+        (WI.DOMTreeContentView.prototype.get navigationItems):
+        (WI.DOMTreeContentView.prototype._updateCompositingBordersButtonToMatchPageSettings):
+
+2019-07-08  Devin Rousso  <drousso@apple.com>
+
         Web Inspector: REGRESSION: Elements: pasting in the Styles sidebar adds a text node to the DOM tree
         https://bugs.webkit.org/show_bug.cgi?id=199588
 
index 5db19b8..850c934 100644 (file)
@@ -128,13 +128,11 @@ WI.DOMTreeContentView = class DOMTreeContentView extends WI.ContentView
         if (this._showRulersButtonNavigationItem)
            items.unshift(this._showRulersButtonNavigationItem);
 
-        if (!WI.settings.experimentalEnableLayersTab.value) {
-            if (this._compositingBordersButtonNavigationItem)
-                items.push(this._compositingBordersButtonNavigationItem);
+        if (this._compositingBordersButtonNavigationItem)
+            items.push(this._compositingBordersButtonNavigationItem);
 
-            if (this._paintFlashingButtonNavigationItem)
-                items.push(this._paintFlashingButtonNavigationItem);
-       }
+        if (this._paintFlashingButtonNavigationItem)
+            items.push(this._paintFlashingButtonNavigationItem);
 
         return items;
     }
@@ -606,9 +604,6 @@ WI.DOMTreeContentView = class DOMTreeContentView extends WI.ContentView
 
     _updateCompositingBordersButtonToMatchPageSettings()
     {
-        if (WI.settings.experimentalEnableLayersTab.value)
-            return;
-
         var button = this._compositingBordersButtonNavigationItem;
 
         // We need to sync with the page settings since these can be controlled