userscripts/user-script-*-document.html tests are flaky on Windows
authorbweinstein@apple.com <bweinstein@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 5 Nov 2010 18:01:50 +0000 (18:01 +0000)
committerbweinstein@apple.com <bweinstein@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 5 Nov 2010 18:01:50 +0000 (18:01 +0000)
https://bugs.webkit.org/show_bug.cgi?id=45980

Reviewed by Eric Carlson.

We can't use counting.mp4 as our video file to create a video document, because on Windows counting.mp4
is opened in Windows Explorer or Quicktime instead of Safari. This bug is being tracked by
<https://bugs.webkit.org/show_bug.cgi?id=25220>.

This patch switches user-script-video-document.html to use silence-loop.mov instead of counting.mp4,
which creates a video document on both Mac and Windows.

* userscripts/resources/counting.mp4: Removed.
* userscripts/resources/silence-loop.mov: Added.
* userscripts/user-script-video-document-expected.txt:
* userscripts/user-script-video-document.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71433 268f45cc-cd09-0410-ab3c-d52691b4dbfc

LayoutTests/ChangeLog
LayoutTests/platform/win/Skipped
LayoutTests/userscripts/resources/counting.mp4 [deleted file]
LayoutTests/userscripts/resources/silence-loop.mov [new file with mode: 0644]
LayoutTests/userscripts/user-script-video-document-expected.txt
LayoutTests/userscripts/user-script-video-document.html

index 8275e16..abae5cb 100644 (file)
@@ -1,3 +1,22 @@
+2010-11-05  Brian Weinstein  <bweinstein@apple.com>
+
+        Reviewed by Eric Carlson.
+
+        userscripts/user-script-*-document.html tests are flaky on Windows
+        https://bugs.webkit.org/show_bug.cgi?id=45980
+        
+        We can't use counting.mp4 as our video file to create a video document, because on Windows counting.mp4
+        is opened in Windows Explorer or Quicktime instead of Safari. This bug is being tracked by 
+        <https://bugs.webkit.org/show_bug.cgi?id=25220>.
+        
+        This patch switches user-script-video-document.html to use silence-loop.mov instead of counting.mp4,
+        which creates a video document on both Mac and Windows.
+
+        * userscripts/resources/counting.mp4: Removed.
+        * userscripts/resources/silence-loop.mov: Added.
+        * userscripts/user-script-video-document-expected.txt:
+        * userscripts/user-script-video-document.html:
+
 2010-11-05  Anders Carlsson  <andersca@apple.com>
 
         Reviewed by Adam Roben.
index 99f12dc..7a784bb 100644 (file)
@@ -1007,10 +1007,6 @@ userscripts/user-script-top-frame-only.html
 userscripts/user-style-all-frames.html
 userscripts/user-style-top-frame-only.html
 
-# These tests are flaky on Windows. Needs investigation.
-# https://bugs.webkit.org/show_bug.cgi?id=45980
-userscripts/user-script-video-document.html
-
 # Directory upload is not enabled.
 fast/forms/input-file-directory-upload.html
 
diff --git a/LayoutTests/userscripts/resources/counting.mp4 b/LayoutTests/userscripts/resources/counting.mp4
deleted file mode 100644 (file)
index 5fbd6d9..0000000
Binary files a/LayoutTests/userscripts/resources/counting.mp4 and /dev/null differ
diff --git a/LayoutTests/userscripts/resources/silence-loop.mov b/LayoutTests/userscripts/resources/silence-loop.mov
new file mode 100644 (file)
index 0000000..2a4bfe4
Binary files /dev/null and b/LayoutTests/userscripts/resources/silence-loop.mov differ
index 0b25ab0..d639d0d 100644 (file)
@@ -1,4 +1,4 @@
 CONSOLE MESSAGE: line 1: End Script: user-script-video-document.html
-CONSOLE MESSAGE: line 1: Start Script: counting.mp4
-CONSOLE MESSAGE: line 1: End Script: counting.mp4
+CONSOLE MESSAGE: line 1: Start Script: silence-loop.mov
+CONSOLE MESSAGE: line 1: End Script: silence-loop.mov
 
index 1c4db0a..c3b69e5 100644 (file)
@@ -9,6 +9,6 @@ if (window.layoutTestController) {
 </script>
 </head>
 <body>
-<iframe src="resources/counting.mp4"></iframe>
+<iframe src="resources/silence-loop.mov"></iframe>
 </body>
 </html>