Regression(r223149): WebProcessProxy::didClose() no longer refs WebPageProxy objects
authorcdumez@apple.com <cdumez@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 18 Jan 2018 20:10:58 +0000 (20:10 +0000)
committercdumez@apple.com <cdumez@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 18 Jan 2018 20:10:58 +0000 (20:10 +0000)
https://bugs.webkit.org/show_bug.cgi?id=181771
<rdar://problem/36566237>

Reviewed by Brady Eidson.

* UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::didClose):
Use copyToVectorOf<RefPtr<WebPageProxy>>() to maintain pre-r223149 behavior
and ref the pages.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@227157 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/WebKit/ChangeLog
Source/WebKit/UIProcess/WebProcessProxy.cpp

index 6741ee8..71a8771 100644 (file)
@@ -1,3 +1,16 @@
+2018-01-18  Chris Dumez  <cdumez@apple.com>
+
+        Regression(r223149): WebProcessProxy::didClose() no longer refs WebPageProxy objects
+        https://bugs.webkit.org/show_bug.cgi?id=181771
+        <rdar://problem/36566237>
+
+        Reviewed by Brady Eidson.
+
+        * UIProcess/WebProcessProxy.cpp:
+        (WebKit::WebProcessProxy::didClose):
+        Use copyToVectorOf<RefPtr<WebPageProxy>>() to maintain pre-r223149 behavior
+        and ref the pages.
+
 2018-01-18  Dan Bernstein  <mitz@apple.com>
 
         [Xcode] Streamline and future-proof target-macOS-version-dependent build setting definitions
index c3554ac..3a271be 100644 (file)
@@ -628,7 +628,7 @@ void WebProcessProxy::didClose(IPC::Connection&)
 
     webConnection()->didClose();
 
-    auto pages = copyToVector(m_pageMap.values());
+    auto pages = copyToVectorOf<RefPtr<WebPageProxy>>(m_pageMap.values());
 
     shutDown();