Correct argument types in UIScriptController::activateDataListSuggestion after r252062
authorwenson_hsieh@apple.com <wenson_hsieh@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 21 Nov 2019 01:08:30 +0000 (01:08 +0000)
committerwenson_hsieh@apple.com <wenson_hsieh@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 21 Nov 2019 01:08:30 +0000 (01:08 +0000)
https://bugs.webkit.org/show_bug.cgi?id=203116

Reviewed by Tim Horton.

Use `unsigned` to represent `unsigned long` arguments declared in the IDL.

* DumpRenderTree/mac/UIScriptControllerMac.h:
* DumpRenderTree/mac/UIScriptControllerMac.mm:
(WTR::UIScriptControllerMac::activateDataListSuggestion):
* TestRunnerShared/UIScriptContext/UIScriptController.h:
(WTR::UIScriptController::activateDataListSuggestion):
* WebKitTestRunner/ios/UIScriptControllerIOS.h:
* WebKitTestRunner/ios/UIScriptControllerIOS.mm:
(WTR::UIScriptControllerIOS::activateDataListSuggestion):
* WebKitTestRunner/mac/UIScriptControllerMac.h:
* WebKitTestRunner/mac/UIScriptControllerMac.mm:
(WTR::UIScriptControllerMac::activateDataListSuggestion):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@252719 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Tools/ChangeLog
Tools/DumpRenderTree/mac/UIScriptControllerMac.h
Tools/DumpRenderTree/mac/UIScriptControllerMac.mm
Tools/TestRunnerShared/UIScriptContext/UIScriptController.h
Tools/WebKitTestRunner/ios/UIScriptControllerIOS.h
Tools/WebKitTestRunner/ios/UIScriptControllerIOS.mm
Tools/WebKitTestRunner/mac/UIScriptControllerMac.h
Tools/WebKitTestRunner/mac/UIScriptControllerMac.mm

index fc03dec..de35a06 100644 (file)
@@ -1,3 +1,24 @@
+2019-11-20  Wenson Hsieh  <wenson_hsieh@apple.com>
+
+        Correct argument types in UIScriptController::activateDataListSuggestion after r252062
+        https://bugs.webkit.org/show_bug.cgi?id=203116
+
+        Reviewed by Tim Horton.
+
+        Use `unsigned` to represent `unsigned long` arguments declared in the IDL.
+
+        * DumpRenderTree/mac/UIScriptControllerMac.h:
+        * DumpRenderTree/mac/UIScriptControllerMac.mm:
+        (WTR::UIScriptControllerMac::activateDataListSuggestion):
+        * TestRunnerShared/UIScriptContext/UIScriptController.h:
+        (WTR::UIScriptController::activateDataListSuggestion):
+        * WebKitTestRunner/ios/UIScriptControllerIOS.h:
+        * WebKitTestRunner/ios/UIScriptControllerIOS.mm:
+        (WTR::UIScriptControllerIOS::activateDataListSuggestion):
+        * WebKitTestRunner/mac/UIScriptControllerMac.h:
+        * WebKitTestRunner/mac/UIScriptControllerMac.mm:
+        (WTR::UIScriptControllerMac::activateDataListSuggestion):
+
 2019-11-20  Fujii Hironori  <Hironori.Fujii@sony.com>
 
         run-api-tests reports AssertionError os.pathsep not in value in _append_value_colon_separated in Cygwin Python
index 47a8d7a..5aa4a1d 100644 (file)
@@ -50,7 +50,7 @@ public:
     void simulateAccessibilitySettingsChangeNotification(JSValueRef) override;
     NSUndoManager *platformUndoManager() const override;
     void copyText(JSStringRef) override;
-    void activateDataListSuggestion(long, JSValueRef) override;
+    void activateDataListSuggestion(unsigned, JSValueRef) override;
 };
 
 }
index 2e23c6e..c448535 100644 (file)
@@ -100,7 +100,7 @@ JSObjectRef UIScriptControllerMac::contentsOfUserInterfaceItem(JSStringRef inter
 #endif
 }
 
-void UIScriptControllerMac::activateDataListSuggestion(long index, JSValueRef callback)
+void UIScriptControllerMac::activateDataListSuggestion(unsigned index, JSValueRef callback)
 {
     // FIXME: Not implemented.
     UNUSED_PARAM(index);
index a963c83..586b2e4 100644 (file)
@@ -202,7 +202,7 @@ public:
     virtual JSObjectRef calendarType() const { notImplemented(); return nullptr; }
     virtual void setDefaultCalendarType(JSStringRef calendarIdentifier) { notImplemented(); }
     virtual JSObjectRef inputViewBounds() const { notImplemented(); return nullptr; }
-    virtual void activateDataListSuggestion(long, JSValueRef) { notImplemented(); }
+    virtual void activateDataListSuggestion(unsigned, JSValueRef) { notImplemented(); }
 
     // Share Sheet
 
index 5a04570..335e6f0 100644 (file)
@@ -129,7 +129,7 @@ public:
     void beginBackSwipe(JSValueRef) override;
     void completeBackSwipe(JSValueRef) override;
     bool isShowingDataListSuggestions() const override;
-    void activateDataListSuggestion(long, JSValueRef) override;
+    void activateDataListSuggestion(unsigned, JSValueRef) override;
     void drawSquareInEditableImage() override;
     long numberOfStrokesInEditableImage() override;
     void setKeyboardInputModeIdentifier(JSStringRef) override;
index 27f3880..06f0534 100644 (file)
@@ -1032,7 +1032,7 @@ void UIScriptControllerIOS::completeBackSwipe(JSValueRef callback)
     [webView() _completeBackSwipeForTesting];
 }
 
-void UIScriptControllerIOS::activateDataListSuggestion(long index, JSValueRef callback)
+void UIScriptControllerIOS::activateDataListSuggestion(unsigned index, JSValueRef callback)
 {
     // FIXME: Not implemented.
     UNUSED_PARAM(index);
index 18bd378..6121592 100644 (file)
@@ -43,7 +43,7 @@ public:
     double zoomScale() const override;
     void simulateAccessibilitySettingsChangeNotification(JSValueRef) override;
     bool isShowingDataListSuggestions() const override;
-    void activateDataListSuggestion(long index, JSValueRef callback) override;
+    void activateDataListSuggestion(unsigned index, JSValueRef callback) override;
     void beginBackSwipe(JSValueRef) override;
     void completeBackSwipe(JSValueRef) override;
     void playBackEventStream(JSStringRef, JSValueRef) override;
index 1cfefee..c6e145b 100644 (file)
@@ -100,7 +100,7 @@ bool UIScriptControllerMac::isShowingDataListSuggestions() const
     return dataListSuggestionsTableView();
 }
 
-void UIScriptControllerMac::activateDataListSuggestion(long index, JSValueRef callback)
+void UIScriptControllerMac::activateDataListSuggestion(unsigned index, JSValueRef callback)
 {
     unsigned callbackID = m_context->prepareForAsyncTask(callback, CallbackTypeNonPersistent);