Layout test storage/indexeddb/open-during-transaction-private.html is failing
authorsihui_liu@apple.com <sihui_liu@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 23 Jan 2019 01:11:29 +0000 (01:11 +0000)
committersihui_liu@apple.com <sihui_liu@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 23 Jan 2019 01:11:29 +0000 (01:11 +0000)
https://bugs.webkit.org/show_bug.cgi?id=193600

Reviewed by Brady Eidson.

Make sure the second request is finished before the third one so that test ends properly.

* storage/indexeddb/open-during-transaction-expected.txt:
* storage/indexeddb/open-during-transaction-private-expected.txt:
* storage/indexeddb/resources/open-during-transaction.js:
(tryOpens.openreq3.onsuccess):
(tryOpens.openreq2.onsuccess):
(tryOpens):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@240312 268f45cc-cd09-0410-ab3c-d52691b4dbfc

LayoutTests/ChangeLog
LayoutTests/storage/indexeddb/open-during-transaction-expected.txt
LayoutTests/storage/indexeddb/open-during-transaction-private-expected.txt
LayoutTests/storage/indexeddb/resources/open-during-transaction.js

index 5595944..18cbf30 100644 (file)
@@ -1,3 +1,19 @@
+2019-01-22  Sihui Liu  <sihui_liu@apple.com>
+
+        Layout test storage/indexeddb/open-during-transaction-private.html is failing
+        https://bugs.webkit.org/show_bug.cgi?id=193600
+
+        Reviewed by Brady Eidson.
+
+        Make sure the second request is finished before the third one so that test ends properly.
+
+        * storage/indexeddb/open-during-transaction-expected.txt:
+        * storage/indexeddb/open-during-transaction-private-expected.txt:
+        * storage/indexeddb/resources/open-during-transaction.js:
+        (tryOpens.openreq3.onsuccess):
+        (tryOpens.openreq2.onsuccess):
+        (tryOpens):
+
 2019-01-22  Devin Rousso  <drousso@apple.com>
 
         Web Inspector: Audit: provide a way to get related Accessibility properties for a given node
index f195b5b..c925160 100644 (file)
@@ -17,14 +17,12 @@ the transaction is kept alive with a series of puts until opens are complete
 
 trying to open the same database
 openreq2 = indexedDB.open(dbname)
-
-trying to open a different database
-openreq3 = indexedDB.open(dbname + '2')
-
 openreq2.onsuccess
 PASS state is "starting"
 state = 'open2complete'
 
+trying to open a different database
+openreq3 = indexedDB.open(dbname + '2')
 openreq3.onsuccess
 PASS state is "open2complete"
 state = 'open3complete'
index f195b5b..c925160 100644 (file)
@@ -17,14 +17,12 @@ the transaction is kept alive with a series of puts until opens are complete
 
 trying to open the same database
 openreq2 = indexedDB.open(dbname)
-
-trying to open a different database
-openreq3 = indexedDB.open(dbname + '2')
-
 openreq2.onsuccess
 PASS state is "starting"
 state = 'open2complete'
 
+trying to open a different database
+openreq3 = indexedDB.open(dbname + '2')
 openreq3.onsuccess
 PASS state is "open2complete"
 state = 'open3complete'
index 19a56a7..2b6b1de 100644 (file)
@@ -55,17 +55,15 @@ function tryOpens()
         shouldBeEqualToString("state", "starting");
         evalAndLog("state = 'open2complete'");
         debug("");
-    };
-    debug("");
 
-    debug("trying to open a different database");
-    evalAndLog("openreq3 = indexedDB.open(dbname + '2')");
-    openreq3.onerror = unexpectedErrorCallback;
-    openreq3.onsuccess = function (e) {
-        debug("openreq3.onsuccess");
-        shouldBeEqualToString("state", "open2complete");
-        evalAndLog("state = 'open3complete'");
-        debug("");
+        debug("trying to open a different database");
+        evalAndLog("openreq3 = indexedDB.open(dbname + '2')");
+        openreq3.onerror = unexpectedErrorCallback;
+        openreq3.onsuccess = function (e) {
+            debug("openreq3.onsuccess");
+            shouldBeEqualToString("state", "open2complete");
+            evalAndLog("state = 'open3complete'");
+            debug("");
+        };
     };
-    debug("");
 }