Crash running check-webkit-style on webrtc/.../exceptions.py
authorkrollin@apple.com <krollin@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 19 Jun 2018 21:59:37 +0000 (21:59 +0000)
committerkrollin@apple.com <krollin@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 19 Jun 2018 21:59:37 +0000 (21:59 +0000)
https://bugs.webkit.org/show_bug.cgi?id=186816
<rdar://problem/41262553>

Reviewed by Michael Catanzaro.

It's not apparent to me why the crash is occurring. Trying to write a
unittest that checks this file in isolation does not reproduce the
crash. But the crash goes away when updating to pylint-0.25.2.

* Scripts/webkitpy/thirdparty/__init__.py:
(AutoinstallImportHook._install_pylint):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@232987 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Tools/ChangeLog
Tools/Scripts/webkitpy/thirdparty/__init__.py

index 99c16e2..a313fe7 100644 (file)
@@ -1,5 +1,20 @@
 2018-06-19  Keith Rollin  <krollin@apple.com>
 
+        Crash running check-webkit-style on webrtc/.../exceptions.py
+        https://bugs.webkit.org/show_bug.cgi?id=186816
+        <rdar://problem/41262553>
+
+        Reviewed by Michael Catanzaro.
+
+        It's not apparent to me why the crash is occurring. Trying to write a
+        unittest that checks this file in isolation does not reproduce the
+        crash. But the crash goes away when updating to pylint-0.25.2.
+
+        * Scripts/webkitpy/thirdparty/__init__.py:
+        (AutoinstallImportHook._install_pylint):
+
+2018-06-19  Keith Rollin  <krollin@apple.com>
+
         cpp style checker needs to know more about NOLINT
         https://bugs.webkit.org/show_bug.cgi?id=186796
 
index 5f38145..6ca117d 100644 (file)
@@ -160,7 +160,7 @@ class AutoinstallImportHook(object):
                 files_to_remove = ['test/data/write_protected_file.txt']
             installer.install("https://pypi.python.org/packages/source/l/logilab-common/logilab-common-0.58.1.tar.gz#md5=77298ab2d8bb8b4af9219791e7cee8ce", url_subpath="logilab-common-0.58.1", target_name="logilab/common", files_to_remove=files_to_remove)
             installer.install("https://pypi.python.org/packages/source/l/logilab-astng/logilab-astng-0.24.1.tar.gz#md5=ddaf66e4d85714d9c47a46d4bed406de", url_subpath="logilab-astng-0.24.1", target_name="logilab/astng")
-            installer.install('https://pypi.python.org/packages/source/p/pylint/pylint-0.25.1.tar.gz#md5=728bbc2b339bc3749af013709a7f87a5', url_subpath="pylint-0.25.1", target_name="pylint")
+            installer.install('https://pypi.python.org/packages/source/p/pylint/pylint-0.25.2.tar.gz#md5=d878d7688a4f5290dc5b53a836872400', url_subpath="pylint-0.25.2", target_name="pylint")
 
     # autoinstalled.buildbot is used by BuildSlaveSupport/build.webkit.org-config/mastercfg_unittest.py
     # and should ideally match the version of BuildBot used at build.webkit.org.