[Qt] REGRESSION: 5 tests started to fail with newer Qt5
authorcommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 21 Sep 2012 16:26:44 +0000 (16:26 +0000)
committercommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 21 Sep 2012 16:26:44 +0000 (16:26 +0000)
https://bugs.webkit.org/show_bug.cgi?id=90687

Patch by Marcelo Lira <marcelo.lira@openbossa.org> on 2012-09-21
Reviewed by Luiz Agostini.

When sending null data via POST method in  XMLHttpRequest the
expected Content-Type "application/x-www-form-urlencoded",
instead of "application/octet-stream". In fact that was the previously
expected value for Qt, but was changed to conform to Qt 4.8 results.

The cookie test result was updated to follow RFC 6265 behavior, as
already does chromium, gtk, and efl.

* platform/qt-5.0/Skipped:
* platform/qt/http/tests/cookies/double-quoted-value-with-semi-colon-expected.txt: Added.
* platform/qt/http/tests/xmlhttprequest/methods-expected.txt:
* platform/qt/http/tests/xmlhttprequest/workers/methods-async-expected.txt:
* platform/qt/http/tests/xmlhttprequest/workers/methods-expected.txt:
* platform/qt/http/tests/xmlhttprequest/workers/shared-worker-methods-async-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129234 268f45cc-cd09-0410-ab3c-d52691b4dbfc

LayoutTests/ChangeLog
LayoutTests/platform/qt-5.0/Skipped
LayoutTests/platform/qt/http/tests/cookies/double-quoted-value-with-semi-colon-expected.txt [new file with mode: 0644]
LayoutTests/platform/qt/http/tests/xmlhttprequest/methods-expected.txt
LayoutTests/platform/qt/http/tests/xmlhttprequest/workers/methods-async-expected.txt
LayoutTests/platform/qt/http/tests/xmlhttprequest/workers/methods-expected.txt
LayoutTests/platform/qt/http/tests/xmlhttprequest/workers/shared-worker-methods-async-expected.txt

index 01a9bc8..25adc71 100644 (file)
@@ -1,3 +1,25 @@
+2012-09-21  Marcelo Lira  <marcelo.lira@openbossa.org>
+
+        [Qt] REGRESSION: 5 tests started to fail with newer Qt5
+        https://bugs.webkit.org/show_bug.cgi?id=90687
+
+        Reviewed by Luiz Agostini.
+
+        When sending null data via POST method in  XMLHttpRequest the
+        expected Content-Type "application/x-www-form-urlencoded",
+        instead of "application/octet-stream". In fact that was the previously
+        expected value for Qt, but was changed to conform to Qt 4.8 results.
+
+        The cookie test result was updated to follow RFC 6265 behavior, as
+        already does chromium, gtk, and efl.
+
+        * platform/qt-5.0/Skipped:
+        * platform/qt/http/tests/cookies/double-quoted-value-with-semi-colon-expected.txt: Added.
+        * platform/qt/http/tests/xmlhttprequest/methods-expected.txt:
+        * platform/qt/http/tests/xmlhttprequest/workers/methods-async-expected.txt:
+        * platform/qt/http/tests/xmlhttprequest/workers/methods-expected.txt:
+        * platform/qt/http/tests/xmlhttprequest/workers/shared-worker-methods-async-expected.txt:
+
 2012-09-21  Dan Bernstein  <mitz@apple.com>
 
         REGRESSION (r126763): Incorrect line breaking when both kerning and word spacing are enabled
index a0d805e..1f20125 100644 (file)
@@ -73,14 +73,6 @@ http/tests/security/frameNavigation/xss-DENIED-plugin-navigation.html
 # https://bugs.webkit.org/show_bug.cgi?id=89436
 fast/text/line-breaks-after-ideographic-comma-or-full-stop-2.html
 
-# [Qt] REGRESSION: 5 tests started to fail with newer Qt5
-# https://bugs.webkit.org/show_bug.cgi?id=90687
-http/tests/cookies/double-quoted-value-with-semi-colon.html
-http/tests/xmlhttprequest/methods.html
-http/tests/xmlhttprequest/workers/methods-async.html
-http/tests/xmlhttprequest/workers/methods.html
-http/tests/xmlhttprequest/workers/shared-worker-methods-async.html
-
 # [Qt] svg/text/foreignObject-text-clipping-bug giving wrong results
 # https://bugs.webkit.org/show_bug.cgi?id=91893
 svg/text/foreignObject-text-clipping-bug.xml
diff --git a/LayoutTests/platform/qt/http/tests/cookies/double-quoted-value-with-semi-colon-expected.txt b/LayoutTests/platform/qt/http/tests/cookies/double-quoted-value-with-semi-colon-expected.txt
new file mode 100644 (file)
index 0000000..f2cd4f9
--- /dev/null
@@ -0,0 +1,11 @@
+Test for <rdar://problem/5666078> Cookie parsing terminates at the first semicolon, ignoring quotes (16699)
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+Check that setting a cookie with a semi-colon in a duoble-quoted value works
+FAIL cookie was 'disorder="477beccb'. Expected 'disorder="477beccb;richard"'.
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
index caf3f62..0e3520e 100644 (file)
@@ -4,7 +4,7 @@ GET(""): GET(null bytes), Content-Type: null
 GET(null): GET(null bytes), Content-Type: null
 GET("123"): GET(null bytes), Content-Type: null
 POST(""): POST(0 bytes), Content-Type: application/xml
-POST(null): POST(0 bytes), Content-Type: application/octet-stream
+POST(null): POST(0 bytes), Content-Type: application/x-www-form-urlencoded
 POST("123"): POST(3 bytes), Content-Type: application/xml
 PUT(""): PUT(0 bytes), Content-Type: application/xml
 PUT(null): PUT(0 bytes), Content-Type: null
index 888b061..6fa8965 100644 (file)
@@ -4,7 +4,7 @@ GET(""): GET(null bytes), Content-Type: null
 GET(null): GET(null bytes), Content-Type: null
 GET("123"): GET(null bytes), Content-Type: null
 POST(""): POST(0 bytes), Content-Type: application/xml
-POST(null): POST(0 bytes), Content-Type: application/octet-stream
+POST(null): POST(0 bytes), Content-Type: application/x-www-form-urlencoded
 POST("123"): POST(3 bytes), Content-Type: application/xml
 PUT(""): PUT(0 bytes), Content-Type: application/xml
 PUT(null): PUT(0 bytes), Content-Type: null
index 888b061..6fa8965 100644 (file)
@@ -4,7 +4,7 @@ GET(""): GET(null bytes), Content-Type: null
 GET(null): GET(null bytes), Content-Type: null
 GET("123"): GET(null bytes), Content-Type: null
 POST(""): POST(0 bytes), Content-Type: application/xml
-POST(null): POST(0 bytes), Content-Type: application/octet-stream
+POST(null): POST(0 bytes), Content-Type: application/x-www-form-urlencoded
 POST("123"): POST(3 bytes), Content-Type: application/xml
 PUT(""): PUT(0 bytes), Content-Type: application/xml
 PUT(null): PUT(0 bytes), Content-Type: null
index 5991de5..ba5a833 100644 (file)
@@ -4,7 +4,7 @@ GET(""): GET(null bytes), Content-Type: null
 GET(null): GET(null bytes), Content-Type: null
 GET("123"): GET(null bytes), Content-Type: null
 POST(""): POST(0 bytes), Content-Type: application/xml
-POST(null): POST(0 bytes), Content-Type: application/octet-stream
+POST(null): POST(0 bytes), Content-Type: application/x-www-form-urlencoded
 POST("123"): POST(3 bytes), Content-Type: application/xml
 PUT(""): PUT(0 bytes), Content-Type: application/xml
 PUT(null): PUT(0 bytes), Content-Type: null