2011-04-12 John Abd-El-Malek <jam@chromium.org>
authorjam@chromium.org <jam@chromium.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 12 Apr 2011 23:22:13 +0000 (23:22 +0000)
committerjam@chromium.org <jam@chromium.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 12 Apr 2011 23:22:13 +0000 (23:22 +0000)
        Reviewed by Jian Li.

        [chromium] Fix spellcheck regression in context menus
        https://bugs.webkit.org/show_bug.cgi?id=58386

        * src/ContextMenuClientImpl.cpp:
        (WebKit::ContextMenuClientImpl::getCustomMenuFromDefaultItems):
2011-04-12  John Abd-El-Malek  <jam@chromium.org>

        Reviewed by Jian Li.

        [chromium] Fix spellcheck regression in context menus
        https://bugs.webkit.org/show_bug.cgi?id=58386

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83660 268f45cc-cd09-0410-ab3c-d52691b4dbfc

LayoutTests/ChangeLog
LayoutTests/platform/chromium/test_expectations.txt
Source/WebKit/chromium/ChangeLog
Source/WebKit/chromium/src/ContextMenuClientImpl.cpp

index 1b2aef0..cc4a6df 100644 (file)
@@ -1,3 +1,12 @@
+2011-04-12  John Abd-El-Malek  <jam@chromium.org>
+
+        Reviewed by Jian Li.
+
+        [chromium] Fix spellcheck regression in context menus
+        https://bugs.webkit.org/show_bug.cgi?id=58386
+
+        * platform/chromium/test_expectations.txt:
+
 2011-04-11  Jer Noble  <jer.noble@apple.com>
 
         Reviewed by Simon Fraser.
index 1dd095d..271f585 100644 (file)
@@ -3495,9 +3495,6 @@ BUGWK58328 GPU MAC DEBUG : compositing/webgl/webgl-reflection.html = PASS CRASH
 
 BUGCR79173 GPU LINUX DEBUG : fast/canvas/access-zero-sized-canvas.html = PASS CRASH
 
-// Regression caused by r83617. jam is going to fix it.
-BUGJAM: editing/spelling/context-menu-suggestions.html = TEXT
-
 // Regression caused by r83628.
 BUGCR79241 : http/tests/misc/favicon-loads-with-icon-loading-override.html = TEXT
 
index b2f6802..babd197 100644 (file)
@@ -1,3 +1,13 @@
+2011-04-12  John Abd-El-Malek  <jam@chromium.org>
+
+        Reviewed by Jian Li.
+
+        [chromium] Fix spellcheck regression in context menus
+        https://bugs.webkit.org/show_bug.cgi?id=58386
+
+        * src/ContextMenuClientImpl.cpp:
+        (WebKit::ContextMenuClientImpl::getCustomMenuFromDefaultItems):
+
 2011-04-12  Noel Gordon  <noel.gordon@gmail.com>
 
         Reviewed by Tony Chang.
index d5c86ab..0f82d38 100644 (file)
@@ -264,9 +264,8 @@ PlatformMenuDescription ContextMenuClientImpl::getCustomMenuFromDefaultItems(
                     m_webView->spellCheckClient()->spellCheck(
                         data.misspelledWord, misspelledOffset, misspelledLength,
                         &data.dictionarySuggestions);
-                    if (!misspelledOffset)
+                    if (!misspelledLength)
                         data.misspelledWord.reset();
-
                 }
             }
         }