[Win][PlayStation] Remove WebCore::standardUserAgentForURL
authorHironori.Fujii@sony.com <Hironori.Fujii@sony.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 13 Mar 2019 07:48:12 +0000 (07:48 +0000)
committerHironori.Fujii@sony.com <Hironori.Fujii@sony.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 13 Mar 2019 07:48:12 +0000 (07:48 +0000)
https://bugs.webkit.org/show_bug.cgi?id=195662

Reviewed by Ryosuke Niwa.

Source/WebCore:

WebCore::standardUserAgentForURL is just a stub in Windows port.

No new tests because there is no behavior change.

* platform/win/UserAgentWin.cpp:
(WebCore::standardUserAgentForURL): Deleted.
* platform/playstation/UserAgentPlayStation.cpp:
(WebCore::standardUserAgentForURL): Deleted.

Source/WebKit:

* WebProcess/WebPage/win/WebPageWin.cpp:
(WebKit::WebPage::platformUserAgent const): Return an empty string as well as mac/ios ports.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@242847 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/WebCore/ChangeLog
Source/WebCore/platform/playstation/UserAgentPlayStation.cpp
Source/WebCore/platform/win/UserAgentWin.cpp
Source/WebKit/ChangeLog
Source/WebKit/WebProcess/WebPage/win/WebPageWin.cpp

index e340106..2c023f5 100644 (file)
@@ -1,3 +1,19 @@
+2019-03-13  Fujii Hironori  <Hironori.Fujii@sony.com>
+
+        [Win][PlayStation] Remove WebCore::standardUserAgentForURL
+        https://bugs.webkit.org/show_bug.cgi?id=195662
+
+        Reviewed by Ryosuke Niwa.
+
+        WebCore::standardUserAgentForURL is just a stub in Windows port.
+
+        No new tests because there is no behavior change.
+
+        * platform/win/UserAgentWin.cpp:
+        (WebCore::standardUserAgentForURL): Deleted.
+        * platform/playstation/UserAgentPlayStation.cpp:
+        (WebCore::standardUserAgentForURL): Deleted.
+
 2019-03-12  Ross Kirsling  <ross.kirsling@sony.com>
 
         [Win] Fix a slew of simple clang-cl warnings.
index a56e551..84ff358 100644 (file)
@@ -33,10 +33,4 @@ String standardUserAgent(const String&, const String&)
     return emptyString();
 }
 
-String standardUserAgentForURL(const URL&)
-{
-    // The null string means we don't need a specific UA for the given URL.
-    return emptyString();
-}
-
 } // namespace WebCore
index 8201f4e..fc45ff0 100644 (file)
@@ -49,10 +49,4 @@ String standardUserAgent(const String& applicationName, const String& applicatio
     return uaString.toString();
 }
 
-String standardUserAgentForURL(const URL& url)
-{
-    // The null string means we don't need a specific UA for the given URL.
-    return { };
-}
-
 } // namespace WebCore
index 3b1c948..3e4927a 100644 (file)
@@ -1,3 +1,13 @@
+2019-03-13  Fujii Hironori  <Hironori.Fujii@sony.com>
+
+        [Win][PlayStation] Remove WebCore::standardUserAgentForURL
+        https://bugs.webkit.org/show_bug.cgi?id=195662
+
+        Reviewed by Ryosuke Niwa.
+
+        * WebProcess/WebPage/win/WebPageWin.cpp:
+        (WebKit::WebPage::platformUserAgent const): Return an empty string as well as mac/ios ports.
+
 2019-03-12  Ross Kirsling  <ross.kirsling@sony.com>
 
         [Win] Fix a slew of simple clang-cl warnings.
index 12d6de7..31df42d 100644 (file)
@@ -113,12 +113,9 @@ bool WebPage::platformCanHandleRequest(const ResourceRequest&)
     return false;
 }
 
-String WebPage::platformUserAgent(const URL& url) const
+String WebPage::platformUserAgent(const URL&) const
 {
-    if (url.isNull() || !m_page->settings().needsSiteSpecificQuirks())
-        return String();
-
-    return WebCore::standardUserAgentForURL(url);
+    return { };
 }
 
 static const unsigned CtrlKey = 1 << 0;