Regression(PSON) WebKit.GeolocationTransitionToHighAccuracy API test is timing out
authorcdumez@apple.com <cdumez@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Sat, 17 Nov 2018 00:17:32 +0000 (00:17 +0000)
committercdumez@apple.com <cdumez@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Sat, 17 Nov 2018 00:17:32 +0000 (00:17 +0000)
https://bugs.webkit.org/show_bug.cgi?id=191789

Reviewed by Alex Christensen.

Relate the 2 test pages so they use the same process since WKContextSetMaximumNumberOfProcesses()
SPI no longer works with PSON / Process prewarming.

* TestWebKitAPI/Tests/WebKit/Geolocation.cpp:
(TestWebKitAPI::TEST):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@238323 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Tools/ChangeLog
Tools/TestWebKitAPI/Tests/WebKit/Geolocation.cpp

index 0afb06a..16a9b7b 100644 (file)
@@ -1,3 +1,16 @@
+2018-11-16  Chris Dumez  <cdumez@apple.com>
+
+        Regression(PSON) WebKit.GeolocationTransitionToHighAccuracy API test is timing out
+        https://bugs.webkit.org/show_bug.cgi?id=191789
+
+        Reviewed by Alex Christensen.
+
+        Relate the 2 test pages so they use the same process since WKContextSetMaximumNumberOfProcesses()
+        SPI no longer works with PSON / Process prewarming.
+
+        * TestWebKitAPI/Tests/WebKit/Geolocation.cpp:
+        (TestWebKitAPI::TEST):
+
 2018-11-16  Jonathan Bedard  <jbedard@apple.com>
 
         webkitpy: Retry app installation on watchOS simulators
index 53ad244..d84fa99 100644 (file)
@@ -257,7 +257,6 @@ struct GeolocationTransitionToHighAccuracyStateTracker : GeolocationStateTracker
 TEST(WebKit, GeolocationTransitionToHighAccuracy)
 {
     WKRetainPtr<WKContextRef> context(AdoptWK, WKContextCreate());
-    WKContextSetMaximumNumberOfProcesses(context.get(), 1);
 
     GeolocationTransitionToHighAccuracyStateTracker stateTracker;
     setupGeolocationProvider(context.get(), &stateTracker);
@@ -268,7 +267,7 @@ TEST(WebKit, GeolocationTransitionToHighAccuracy)
     WKPageLoadURL(lowAccuracyWebView.page(), lowAccuracyURL.get());
     Util::run(&stateTracker.finishedFirstStep);
 
-    PlatformWebView highAccuracyWebView(context.get());
+    PlatformWebView highAccuracyWebView(lowAccuracyWebView.page());
     setupView(highAccuracyWebView);
     WKRetainPtr<WKURLRef> highAccuracyURL(AdoptWK, Util::createURLForResource("geolocationWatchPositionWithHighAccuracy", "html"));
     WKPageLoadURL(highAccuracyWebView.page(), highAccuracyURL.get());