Const-ify some IDB code.
authorbeidson@apple.com <beidson@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 3 May 2016 01:01:53 +0000 (01:01 +0000)
committerbeidson@apple.com <beidson@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 3 May 2016 01:01:53 +0000 (01:01 +0000)
https://bugs.webkit.org/show_bug.cgi?id=157287

Reviewed by Alex Christensen.

Source/WebCore:

No new tests (Refactor only).

* Modules/indexeddb/client/IDBConnectionToServerDelegate.h:
* Modules/indexeddb/shared/InProcessIDBServer.cpp:
(WebCore::InProcessIDBServer::deleteDatabase):
(WebCore::InProcessIDBServer::openDatabase):
(WebCore::InProcessIDBServer::abortTransaction):
(WebCore::InProcessIDBServer::commitTransaction):
(WebCore::InProcessIDBServer::didFinishHandlingVersionChangeTransaction):
* Modules/indexeddb/shared/InProcessIDBServer.h:

Source/WebKit2:

* WebProcess/Databases/IndexedDB/WebIDBConnectionToServer.cpp:
(WebKit::WebIDBConnectionToServer::deleteDatabase):
(WebKit::WebIDBConnectionToServer::openDatabase):
(WebKit::WebIDBConnectionToServer::abortTransaction):
(WebKit::WebIDBConnectionToServer::commitTransaction):
(WebKit::WebIDBConnectionToServer::didFinishHandlingVersionChangeTransaction):
* WebProcess/Databases/IndexedDB/WebIDBConnectionToServer.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@200352 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/WebCore/ChangeLog
Source/WebCore/Modules/indexeddb/client/IDBConnectionToServerDelegate.h
Source/WebCore/Modules/indexeddb/shared/InProcessIDBServer.cpp
Source/WebCore/Modules/indexeddb/shared/InProcessIDBServer.h
Source/WebKit2/ChangeLog
Source/WebKit2/WebProcess/Databases/IndexedDB/WebIDBConnectionToServer.cpp
Source/WebKit2/WebProcess/Databases/IndexedDB/WebIDBConnectionToServer.h

index 79fa53b..f7f682d 100644 (file)
@@ -1,3 +1,21 @@
+2016-05-02  Brady Eidson  <beidson@apple.com>
+
+        Const-ify some IDB code.
+        https://bugs.webkit.org/show_bug.cgi?id=157287
+
+        Reviewed by Alex Christensen.
+
+        No new tests (Refactor only).
+
+        * Modules/indexeddb/client/IDBConnectionToServerDelegate.h:
+        * Modules/indexeddb/shared/InProcessIDBServer.cpp:
+        (WebCore::InProcessIDBServer::deleteDatabase):
+        (WebCore::InProcessIDBServer::openDatabase):
+        (WebCore::InProcessIDBServer::abortTransaction):
+        (WebCore::InProcessIDBServer::commitTransaction):
+        (WebCore::InProcessIDBServer::didFinishHandlingVersionChangeTransaction):
+        * Modules/indexeddb/shared/InProcessIDBServer.h:
+
 2016-05-02  Antti Koivisto  <antti@apple.com>
 
         REGRESSION(r199964): Animation on pseudo elements doesn't trigger if first frame matches the current style
index d8031c8..bf9f2c2 100644 (file)
@@ -57,11 +57,11 @@ public:
     virtual ~IDBConnectionToServerDelegate() { }
 
     virtual uint64_t identifier() const = 0;
-    virtual void deleteDatabase(IDBRequestData&) = 0;
-    virtual void openDatabase(IDBRequestData&) = 0;
-    virtual void abortTransaction(IDBResourceIdentifier&) = 0;
-    virtual void commitTransaction(IDBResourceIdentifier&) = 0;
-    virtual void didFinishHandlingVersionChangeTransaction(IDBResourceIdentifier&) = 0;
+    virtual void deleteDatabase(const IDBRequestData&) = 0;
+    virtual void openDatabase(const IDBRequestData&) = 0;
+    virtual void abortTransaction(const IDBResourceIdentifier&) = 0;
+    virtual void commitTransaction(const IDBResourceIdentifier&) = 0;
+    virtual void didFinishHandlingVersionChangeTransaction(const IDBResourceIdentifier&) = 0;
     virtual void createObjectStore(const IDBRequestData&, const IDBObjectStoreInfo&) = 0;
     virtual void deleteObjectStore(const IDBRequestData&, const String& objectStoreName) = 0;
     virtual void clearObjectStore(const IDBRequestData&, uint64_t objectStoreIdentifier) = 0;
index 31dfaa6..3a08249 100644 (file)
@@ -89,7 +89,7 @@ IDBServer::IDBConnectionToClient& InProcessIDBServer::connectionToClient() const
     return *m_connectionToClient;
 }
 
-void InProcessIDBServer::deleteDatabase(IDBRequestData& requestData)
+void InProcessIDBServer::deleteDatabase(const IDBRequestData& requestData)
 {
     RefPtr<InProcessIDBServer> self(this);
     RunLoop::current().dispatch([this, self, requestData] {
@@ -105,7 +105,7 @@ void InProcessIDBServer::didDeleteDatabase(const IDBResultData& resultData)
     });
 }
 
-void InProcessIDBServer::openDatabase(IDBRequestData& requestData)
+void InProcessIDBServer::openDatabase(const IDBRequestData& requestData)
 {
     RefPtr<InProcessIDBServer> self(this);
     RunLoop::current().dispatch([this, self, requestData] {
@@ -225,7 +225,7 @@ void InProcessIDBServer::didIterateCursor(const IDBResultData& resultData)
     });
 }
 
-void InProcessIDBServer::abortTransaction(IDBResourceIdentifier& resourceIdentifier)
+void InProcessIDBServer::abortTransaction(const IDBResourceIdentifier& resourceIdentifier)
 {
     RefPtr<InProcessIDBServer> self(this);
     RunLoop::current().dispatch([this, self, resourceIdentifier] {
@@ -233,7 +233,7 @@ void InProcessIDBServer::abortTransaction(IDBResourceIdentifier& resourceIdentif
     });
 }
 
-void InProcessIDBServer::commitTransaction(IDBResourceIdentifier& resourceIdentifier)
+void InProcessIDBServer::commitTransaction(const IDBResourceIdentifier& resourceIdentifier)
 {
     RefPtr<InProcessIDBServer> self(this);
     RunLoop::current().dispatch([this, self, resourceIdentifier] {
@@ -241,7 +241,7 @@ void InProcessIDBServer::commitTransaction(IDBResourceIdentifier& resourceIdenti
     });
 }
 
-void InProcessIDBServer::didFinishHandlingVersionChangeTransaction(IDBResourceIdentifier& transactionIdentifier)
+void InProcessIDBServer::didFinishHandlingVersionChangeTransaction(const IDBResourceIdentifier& transactionIdentifier)
 {
     RefPtr<InProcessIDBServer> self(this);
     RunLoop::current().dispatch([this, self, transactionIdentifier] {
index d047def..2edb210 100644 (file)
@@ -55,11 +55,11 @@ public:
     IDBServer::IDBConnectionToClient& connectionToClient() const;
 
     // IDBConnectionToServer
-    void deleteDatabase(IDBRequestData&) final;
-    void openDatabase(IDBRequestData&) final;
-    void abortTransaction(IDBResourceIdentifier&) final;
-    void commitTransaction(IDBResourceIdentifier&) final;
-    void didFinishHandlingVersionChangeTransaction(IDBResourceIdentifier&) final;
+    void deleteDatabase(const IDBRequestData&) final;
+    void openDatabase(const IDBRequestData&) final;
+    void abortTransaction(const IDBResourceIdentifier&) final;
+    void commitTransaction(const IDBResourceIdentifier&) final;
+    void didFinishHandlingVersionChangeTransaction(const IDBResourceIdentifier&) final;
     void createObjectStore(const IDBRequestData&, const IDBObjectStoreInfo&) final;
     void deleteObjectStore(const IDBRequestData&, const String& objectStoreName) final;
     void clearObjectStore(const IDBRequestData&, uint64_t objectStoreIdentifier) final;
index 0cdfef1..693ad63 100644 (file)
@@ -1,3 +1,18 @@
+2016-05-02  Brady Eidson  <beidson@apple.com>
+
+        Const-ify some IDB code.
+        https://bugs.webkit.org/show_bug.cgi?id=157287
+
+        Reviewed by Alex Christensen.
+
+        * WebProcess/Databases/IndexedDB/WebIDBConnectionToServer.cpp:
+        (WebKit::WebIDBConnectionToServer::deleteDatabase):
+        (WebKit::WebIDBConnectionToServer::openDatabase):
+        (WebKit::WebIDBConnectionToServer::abortTransaction):
+        (WebKit::WebIDBConnectionToServer::commitTransaction):
+        (WebKit::WebIDBConnectionToServer::didFinishHandlingVersionChangeTransaction):
+        * WebProcess/Databases/IndexedDB/WebIDBConnectionToServer.h:
+
 2016-05-02  Simon Fraser  <simon.fraser@apple.com>
 
         Sort the project file.
index a123c04..ec1038b 100644 (file)
@@ -81,27 +81,27 @@ IDBClient::IDBConnectionToServer& WebIDBConnectionToServer::coreConnectionToServ
     return *m_connectionToServer;
 }
 
-void WebIDBConnectionToServer::deleteDatabase(IDBRequestData& requestData)
+void WebIDBConnectionToServer::deleteDatabase(const IDBRequestData& requestData)
 {
     send(Messages::WebIDBConnectionToClient::DeleteDatabase(requestData));
 }
 
-void WebIDBConnectionToServer::openDatabase(IDBRequestData& requestData)
+void WebIDBConnectionToServer::openDatabase(const IDBRequestData& requestData)
 {
     send(Messages::WebIDBConnectionToClient::OpenDatabase(requestData));
 }
 
-void WebIDBConnectionToServer::abortTransaction(IDBResourceIdentifier& transactionIdentifier)
+void WebIDBConnectionToServer::abortTransaction(const IDBResourceIdentifier& transactionIdentifier)
 {
     send(Messages::WebIDBConnectionToClient::AbortTransaction(transactionIdentifier));
 }
 
-void WebIDBConnectionToServer::commitTransaction(IDBResourceIdentifier& transactionIdentifier)
+void WebIDBConnectionToServer::commitTransaction(const IDBResourceIdentifier& transactionIdentifier)
 {
     send(Messages::WebIDBConnectionToClient::CommitTransaction(transactionIdentifier));
 }
 
-void WebIDBConnectionToServer::didFinishHandlingVersionChangeTransaction(IDBResourceIdentifier& transactionIdentifier)
+void WebIDBConnectionToServer::didFinishHandlingVersionChangeTransaction(const IDBResourceIdentifier& transactionIdentifier)
 {
     send(Messages::WebIDBConnectionToClient::DidFinishHandlingVersionChangeTransaction(transactionIdentifier));
 }
index 78d70b1..5ea0c4c 100644 (file)
@@ -45,11 +45,11 @@ public:
     uint64_t messageSenderDestinationID() final { return m_identifier; }
 
     // IDBConnectionToServerDelegate
-    void deleteDatabase(WebCore::IDBRequestData&) final;
-    void openDatabase(WebCore::IDBRequestData&) final;
-    void abortTransaction(WebCore::IDBResourceIdentifier&) final;
-    void commitTransaction(WebCore::IDBResourceIdentifier&) final;
-    void didFinishHandlingVersionChangeTransaction(WebCore::IDBResourceIdentifier&) final;
+    void deleteDatabase(const WebCore::IDBRequestData&) final;
+    void openDatabase(const WebCore::IDBRequestData&) final;
+    void abortTransaction(const WebCore::IDBResourceIdentifier&) final;
+    void commitTransaction(const WebCore::IDBResourceIdentifier&) final;
+    void didFinishHandlingVersionChangeTransaction(const WebCore::IDBResourceIdentifier&) final;
     void createObjectStore(const WebCore::IDBRequestData&, const WebCore::IDBObjectStoreInfo&) final;
     void deleteObjectStore(const WebCore::IDBRequestData&, const String& objectStoreName) final;
     void clearObjectStore(const WebCore::IDBRequestData&, uint64_t objectStoreIdentifier) final;