Make generate_offset_extractor.rb architectures argument more robust

https://bugs.webkit.org/show_bug.cgi?id=175809

Reviewed by Joseph Pecoraro.

It turns out that some of our builders pass their architectures as
space separated lists.  I decided to just make the splitting of
our list robust to any reasonable combination of spaces and
commas.

* offlineasm/generate_offset_extractor.rb:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@221000 268f45cc-cd09-0410-ab3c-d52691b4dbfc

diff --git a/Source/JavaScriptCore/ChangeLog b/Source/JavaScriptCore/ChangeLog
index 686cbed..15e5463 100644 (file)
--- a/Source/JavaScriptCore/ChangeLog
+++ b/Source/JavaScriptCore/ChangeLog
@@ -1,5 +1,19 @@
 2017-08-21  Keith Miller  <keith_miller@apple.com>
 
+        Make generate_offset_extractor.rb architectures argument more robust
+        https://bugs.webkit.org/show_bug.cgi?id=175809
+
+        Reviewed by Joseph Pecoraro.
+
+        It turns out that some of our builders pass their architectures as
+        space separated lists.  I decided to just make the splitting of
+        our list robust to any reasonable combination of spaces and
+        commas.
+
+        * offlineasm/generate_offset_extractor.rb:
+
+2017-08-21  Keith Miller  <keith_miller@apple.com>
+
         Only generate offline asm for the ARCHS (xcodebuild) or the current system (CMake)
         https://bugs.webkit.org/show_bug.cgi?id=175690
 

diff --git a/Source/JavaScriptCore/offlineasm/generate_offset_extractor.rb b/Source/JavaScriptCore/offlineasm/generate_offset_extractor.rb
index 1cc54c1..052008c 100644 (file)
--- a/Source/JavaScriptCore/offlineasm/generate_offset_extractor.rb
+++ b/Source/JavaScriptCore/offlineasm/generate_offset_extractor.rb
@@ -39,7 +39,7 @@ IncludeFile.processIncludeOptions()
 inputFlnm = ARGV.shift
 outputFlnm = ARGV.shift
 
-validBackends = canonicalizeBackendNames(ARGV.shift.split(","))
+validBackends = canonicalizeBackendNames(ARGV.shift.split(/[,\s]+/))
 $stderr.puts "Only dealing with backends: #{validBackends}"
 includeOnlyBackends(validBackends)