Add references to bug 179167 in FIXME comments
authorfred.wang@free.fr <fred.wang@free.fr@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 2 Nov 2017 13:56:48 +0000 (13:56 +0000)
committerfred.wang@free.fr <fred.wang@free.fr@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 2 Nov 2017 13:56:48 +0000 (13:56 +0000)
https://bugs.webkit.org/show_bug.cgi?id=179168

Patch by Frederic Wang <fwang@igalia.com> on 2017-11-02
Reviewed by Daniel Bates.

Source/JavaScriptCore:

* Configurations/FeatureDefines.xcconfig:

Source/WebCore:

* Configurations/FeatureDefines.xcconfig:

Source/WebCore/PAL:

* Configurations/FeatureDefines.xcconfig:

Source/WebKit:

* Configurations/FeatureDefines.xcconfig:

Source/WebKitLegacy/mac:

* Configurations/FeatureDefines.xcconfig:

Source/WTF:

* wtf/FeatureDefines.h:

Tools:

* TestWebKitAPI/Configurations/FeatureDefines.xcconfig:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@224330 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 files changed:
Source/JavaScriptCore/ChangeLog
Source/JavaScriptCore/Configurations/FeatureDefines.xcconfig
Source/WTF/ChangeLog
Source/WTF/wtf/FeatureDefines.h
Source/WebCore/ChangeLog
Source/WebCore/Configurations/FeatureDefines.xcconfig
Source/WebCore/PAL/ChangeLog
Source/WebCore/PAL/Configurations/FeatureDefines.xcconfig
Source/WebKit/ChangeLog
Source/WebKit/Configurations/FeatureDefines.xcconfig
Source/WebKitLegacy/mac/ChangeLog
Source/WebKitLegacy/mac/Configurations/FeatureDefines.xcconfig
Tools/ChangeLog
Tools/TestWebKitAPI/Configurations/FeatureDefines.xcconfig

index ece8e26..0cfc6f2 100644 (file)
@@ -1,3 +1,12 @@
+2017-11-02  Frederic Wang  <fwang@igalia.com>
+
+        Add references to bug 179167 in FIXME comments
+        https://bugs.webkit.org/show_bug.cgi?id=179168
+
+        Reviewed by Daniel Bates.
+
+        * Configurations/FeatureDefines.xcconfig:
+
 2017-11-01  Jeremy Jones  <jeremyj@apple.com>
 
         Implement WKFullscreenWindowController for iOS.
index 338104a..a6b93cd 100644 (file)
@@ -189,7 +189,7 @@ ENABLE_CSS_TRAILING_WORD = ENABLE_CSS_TRAILING_WORD;
 ENABLE_USER_MESSAGE_HANDLERS = ENABLE_USER_MESSAGE_HANDLERS;
 
 // FIXME: Remove the USE_INTERNAL_SDK condition once we support touch events when building for iOS with
-// the public SDK. We will also need to update FeatureDefines.h.
+// the public SDK. See <https://webkit.org/b/179167>.
 ENABLE_TOUCH_EVENTS[sdk=iphone*] = $(ENABLE_TOUCH_EVENTS_ios_WITH_INTERNAL_SDK_$(USE_INTERNAL_SDK));
 ENABLE_TOUCH_EVENTS_ios_WITH_INTERNAL_SDK_YES = ENABLE_TOUCH_EVENTS;
 
index 9814f7e..e614b77 100644 (file)
@@ -1,3 +1,12 @@
+2017-11-02  Frederic Wang  <fwang@igalia.com>
+
+        Add references to bug 179167 in FIXME comments
+        https://bugs.webkit.org/show_bug.cgi?id=179168
+
+        Reviewed by Daniel Bates.
+
+        * wtf/FeatureDefines.h:
+
 2017-11-01  Jiewen Tan  <jiewen_tan@apple.com>
 
         Let is<T>() accept RefPtrs
index a93981e..e8cddf6 100644 (file)
 #endif
 
 /* FIXME: Remove the USE(APPLE_INTERNAL_SDK) conjunct once we support touch events when building against
-the public iOS SDK. We will also need to update the FeatureDefines.xcconfig files. */
+the public iOS SDK. See <https://webkit.org/b/179167>. */
 #if !defined(ENABLE_TOUCH_EVENTS) && USE(APPLE_INTERNAL_SDK)
 #define ENABLE_TOUCH_EVENTS 1
 #endif
index 51a03ac..5158b2a 100644 (file)
@@ -1,3 +1,12 @@
+2017-11-02  Frederic Wang  <fwang@igalia.com>
+
+        Add references to bug 179167 in FIXME comments
+        https://bugs.webkit.org/show_bug.cgi?id=179168
+
+        Reviewed by Daniel Bates.
+
+        * Configurations/FeatureDefines.xcconfig:
+
 2017-11-02  Antti Koivisto  <antti@apple.com>
 
         Remove empty continuations in RenderObject::removeFromParentAndDestroyCleaningUpAnonymousWrappers
index 338104a..a6b93cd 100644 (file)
@@ -189,7 +189,7 @@ ENABLE_CSS_TRAILING_WORD = ENABLE_CSS_TRAILING_WORD;
 ENABLE_USER_MESSAGE_HANDLERS = ENABLE_USER_MESSAGE_HANDLERS;
 
 // FIXME: Remove the USE_INTERNAL_SDK condition once we support touch events when building for iOS with
-// the public SDK. We will also need to update FeatureDefines.h.
+// the public SDK. See <https://webkit.org/b/179167>.
 ENABLE_TOUCH_EVENTS[sdk=iphone*] = $(ENABLE_TOUCH_EVENTS_ios_WITH_INTERNAL_SDK_$(USE_INTERNAL_SDK));
 ENABLE_TOUCH_EVENTS_ios_WITH_INTERNAL_SDK_YES = ENABLE_TOUCH_EVENTS;
 
index 7ea1292..33bbb2a 100644 (file)
@@ -1,3 +1,12 @@
+2017-11-02  Frederic Wang  <fwang@igalia.com>
+
+        Add references to bug 179167 in FIXME comments
+        https://bugs.webkit.org/show_bug.cgi?id=179168
+
+        Reviewed by Daniel Bates.
+
+        * Configurations/FeatureDefines.xcconfig:
+
 2017-11-01  Jeremy Jones  <jeremyj@apple.com>
 
         Implement WKFullscreenWindowController for iOS.
index 338104a..a6b93cd 100644 (file)
@@ -189,7 +189,7 @@ ENABLE_CSS_TRAILING_WORD = ENABLE_CSS_TRAILING_WORD;
 ENABLE_USER_MESSAGE_HANDLERS = ENABLE_USER_MESSAGE_HANDLERS;
 
 // FIXME: Remove the USE_INTERNAL_SDK condition once we support touch events when building for iOS with
-// the public SDK. We will also need to update FeatureDefines.h.
+// the public SDK. See <https://webkit.org/b/179167>.
 ENABLE_TOUCH_EVENTS[sdk=iphone*] = $(ENABLE_TOUCH_EVENTS_ios_WITH_INTERNAL_SDK_$(USE_INTERNAL_SDK));
 ENABLE_TOUCH_EVENTS_ios_WITH_INTERNAL_SDK_YES = ENABLE_TOUCH_EVENTS;
 
index e4c6d47..e5f92aa 100644 (file)
@@ -1,3 +1,12 @@
+2017-11-02  Frederic Wang  <fwang@igalia.com>
+
+        Add references to bug 179167 in FIXME comments
+        https://bugs.webkit.org/show_bug.cgi?id=179168
+
+        Reviewed by Daniel Bates.
+
+        * Configurations/FeatureDefines.xcconfig:
+
 2017-11-01  Jeremy Jones  <jeremyj@apple.com>
 
         Implement WKFullscreenWindowController for iOS.
index 338104a..a6b93cd 100644 (file)
@@ -189,7 +189,7 @@ ENABLE_CSS_TRAILING_WORD = ENABLE_CSS_TRAILING_WORD;
 ENABLE_USER_MESSAGE_HANDLERS = ENABLE_USER_MESSAGE_HANDLERS;
 
 // FIXME: Remove the USE_INTERNAL_SDK condition once we support touch events when building for iOS with
-// the public SDK. We will also need to update FeatureDefines.h.
+// the public SDK. See <https://webkit.org/b/179167>.
 ENABLE_TOUCH_EVENTS[sdk=iphone*] = $(ENABLE_TOUCH_EVENTS_ios_WITH_INTERNAL_SDK_$(USE_INTERNAL_SDK));
 ENABLE_TOUCH_EVENTS_ios_WITH_INTERNAL_SDK_YES = ENABLE_TOUCH_EVENTS;
 
index bbb9c1b..13637f6 100644 (file)
@@ -1,3 +1,12 @@
+2017-11-02  Frederic Wang  <fwang@igalia.com>
+
+        Add references to bug 179167 in FIXME comments
+        https://bugs.webkit.org/show_bug.cgi?id=179168
+
+        Reviewed by Daniel Bates.
+
+        * Configurations/FeatureDefines.xcconfig:
+
 2017-11-01  Jeremy Jones  <jeremyj@apple.com>
 
         Implement WKFullscreenWindowController for iOS.
index 338104a..a6b93cd 100644 (file)
@@ -189,7 +189,7 @@ ENABLE_CSS_TRAILING_WORD = ENABLE_CSS_TRAILING_WORD;
 ENABLE_USER_MESSAGE_HANDLERS = ENABLE_USER_MESSAGE_HANDLERS;
 
 // FIXME: Remove the USE_INTERNAL_SDK condition once we support touch events when building for iOS with
-// the public SDK. We will also need to update FeatureDefines.h.
+// the public SDK. See <https://webkit.org/b/179167>.
 ENABLE_TOUCH_EVENTS[sdk=iphone*] = $(ENABLE_TOUCH_EVENTS_ios_WITH_INTERNAL_SDK_$(USE_INTERNAL_SDK));
 ENABLE_TOUCH_EVENTS_ios_WITH_INTERNAL_SDK_YES = ENABLE_TOUCH_EVENTS;
 
index d951c18..1ac86e2 100644 (file)
@@ -1,3 +1,12 @@
+2017-11-02  Frederic Wang  <fwang@igalia.com>
+
+        Add references to bug 179167 in FIXME comments
+        https://bugs.webkit.org/show_bug.cgi?id=179168
+
+        Reviewed by Daniel Bates.
+
+        * TestWebKitAPI/Configurations/FeatureDefines.xcconfig:
+
 2017-11-01  Jeremy Jones  <jeremyj@apple.com>
 
         Implement WKFullscreenWindowController for iOS.
index 338104a..a6b93cd 100644 (file)
@@ -189,7 +189,7 @@ ENABLE_CSS_TRAILING_WORD = ENABLE_CSS_TRAILING_WORD;
 ENABLE_USER_MESSAGE_HANDLERS = ENABLE_USER_MESSAGE_HANDLERS;
 
 // FIXME: Remove the USE_INTERNAL_SDK condition once we support touch events when building for iOS with
-// the public SDK. We will also need to update FeatureDefines.h.
+// the public SDK. See <https://webkit.org/b/179167>.
 ENABLE_TOUCH_EVENTS[sdk=iphone*] = $(ENABLE_TOUCH_EVENTS_ios_WITH_INTERNAL_SDK_$(USE_INTERNAL_SDK));
 ENABLE_TOUCH_EVENTS_ios_WITH_INTERNAL_SDK_YES = ENABLE_TOUCH_EVENTS;