[Win] Warning fix.
authorpvollan@apple.com <pvollan@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 19 Aug 2016 16:41:27 +0000 (16:41 +0000)
committerpvollan@apple.com <pvollan@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 19 Aug 2016 16:41:27 +0000 (16:41 +0000)
https://bugs.webkit.org/show_bug.cgi?id=160995

Avoid setting unknown compile option on source file.

Reviewed by Anders Carlsson.

* CMakeLists.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@204633 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/JavaScriptCore/CMakeLists.txt
Source/JavaScriptCore/ChangeLog

index 83150cb..50334eb 100644 (file)
@@ -851,7 +851,11 @@ set(JavaScriptCore_SOURCES
 )
 
 # Extra flags for compile sources can go here.
-set_source_files_properties(runtime/ProxyObject.cpp PROPERTIES COMPILE_FLAGS -fno-optimize-sibling-calls)
+if (NOT MSVC)
+    set_source_files_properties(runtime/ProxyObject.cpp PROPERTIES COMPILE_FLAGS -fno-optimize-sibling-calls)
+else ()
+    # FIXME: Investigate if we need to set a similar flag on Windows.
+endif ()
 
 set(JavaScriptCore_OBJECT_LUT_SOURCES
     runtime/ArrayConstructor.cpp
index 2da895f..605cd29 100644 (file)
@@ -1,3 +1,14 @@
+2016-08-19  Per Arne Vollan  <pvollan@apple.com>
+
+        [Win] Warning fix.
+        https://bugs.webkit.org/show_bug.cgi?id=160995
+
+        Avoid setting unknown compile option on source file.
+
+        Reviewed by Anders Carlsson.
+
+        * CMakeLists.txt:
+
 2016-08-18  Mark Lam  <mark.lam@apple.com>
 
         ScopedArguments is using the wrong owner object for a write barrier.