Remove [ConvertingNullStringTo] from CloseEvent.idl
authorharaken@chromium.org <haraken@chromium.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 10 Feb 2012 09:28:05 +0000 (09:28 +0000)
committerharaken@chromium.org <haraken@chromium.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 10 Feb 2012 09:28:05 +0000 (09:28 +0000)
https://bugs.webkit.org/show_bug.cgi?id=78328

Reviewed by Adam Barth.

In CloseEvent.idl, [ConvertingNullStringTo] is a typo of [ConvertNullStringTo],
(although in bug 78108, [ConvertNullStringTo] was renamed to [TreatReturnedNullStringAs]).

Anyway, the spec says that "The reason attribute must return the value it was
initialized to. When the object is created, this attribute must be initialized to empty string."
http://dev.w3.org/html5/websockets/#event-definitions
Thus, this patch removes [ConvertingNullStringTo] from CloseEvent.idl.

Test: fast/events/constructors/close-event-constructor.html

* websockets/CloseEvent.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107382 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/WebCore/ChangeLog
Source/WebCore/websockets/CloseEvent.idl

index bc8c21a..803f3ac 100644 (file)
@@ -1,3 +1,22 @@
+2012-02-10  Kentaro Hara  <haraken@chromium.org>
+
+        Remove [ConvertingNullStringTo] from CloseEvent.idl
+        https://bugs.webkit.org/show_bug.cgi?id=78328
+
+        Reviewed by Adam Barth.
+
+        In CloseEvent.idl, [ConvertingNullStringTo] is a typo of [ConvertNullStringTo],
+        (although in bug 78108, [ConvertNullStringTo] was renamed to [TreatReturnedNullStringAs]).
+
+        Anyway, the spec says that "The reason attribute must return the value it was
+        initialized to. When the object is created, this attribute must be initialized to empty string."
+        http://dev.w3.org/html5/websockets/#event-definitions
+        Thus, this patch removes [ConvertingNullStringTo] from CloseEvent.idl.
+
+        Test: fast/events/constructors/close-event-constructor.html
+
+        * websockets/CloseEvent.idl:
+
 2012-02-10  Pavel Feldman  <pfeldman@google.com>
 
         [Qt] REGRESSION(r107242): It made 5 inspector tests crash in debug mode
index e36c949..ea75111 100644 (file)
@@ -36,7 +36,7 @@ module events {
     ] CloseEvent : Event {
         readonly attribute [InitializedByEventConstructor] boolean wasClean;
         readonly attribute [InitializedByEventConstructor] unsigned short code;
-        readonly attribute [InitializedByEventConstructor, ConvertingNullStringTo=Undefined] DOMString reason;
+        readonly attribute [InitializedByEventConstructor] DOMString reason;
     };
 
 }