[GStreamer] webaudio crash on ARM platforms
authorphiln@webkit.org <philn@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 18 May 2016 14:48:28 +0000 (14:48 +0000)
committerphiln@webkit.org <philn@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 18 May 2016 14:48:28 +0000 (14:48 +0000)
https://bugs.webkit.org/show_bug.cgi?id=157838

Reviewed by Michael Catanzaro.

* platform/audio/gstreamer/WebKitWebAudioSourceGStreamer.cpp:
(webKitWebAudioSrcConstructed): Explicitely cast the integer value
of the max-bytes property to guint64 which is the expected type of
this property. The compiler can't guess this on its own.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@201078 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/WebCore/ChangeLog
Source/WebCore/platform/audio/gstreamer/WebKitWebAudioSourceGStreamer.cpp

index a66d444..976912a 100644 (file)
@@ -1,5 +1,17 @@
 2016-05-18  Philippe Normand  <pnormand@igalia.com>
 
+        [GStreamer] webaudio crash on ARM platforms
+        https://bugs.webkit.org/show_bug.cgi?id=157838
+
+        Reviewed by Michael Catanzaro.
+
+        * platform/audio/gstreamer/WebKitWebAudioSourceGStreamer.cpp:
+        (webKitWebAudioSrcConstructed): Explicitely cast the integer value
+        of the max-bytes property to guint64 which is the expected type of
+        this property. The compiler can't guess this on its own.
+
+2016-05-18  Philippe Normand  <pnormand@igalia.com>
+
         [GStreamer] webaudio playback improvements
         https://bugs.webkit.org/show_bug.cgi?id=155228
 
index be78a86..1fde05d 100644 (file)
@@ -229,7 +229,7 @@ static void webKitWebAudioSrcConstructed(GObject* object)
         GRefPtr<GstCaps> caps = adoptGRef(gst_audio_info_to_caps(&info));
 
         // Configure the appsrc for minimal latency.
-        g_object_set(appsrc, "max-bytes", 2 * priv->bufferSize, "block", TRUE,
+        g_object_set(appsrc, "max-bytes", static_cast<guint64>(2 * priv->bufferSize), "block", TRUE,
             "blocksize", priv->bufferSize,
             "format", GST_FORMAT_TIME, "caps", caps.get(), nullptr);