2008-05-14 Julien Chaffraix <jchaffraix@webkit.org>
authorjchaffraix@webkit.org <jchaffraix@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 14 May 2008 15:50:31 +0000 (15:50 +0000)
committerjchaffraix@webkit.org <jchaffraix@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 14 May 2008 15:50:31 +0000 (15:50 +0000)
        Reviewed by Eric.

        GCC 4.3 build fix.
        Removes some compiler warnings.

        * dom/Document.h:
        (WebCore::FormElementKey::hashTableDeletedValue): GCC complained about the const keyword
        so remove it as it is only used inside FormElementKey.

        * html/HTMLSelectElement.cpp:
        (WebCore::HTMLSelectElement::menuListDefaultEventHandler): Correct coding style (removes
        a warning too).

        * loader/appcache/ApplicationCacheResource.cpp: Include stdio.h for gcc4.3 build.

        * plugins/PluginPackage.cpp:
        (WebCore::PluginPackage::PluginPackage): Changed initialization order in the constructor.
        * plugins/PluginView.cpp:
        (WebCore::PluginView::PluginView): Ditto.
        * plugins/PluginView.h:
        * xml/AccessControlList.cpp: Include stdio.h
        * xml/AccessItem.cpp: Ditto.
        * xml/AccessItemRule.cpp: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@33441 268f45cc-cd09-0410-ab3c-d52691b4dbfc

WebCore/ChangeLog
WebCore/dom/Document.h
WebCore/html/HTMLSelectElement.cpp
WebCore/loader/appcache/ApplicationCacheResource.cpp
WebCore/plugins/PluginPackage.cpp
WebCore/plugins/PluginView.cpp
WebCore/plugins/PluginView.h
WebCore/xml/AccessControlList.cpp
WebCore/xml/AccessItem.cpp
WebCore/xml/AccessItemRule.cpp

index e8eef1e..0f4bdb9 100644 (file)
@@ -1,3 +1,29 @@
+2008-05-14  Julien Chaffraix  <jchaffraix@webkit.org>
+
+        Reviewed by Eric.
+
+        GCC 4.3 build fix.
+        Removes some compiler warnings.
+
+        * dom/Document.h:
+        (WebCore::FormElementKey::hashTableDeletedValue): GCC complained about the const keyword
+        so remove it as it is only used inside FormElementKey.
+
+        * html/HTMLSelectElement.cpp:
+        (WebCore::HTMLSelectElement::menuListDefaultEventHandler): Correct coding style (removes
+        a warning too).
+
+        * loader/appcache/ApplicationCacheResource.cpp: Include stdio.h for gcc4.3 build.
+
+        * plugins/PluginPackage.cpp:
+        (WebCore::PluginPackage::PluginPackage): Changed initialization order in the constructor.
+        * plugins/PluginView.cpp:
+        (WebCore::PluginView::PluginView): Ditto.
+        * plugins/PluginView.h:
+        * xml/AccessControlList.cpp: Include stdio.h
+        * xml/AccessItem.cpp: Ditto.
+        * xml/AccessItemRule.cpp: Ditto.
+
 2008-05-14  Ariya Hidayat  <ariya.hidayat@trolltech.com>
 
         Reviewed by Simon.
index eb4549b..cb2e24f 100644 (file)
@@ -144,7 +144,7 @@ private:
     void ref() const;
     void deref() const;
 
-    static AtomicStringImpl* const hashTableDeletedValue() { return reinterpret_cast<AtomicStringImpl*>(-1); }
+    static AtomicStringImpl* hashTableDeletedValue() { return reinterpret_cast<AtomicStringImpl*>(-1); }
 
     AtomicStringImpl* m_name;
     AtomicStringImpl* m_type;
index 6a29b94..6a7cebc 100644 (file)
@@ -645,7 +645,7 @@ void HTMLSelectElement::menuListDefaultEventHandler(Event* evt)
             int size = listItems().size();
             for (listIndex += 1;
                  listIndex >= 0 && listIndex < size && (listItems()[listIndex]->disabled() || !listItems()[listIndex]->hasTagName(optionTag));
-                 ++listIndex);
+                 ++listIndex) { }
             
             if (listIndex >= 0 && listIndex < size)
                 setSelectedIndex(listToOptionIndex(listIndex));
@@ -654,7 +654,7 @@ void HTMLSelectElement::menuListDefaultEventHandler(Event* evt)
             int size = listItems().size();
             for (listIndex -= 1;
                  listIndex >= 0 && listIndex < size && (listItems()[listIndex]->disabled() || !listItems()[listIndex]->hasTagName(optionTag));
-                 --listIndex);
+                 --listIndex) { }
             
             if (listIndex >= 0 && listIndex < size)
                 setSelectedIndex(listToOptionIndex(listIndex));
index 86dd48e..ee82ff5 100644 (file)
@@ -25,6 +25,7 @@
 
 #include "config.h"
 #include "ApplicationCacheResource.h"
+#include <stdio.h>
 
 #if ENABLE(OFFLINE_WEB_APPLICATIONS)
 
index 05f14c2..e7f43a5 100644 (file)
@@ -98,12 +98,12 @@ int PluginPackage::compare(const PluginPackage& compareTo) const
 }
 
 PluginPackage::PluginPackage(const String& path, const time_t& lastModified)
-    : m_path(path)
+    : m_isLoaded(false)
+    , m_loadCount(0)
+    , m_path(path)
     , m_moduleVersion(0)
     , m_module(0)
     , m_lastModified(lastModified)
-    , m_isLoaded(false)
-    , m_loadCount(0)
     , m_freeLibraryTimer(this, &PluginPackage::freeLibraryTimerFired)
 {
     m_fileName = pathGetFileName(m_path);
index a7b1b37..5dcca3a 100644 (file)
@@ -524,7 +524,6 @@ PluginView::PluginView(Frame* parentFrame, const IntSize& size, PluginPackage* p
     , m_popPopupsStateTimer(this, &PluginView::popPopupsStateTimerFired)
     , m_paramNames(0)
     , m_paramValues(0)
-    , m_window(0)
     , m_isWindowed(true)
     , m_isTransparent(false)
     , m_isVisible(false)
@@ -538,6 +537,7 @@ PluginView::PluginView(Frame* parentFrame, const IntSize& size, PluginPackage* p
     , m_lastMessage(0)
     , m_isCallingPluginWndProc(false)
 #endif
+    , m_window(0)
     , m_loadManually(loadManually)
     , m_manualStream(0)
     , m_isJavaScriptPaused(false)
index cdd707e..97128a6 100644 (file)
@@ -176,9 +176,10 @@ namespace WebCore {
         NPError handlePostReadFile(Vector<char>& buffer, uint32 len, const char* buf);
         static void freeStringArray(char** stringArray, int length);
         void setCallingPlugin(bool) const;
+
+        Frame* m_parentFrame;
         RefPtr<PluginPackage> m_plugin;
         Element* m_element;
-        Frame* m_parentFrame;
         bool m_isStarted;
         KURL m_url;
         KURL m_baseURL;
index 2714caa..dcb0f43 100644 (file)
@@ -29,6 +29,7 @@
 #include "AccessItemRule.h"
 #include "PlatformString.h"
 #include "SecurityOrigin.h"
+#include <stdio.h>
 
 namespace WebCore {
 
index 3fb35e2..6a66514 100644 (file)
@@ -28,6 +28,7 @@
 
 #include "PlatformString.h"
 #include "SecurityOrigin.h"
+#include <stdio.h>
 
 #ifndef NDEBUG
 #include "CString.h"
index 186e9ad..13fb179 100644 (file)
@@ -28,6 +28,7 @@
 
 #include "PlatformString.h"
 #include "ParserUtilities.h"
+#include <stdio.h>
 
 namespace WebCore {