REGRESSION (r233561): MobileMail crashes when replying to an email
authorsimon.fraser@apple.com <simon.fraser@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Sat, 7 Jul 2018 17:50:54 +0000 (17:50 +0000)
committersimon.fraser@apple.com <simon.fraser@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Sat, 7 Jul 2018 17:50:54 +0000 (17:50 +0000)
https://bugs.webkit.org/show_bug.cgi?id=187436
rdar://problem/41931915

Reviewed by Alan Bujtas.

r233561 added a RELEASE_ASSERT(isMainThread()) in this function. This is fine most of the time,
until Mail spawns a WebThread for mail compose, at which point the meaning of isMainThread changes
and the RELEASE_ASSERT fires.

For now, just remove the RELEASE_ASSERT.

* UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _scheduleVisibleContentRectUpdateAfterScrollInView:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@233616 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/WebKit/ChangeLog
Source/WebKit/UIProcess/API/Cocoa/WKWebView.mm

index f985b6c..99a8915 100644 (file)
@@ -1,3 +1,20 @@
+2018-07-07  Simon Fraser  <simon.fraser@apple.com>
+
+        REGRESSION (r233561): MobileMail crashes when replying to an email
+        https://bugs.webkit.org/show_bug.cgi?id=187436
+        rdar://problem/41931915
+
+        Reviewed by Alan Bujtas.
+        
+        r233561 added a RELEASE_ASSERT(isMainThread()) in this function. This is fine most of the time,
+        until Mail spawns a WebThread for mail compose, at which point the meaning of isMainThread changes
+        and the RELEASE_ASSERT fires.
+        
+        For now, just remove the RELEASE_ASSERT.
+
+        * UIProcess/API/Cocoa/WKWebView.mm:
+        (-[WKWebView _scheduleVisibleContentRectUpdateAfterScrollInView:]):
+
 2018-07-06  Timothy Hatcher  <timothy@apple.com>
 
         Semantic colors don't update when accessibility Increase Contrast mode is enabled.
index a6803eb..16cc4fa 100644 (file)
@@ -2730,8 +2730,6 @@ static WebCore::FloatPoint constrainContentOffset(WebCore::FloatPoint contentOff
 
 - (void)_scheduleVisibleContentRectUpdateAfterScrollInView:(UIScrollView *)scrollView
 {
-    RELEASE_ASSERT(isMainThread());
-
     _visibleContentRectUpdateScheduledFromScrollViewInStableState = [self _scrollViewIsInStableState:scrollView];
 
     if (_hasScheduledVisibleRectUpdate) {