2010-01-06 Ojan Vafai <ojan@chromium.org>
authorojan@chromium.org <ojan@chromium.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 7 Jan 2010 00:30:40 +0000 (00:30 +0000)
committerojan@chromium.org <ojan@chromium.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 7 Jan 2010 00:30:40 +0000 (00:30 +0000)
        Reviewed by Eric Carlson.

        media/video-seeking.html is flaky
        https://bugs.webkit.org/show_bug.cgi?id=33273

        Removed setTimeouts from this test. It kind of looks
        like they were intentional, but I don't see how they add
        anything to this test (other than race conditions).

        * media/video-seeking-expected.txt:
        * media/video-seeking.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52881 268f45cc-cd09-0410-ab3c-d52691b4dbfc

LayoutTests/ChangeLog
LayoutTests/media/video-seeking-expected.txt
LayoutTests/media/video-seeking.html

index aa86aa8..6355a65 100644 (file)
@@ -1,5 +1,19 @@
 2010-01-06  Ojan Vafai  <ojan@chromium.org>
 
+        Reviewed by Eric Carlson.
+
+        media/video-seeking.html is flaky
+        https://bugs.webkit.org/show_bug.cgi?id=33273
+
+        Removed setTimeouts from this test. It kind of looks
+        like they were intentional, but I don't see how they add
+        anything to this test (other than race conditions).
+
+        * media/video-seeking-expected.txt:
+        * media/video-seeking.html:
+
+2010-01-06  Ojan Vafai  <ojan@chromium.org>
+
         Reviewed by Eric Seidel.
 
         fast/css/transition-color-unspecified.html and fast/dom/HTMLObjectElement/object-as-frame.html are flaky
index ebbbe32..917eb68 100644 (file)
@@ -5,7 +5,6 @@ RUN(video.currentTime = 0.5)
 
 EVENT(seeked)
 
-EXPECTED (seekedCount == '1') OK
 EXPECTED (video.seeking == 'false') OK
 EXPECTED (video.currentTime == '0.5') OK
 RUN(video.currentTime = 1)
@@ -13,7 +12,6 @@ EXPECTED (video.seeking == 'true') OK
 
 EVENT(seeked)
 
-EXPECTED (seekedCount == '2') OK
 EXPECTED (video.seeking == 'false') OK
 EXPECTED (video.currentTime == '1') OK
 RUN(video.currentTime = 1.5)
@@ -21,7 +19,6 @@ EXPECTED (video.seeking == 'true') OK
 
 EVENT(seeked)
 
-EXPECTED (seekedCount == '3') OK
 EXPECTED (video.seeking == 'false') OK
 EXPECTED (video.currentTime == '1.5') OK
 RUN(video.currentTime = 2)
index edcef6b..a8c6b5a 100644 (file)
@@ -8,39 +8,26 @@
 <script>
 
     var seekedCount = 0;
-    var counter;
 
     function seeked()
     { 
         ++seekedCount; 
         consoleWrite("");
-    }
 
-    function someTimeLater()
-    {
-        testExpected("seekedCount", counter);
         testExpected("video.seeking", false);
-        testExpected("video.currentTime", counter * 0.5);
-        run("video.currentTime = " + (counter + 1) * 0.5);
+        testExpected("video.currentTime", seekedCount * 0.5);
+        run("video.currentTime = " + (seekedCount + 1) * 0.5);
         testExpected("video.seeking", true);
 
-        if (counter == 3)
-        {
-            consoleWrite("");
-            endTest();
-        }
-
-        ++counter;
         consoleWrite("");
+
+        if (seekedCount == 3)
+            endTest();
      }
 
     function canplaythrough() 
     {
         run("video.currentTime = 0.5");
-        counter = 1;
-        setTimeout(someTimeLater, 200) 
-        setTimeout(someTimeLater, 400) 
-        setTimeout(someTimeLater, 600) 
         consoleWrite("");
     }