Cursor gets thinner on empty lines.
authorenrica@apple.com <enrica@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 1 May 2014 00:08:51 +0000 (00:08 +0000)
committerenrica@apple.com <enrica@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 1 May 2014 00:08:51 +0000 (00:08 +0000)
https://bugs.webkit.org/show_bug.cgi?id=132411
<rdar://problem/15994556>

Reviewed by Benjamin Poulain.

RenderLineBreak::localCaretRect should not define
locally the constant caretWidth, but use the one from
RenderObject.h which knows about the differences between
iOS and the other platforms.

* rendering/RenderLineBreak.cpp:
(WebCore::RenderLineBreak::localCaretRect):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@168066 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/WebCore/ChangeLog
Source/WebCore/rendering/RenderLineBreak.cpp

index b728cf1..c077d57 100644 (file)
@@ -1,3 +1,19 @@
+2014-04-30  Enrica Casucci  <enrica@apple.com>
+
+        Cursor gets thinner on empty lines.
+        https://bugs.webkit.org/show_bug.cgi?id=132411
+        <rdar://problem/15994556>
+
+        Reviewed by Benjamin Poulain.
+
+        RenderLineBreak::localCaretRect should not define
+        locally the constant caretWidth, but use the one from
+        RenderObject.h which knows about the differences between
+        iOS and the other platforms.
+
+        * rendering/RenderLineBreak.cpp:
+        (WebCore::RenderLineBreak::localCaretRect):
+
 2014-04-30  Víctor Manuel Jáquez Leal  <vjaquez@igalia.com>
 
         [GStreamer] Use GstMetaVideo
index 2a8b752..9ddb806 100644 (file)
@@ -142,7 +142,6 @@ LayoutRect RenderLineBreak::localCaretRect(InlineBox* inlineBox, int caretOffset
     if (!inlineBox)
         return LayoutRect();
 
-    static const unsigned caretWidth = 1;
     const RootInlineBox& rootBox = inlineBox->root();
     return rootBox.computeCaretRect(inlineBox->logicalLeft(), caretWidth, extraWidthToEndOfLine);
 }