Remove unused member variables found by clang's -Wunused-private-field

https://bugs.webkit.org/show_bug.cgi?id=88812

Reviewed by Anders Carlsson.

Source/WebCore:

Change a few |class|s that were used only to pin down the size of
existing classes to |struct|, so that clang doesn't warn about these
memvars.

No intended behavior change.

* Modules/geolocation/GeolocationController.cpp:
(WebCore::GeolocationController::GeolocationController):
* Modules/geolocation/GeolocationController.h:
(GeolocationController):
* Modules/webaudio/AudioContext.h:
(AudioContext):
* Modules/webaudio/AudioParamTimeline.h:
(AudioParamTimeline):
* accessibility/AccessibilityScrollbar.h:
(AccessibilityScrollbar):
* bindings/v8/ScriptScope.cpp:
(WebCore::ScriptScope::ScriptScope):
* bindings/v8/ScriptScope.h:
(ScriptScope):
* css/CSSValue.cpp:
* css/StylePropertySet.cpp:
* dom/DeviceOrientationController.cpp:
(WebCore::DeviceOrientationController::DeviceOrientationController):
* dom/DeviceOrientationController.h:
(DeviceOrientationController):
* editing/ReplaceSelectionCommand.cpp:
(ReplacementFragment):
(WebCore::ReplacementFragment::ReplacementFragment):
* editing/TextIterator.cpp:
(WebCore::SimplifiedBackwardsTextIterator::SimplifiedBackwardsTextIterator):
* editing/TextIterator.h:
(SimplifiedBackwardsTextIterator):
(BackwardsCharacterIterator):
* html/HTMLFormCollection.cpp:
(WebCore::HTMLFormCollection::HTMLFormCollection):
* html/HTMLFormCollection.h:
(HTMLFormCollection):
* html/shadow/MediaControlElements.cpp:
(WebCore::MediaControlFullscreenButtonElement::MediaControlFullscreenButtonElement):
* html/shadow/MediaControlElements.h:
(MediaControlFullscreenButtonElement):
* html/shadow/MediaControlRootElementChromium.cpp:
(WebCore::MediaControlRootElementChromium::MediaControlRootElementChromium):
* html/shadow/MediaControlRootElementChromium.h:
(MediaControlRootElementChromium):
* html/track/LoadableTextTrack.cpp:
(WebCore::LoadableTextTrack::LoadableTextTrack):
* html/track/LoadableTextTrack.h:
(LoadableTextTrack):
* inspector/CodeGeneratorInspector.py:
(Generator.go):
* inspector/InspectorCSSAgent.cpp:
(WebCore::InspectorCSSAgent::InspectorCSSAgent):
* inspector/InspectorCSSAgent.h:
(InspectorCSSAgent):
* inspector/InspectorDOMDebuggerAgent.cpp:
(WebCore::InspectorDOMDebuggerAgent::InspectorDOMDebuggerAgent):
* inspector/InspectorDOMDebuggerAgent.h:
(InspectorDOMDebuggerAgent):
* inspector/InspectorMemoryAgent.cpp:
(WebCore::InspectorMemoryAgent::InspectorMemoryAgent):
* inspector/InspectorMemoryAgent.h:
(InspectorMemoryAgent):
* notifications/NotificationController.cpp:
(WebCore::NotificationController::NotificationController):
* notifications/NotificationController.h:
(NotificationController):
* page/animation/CompositeAnimation.h:
(WebCore::CompositeAnimation::CompositeAnimation):
(CompositeAnimation):
* platform/Length.cpp:
* platform/audio/ReverbConvolver.cpp:
(WebCore::ReverbConvolver::ReverbConvolver):
* platform/audio/ReverbConvolver.h:
(ReverbConvolver):
* platform/audio/ReverbConvolverStage.cpp:
(WebCore::ReverbConvolverStage::ReverbConvolverStage):
* platform/audio/ReverbConvolverStage.h:
(ReverbConvolverStage):
* platform/graphics/TextRun.cpp:
(ExpectedTextRunSize):
* platform/graphics/chromium/cc/CCThreadProxy.h:
(CCThreadProxy):
* platform/graphics/filters/FECustomFilter.cpp:
(WebCore::FECustomFilter::FECustomFilter):
* platform/graphics/filters/FECustomFilter.h:
(FECustomFilter):
* platform/image-decoders/jpeg/JPEGImageDecoder.cpp:
(JPEGImageReader):
* platform/leveldb/LevelDBTransaction.cpp:
(WebCore::LevelDBTransaction::TreeIterator::next):
* platform/text/TextCodecICU.cpp:
(WebCore::TextCodecICU::TextCodecICU):
* platform/text/TextCodecICU.h:
(TextCodecICU):
* rendering/InlineBox.cpp:
* rendering/InlineFlowBox.cpp:
* rendering/RenderText.cpp:
* rendering/style/KeyframeList.h:
(WebCore::KeyframeList::KeyframeList):
(KeyframeList):
* rendering/svg/RenderSVGTextPath.cpp:
(WebCore::RenderSVGTextPath::RenderSVGTextPath):
* rendering/svg/RenderSVGTextPath.h:
* rendering/svg/SVGInlineTextBox.cpp:
* svg/SVGPathByteStreamSource.cpp:
* svg/SVGPathByteStreamSource.h:
* svg/SVGPathTraversalStateBuilder.cpp:
(WebCore::SVGPathTraversalStateBuilder::SVGPathTraversalStateBuilder):
* svg/SVGPathTraversalStateBuilder.h:
(SVGPathTraversalStateBuilder):
* xml/XSLStyleSheet.h:

Source/WebKit/chromium:

* src/AudioDestinationChromium.cpp:
(WebCore::AudioDestinationChromium::AudioDestinationChromium):
* src/AudioDestinationChromium.h:
(AudioDestinationChromium):
* src/InspectorFrontendClientImpl.cpp:
(WebKit::InspectorFrontendClientImpl::InspectorFrontendClientImpl):
* src/InspectorFrontendClientImpl.h:
(InspectorFrontendClientImpl):
* src/WebFrameImpl.cpp:
(ChromePluginPrintContext):
* src/WebInputEvent.cpp:
* src/WorkerAsyncFileSystemChromium.cpp:
(WebCore::WorkerAsyncFileSystemChromium::createWorkerFileSystemCallbacksBridge):
* src/WorkerAsyncFileWriterChromium.cpp:
(WebCore::WorkerAsyncFileWriterChromium::WorkerAsyncFileWriterChromium):
* src/WorkerAsyncFileWriterChromium.h:
(WorkerAsyncFileWriterChromium):
* tests/CCLayerTreeHostTest.cpp:
(WTF::CCLayerTreeHostTestSetVisible::CCLayerTreeHostTestSetVisible):
(CCLayerTreeHostTestSetVisible):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@120044 268f45cc-cd09-0410-ab3c-d52691b4dbfc

diff --git a/Source/WebCore/ChangeLog b/Source/WebCore/ChangeLog
index 0c4635c..bef26c6 100644 (file)
--- a/Source/WebCore/ChangeLog
+++ b/Source/WebCore/ChangeLog
@@ -1,3 +1,124 @@
+2012-06-11  Nico Weber  <thakis@chromium.org>
+
+        Remove unused member variables found by clang's -Wunused-private-field
+        https://bugs.webkit.org/show_bug.cgi?id=88812
+
+        Reviewed by Anders Carlsson.
+
+        Change a few |class|s that were used only to pin down the size of
+        existing classes to |struct|, so that clang doesn't warn about these
+        memvars.
+
+        No intended behavior change.
+
+        * Modules/geolocation/GeolocationController.cpp:
+        (WebCore::GeolocationController::GeolocationController):
+        * Modules/geolocation/GeolocationController.h:
+        (GeolocationController):
+        * Modules/webaudio/AudioContext.h:
+        (AudioContext):
+        * Modules/webaudio/AudioParamTimeline.h:
+        (AudioParamTimeline):
+        * accessibility/AccessibilityScrollbar.h:
+        (AccessibilityScrollbar):
+        * bindings/v8/ScriptScope.cpp:
+        (WebCore::ScriptScope::ScriptScope):
+        * bindings/v8/ScriptScope.h:
+        (ScriptScope):
+        * css/CSSValue.cpp:
+        * css/StylePropertySet.cpp:
+        * dom/DeviceOrientationController.cpp:
+        (WebCore::DeviceOrientationController::DeviceOrientationController):
+        * dom/DeviceOrientationController.h:
+        (DeviceOrientationController):
+        * editing/ReplaceSelectionCommand.cpp:
+        (ReplacementFragment):
+        (WebCore::ReplacementFragment::ReplacementFragment):
+        * editing/TextIterator.cpp:
+        (WebCore::SimplifiedBackwardsTextIterator::SimplifiedBackwardsTextIterator):
+        * editing/TextIterator.h:
+        (SimplifiedBackwardsTextIterator):
+        (BackwardsCharacterIterator):
+        * html/HTMLFormCollection.cpp:
+        (WebCore::HTMLFormCollection::HTMLFormCollection):
+        * html/HTMLFormCollection.h:
+        (HTMLFormCollection):
+        * html/shadow/MediaControlElements.cpp:
+        (WebCore::MediaControlFullscreenButtonElement::MediaControlFullscreenButtonElement):
+        * html/shadow/MediaControlElements.h:
+        (MediaControlFullscreenButtonElement):
+        * html/shadow/MediaControlRootElementChromium.cpp:
+        (WebCore::MediaControlRootElementChromium::MediaControlRootElementChromium):
+        * html/shadow/MediaControlRootElementChromium.h:
+        (MediaControlRootElementChromium):
+        * html/track/LoadableTextTrack.cpp:
+        (WebCore::LoadableTextTrack::LoadableTextTrack):
+        * html/track/LoadableTextTrack.h:
+        (LoadableTextTrack):
+        * inspector/CodeGeneratorInspector.py:
+        (Generator.go):
+        * inspector/InspectorCSSAgent.cpp:
+        (WebCore::InspectorCSSAgent::InspectorCSSAgent):
+        * inspector/InspectorCSSAgent.h:
+        (InspectorCSSAgent):
+        * inspector/InspectorDOMDebuggerAgent.cpp:
+        (WebCore::InspectorDOMDebuggerAgent::InspectorDOMDebuggerAgent):
+        * inspector/InspectorDOMDebuggerAgent.h:
+        (InspectorDOMDebuggerAgent):
+        * inspector/InspectorMemoryAgent.cpp:
+        (WebCore::InspectorMemoryAgent::InspectorMemoryAgent):
+        * inspector/InspectorMemoryAgent.h:
+        (InspectorMemoryAgent):
+        * notifications/NotificationController.cpp:
+        (WebCore::NotificationController::NotificationController):
+        * notifications/NotificationController.h:
+        (NotificationController):
+        * page/animation/CompositeAnimation.h:
+        (WebCore::CompositeAnimation::CompositeAnimation):
+        (CompositeAnimation):
+        * platform/Length.cpp:
+        * platform/audio/ReverbConvolver.cpp:
+        (WebCore::ReverbConvolver::ReverbConvolver):
+        * platform/audio/ReverbConvolver.h:
+        (ReverbConvolver):
+        * platform/audio/ReverbConvolverStage.cpp:
+        (WebCore::ReverbConvolverStage::ReverbConvolverStage):
+        * platform/audio/ReverbConvolverStage.h:
+        (ReverbConvolverStage):
+        * platform/graphics/TextRun.cpp:
+        (ExpectedTextRunSize):
+        * platform/graphics/chromium/cc/CCThreadProxy.h:
+        (CCThreadProxy):
+        * platform/graphics/filters/FECustomFilter.cpp:
+        (WebCore::FECustomFilter::FECustomFilter):
+        * platform/graphics/filters/FECustomFilter.h:
+        (FECustomFilter):
+        * platform/image-decoders/jpeg/JPEGImageDecoder.cpp:
+        (JPEGImageReader):
+        * platform/leveldb/LevelDBTransaction.cpp:
+        (WebCore::LevelDBTransaction::TreeIterator::next):
+        * platform/text/TextCodecICU.cpp:
+        (WebCore::TextCodecICU::TextCodecICU):
+        * platform/text/TextCodecICU.h:
+        (TextCodecICU):
+        * rendering/InlineBox.cpp:
+        * rendering/InlineFlowBox.cpp:
+        * rendering/RenderText.cpp:
+        * rendering/style/KeyframeList.h:
+        (WebCore::KeyframeList::KeyframeList):
+        (KeyframeList):
+        * rendering/svg/RenderSVGTextPath.cpp:
+        (WebCore::RenderSVGTextPath::RenderSVGTextPath):
+        * rendering/svg/RenderSVGTextPath.h:
+        * rendering/svg/SVGInlineTextBox.cpp:
+        * svg/SVGPathByteStreamSource.cpp:
+        * svg/SVGPathByteStreamSource.h:
+        * svg/SVGPathTraversalStateBuilder.cpp:
+        (WebCore::SVGPathTraversalStateBuilder::SVGPathTraversalStateBuilder):
+        * svg/SVGPathTraversalStateBuilder.h:
+        (SVGPathTraversalStateBuilder):
+        * xml/XSLStyleSheet.h:
+
 2012-06-11  Kinuko Yasuda  <kinuko@chromium.org>
 
         XHR returns size==0 Blob

diff --git a/Source/WebCore/Modules/geolocation/GeolocationController.cpp b/Source/WebCore/Modules/geolocation/GeolocationController.cpp
index d64e8b6..e1ace93 100644 (file)
--- a/Source/WebCore/Modules/geolocation/GeolocationController.cpp
+++ b/Source/WebCore/Modules/geolocation/GeolocationController.cpp
@@ -33,9 +33,8 @@
 
 namespace WebCore {
 
-GeolocationController::GeolocationController(Page* page, GeolocationClient* client)
-    : m_page(page)
-    , m_client(client)
+GeolocationController::GeolocationController(Page*, GeolocationClient* client)
+    : m_client(client)
 {
 }
 

diff --git a/Source/WebCore/Modules/geolocation/GeolocationController.h b/Source/WebCore/Modules/geolocation/GeolocationController.h
index b5f4f61..fc3b513 100644 (file)
--- a/Source/WebCore/Modules/geolocation/GeolocationController.h
+++ b/Source/WebCore/Modules/geolocation/GeolocationController.h
@@ -67,7 +67,6 @@ public:
 private:
     GeolocationController(Page*, GeolocationClient*);
 
-    Page* m_page;
     GeolocationClient* m_client;
 
     RefPtr<GeolocationPosition> m_lastPosition;

diff --git a/Source/WebCore/Modules/webaudio/AudioContext.h b/Source/WebCore/Modules/webaudio/AudioContext.h
index 52fea12..66806a6 100644 (file)
--- a/Source/WebCore/Modules/webaudio/AudioContext.h
+++ b/Source/WebCore/Modules/webaudio/AudioContext.h
@@ -256,7 +256,6 @@ private:
     
     bool m_isInitialized;
     bool m_isAudioThreadFinished;
-    bool m_isAudioThreadShutdown;
 
     Document* m_document;
 

diff --git a/Source/WebCore/Modules/webaudio/AudioParamTimeline.h b/Source/WebCore/Modules/webaudio/AudioParamTimeline.h
index 22ea890..abc147d 100644 (file)
--- a/Source/WebCore/Modules/webaudio/AudioParamTimeline.h
+++ b/Source/WebCore/Modules/webaudio/AudioParamTimeline.h
@@ -41,8 +41,6 @@ namespace WebCore {
 class AudioParamTimeline {
 public:
     AudioParamTimeline()
-        : m_currentEventIndex(0)
-        , m_value(0)
     {
     }
 
@@ -108,8 +106,6 @@ private:
     float valuesForTimeRangeImpl(float startTime, float endTime, float defaultValue, float* values, unsigned numberOfValues, float sampleRate, float controlRate);
 
     Vector<ParamEvent> m_events;
-    unsigned m_currentEventIndex;
-    float m_value;
 
     Mutex m_eventsLock;
 };

diff --git a/Source/WebCore/accessibility/AccessibilityScrollbar.h b/Source/WebCore/accessibility/AccessibilityScrollbar.h
index 3d48c2d..fc44fd2 100644 (file)
--- a/Source/WebCore/accessibility/AccessibilityScrollbar.h
+++ b/Source/WebCore/accessibility/AccessibilityScrollbar.h
@@ -61,7 +61,6 @@ private:
     virtual float valueForRange() const;
 
     RefPtr<Scrollbar> m_scrollbar;
-    AccessibilityOrientation m_orientation;
 };
 
 } // namespace WebCore

diff --git a/Source/WebCore/bindings/v8/ScriptScope.cpp b/Source/WebCore/bindings/v8/ScriptScope.cpp
index a1b13a1..a32968d 100644 (file)
--- a/Source/WebCore/bindings/v8/ScriptScope.cpp
+++ b/Source/WebCore/bindings/v8/ScriptScope.cpp
@@ -40,7 +40,6 @@ namespace WebCore {
 ScriptScope::ScriptScope(ScriptState* scriptState, bool reportExceptions)
     : m_context(scriptState->context())
     , m_scope(m_context)
-    , m_scriptState(scriptState)
 {
     m_exceptionCatcher.SetVerbose(reportExceptions);
     ASSERT(!m_context.IsEmpty());

diff --git a/Source/WebCore/bindings/v8/ScriptScope.h b/Source/WebCore/bindings/v8/ScriptScope.h
index 3f9a332..ed2cf2f 100644 (file)
--- a/Source/WebCore/bindings/v8/ScriptScope.h
+++ b/Source/WebCore/bindings/v8/ScriptScope.h
@@ -48,7 +48,6 @@ namespace WebCore {
         v8::Local<v8::Context> m_context;
         v8::Context::Scope m_scope;
         v8::TryCatch m_exceptionCatcher;
-        ScriptState* m_scriptState;
     };
 
 }

diff --git a/Source/WebCore/css/CSSValue.cpp b/Source/WebCore/css/CSSValue.cpp
index f568cc5..93f4d90 100644 (file)
--- a/Source/WebCore/css/CSSValue.cpp
+++ b/Source/WebCore/css/CSSValue.cpp
@@ -58,7 +58,7 @@
 
 namespace WebCore {
 
-class SameSizeAsCSSValue : public RefCounted<SameSizeAsCSSValue> {
+struct SameSizeAsCSSValue : public RefCounted<SameSizeAsCSSValue> {
     uint32_t bitfields;
 };
 

diff --git a/Source/WebCore/css/StylePropertySet.cpp b/Source/WebCore/css/StylePropertySet.cpp
index cbe92c4..43ac2a5 100644 (file)
--- a/Source/WebCore/css/StylePropertySet.cpp
+++ b/Source/WebCore/css/StylePropertySet.cpp
@@ -1066,7 +1066,7 @@ unsigned StylePropertySet::averageSizeInBytes()
 }
 
 // See the function above if you need to update this.
-class SameSizeAsStylePropertySet : public RefCounted<SameSizeAsStylePropertySet> {
+struct SameSizeAsStylePropertySet : public RefCounted<SameSizeAsStylePropertySet> {
     unsigned bitfield;
     void* properties;
 };

diff --git a/Source/WebCore/dom/DeviceOrientationController.cpp b/Source/WebCore/dom/DeviceOrientationController.cpp
index eae6fb5..7f18c24 100644 (file)
--- a/Source/WebCore/dom/DeviceOrientationController.cpp
+++ b/Source/WebCore/dom/DeviceOrientationController.cpp
@@ -32,9 +32,8 @@
 
 namespace WebCore {
 
-DeviceOrientationController::DeviceOrientationController(Page* page, DeviceOrientationClient* client)
-    : m_page(page)
-    , m_client(client)
+DeviceOrientationController::DeviceOrientationController(Page*, DeviceOrientationClient* client)
+    : m_client(client)
     , m_timer(this, &DeviceOrientationController::timerFired)
 {
     ASSERT(m_client);

diff --git a/Source/WebCore/dom/DeviceOrientationController.h b/Source/WebCore/dom/DeviceOrientationController.h
index 707cd5c..cfdabfe 100644 (file)
--- a/Source/WebCore/dom/DeviceOrientationController.h
+++ b/Source/WebCore/dom/DeviceOrientationController.h
@@ -65,7 +65,6 @@ private:
 
     void timerFired(Timer<DeviceOrientationController>*);
 
-    Page* m_page;
     DeviceOrientationClient* m_client;
     typedef HashCountedSet<RefPtr<DOMWindow> > ListenersCountedSet;
     ListenersCountedSet m_listeners;

diff --git a/Source/WebCore/editing/ReplaceSelectionCommand.cpp b/Source/WebCore/editing/ReplaceSelectionCommand.cpp
index 642898d..bc16190 100644 (file)
--- a/Source/WebCore/editing/ReplaceSelectionCommand.cpp
+++ b/Source/WebCore/editing/ReplaceSelectionCommand.cpp
@@ -93,7 +93,6 @@ private:
 
     RefPtr<Document> m_document;
     RefPtr<DocumentFragment> m_fragment;
-    bool m_matchStyle;
     bool m_hasInterchangeNewlineAtStart;
     bool m_hasInterchangeNewlineAtEnd;
 };
@@ -135,10 +134,9 @@ static Position positionAvoidingPrecedingNodes(Position pos)
     return pos;
 }
 
-ReplacementFragment::ReplacementFragment(Document* document, DocumentFragment* fragment, bool matchStyle, const VisibleSelection& selection)
+ReplacementFragment::ReplacementFragment(Document* document, DocumentFragment* fragment, bool, const VisibleSelection& selection)
     : m_document(document),
       m_fragment(fragment),
-      m_matchStyle(matchStyle), 
       m_hasInterchangeNewlineAtStart(false), 
       m_hasInterchangeNewlineAtEnd(false)
 {

diff --git a/Source/WebCore/editing/TextIterator.cpp b/Source/WebCore/editing/TextIterator.cpp
index b3b84a7..b17ae6b 100644 (file)
--- a/Source/WebCore/editing/TextIterator.cpp
+++ b/Source/WebCore/editing/TextIterator.cpp
@@ -1066,8 +1066,7 @@ Node* TextIterator::node() const
 // --------
 
 SimplifiedBackwardsTextIterator::SimplifiedBackwardsTextIterator()
-    : m_behavior(TextIteratorDefaultBehavior)
-    , m_node(0)
+    : m_node(0)
     , m_offset(0)
     , m_handledNode(false)
     , m_handledChildren(false)
@@ -1091,8 +1090,7 @@ SimplifiedBackwardsTextIterator::SimplifiedBackwardsTextIterator()
 }
 
 SimplifiedBackwardsTextIterator::SimplifiedBackwardsTextIterator(const Range* r, TextIteratorBehavior behavior)
-    : m_behavior(behavior)
-    , m_node(0)
+    : m_node(0)
     , m_offset(0)
     , m_handledNode(false)
     , m_handledChildren(false)
@@ -1113,7 +1111,7 @@ SimplifiedBackwardsTextIterator::SimplifiedBackwardsTextIterator(const Range* r,
     , m_stopsOnFormControls(behavior & TextIteratorStopsOnFormControls)
     , m_shouldStop(false)
 {
-    ASSERT(m_behavior == TextIteratorDefaultBehavior || m_behavior == TextIteratorStopsOnFormControls);
+    ASSERT(behavior == TextIteratorDefaultBehavior || behavior == TextIteratorStopsOnFormControls);
 
     if (!r)
         return;

diff --git a/Source/WebCore/editing/TextIterator.h b/Source/WebCore/editing/TextIterator.h
index 3a77ee8..ec531aa 100644 (file)
--- a/Source/WebCore/editing/TextIterator.h
+++ b/Source/WebCore/editing/TextIterator.h
@@ -217,7 +217,6 @@ private:
     void emitCharacter(UChar, Node*, int startOffset, int endOffset);
     bool advanceRespectingRange(Node*);
 
-    TextIteratorBehavior m_behavior;
     // Current position, not necessarily of the text being returned, but position
     // as we walk through the DOM tree.
     Node* m_node;
@@ -299,7 +298,6 @@ public:
     PassRefPtr<Range> range() const;
 
 private:
-    TextIteratorBehavior m_behavior;
     int m_offset;
     int m_runOffset;
     bool m_atBreak;

diff --git a/Source/WebCore/html/HTMLFormCollection.cpp b/Source/WebCore/html/HTMLFormCollection.cpp
index cb3cca9..d9b6a5d 100644 (file)
--- a/Source/WebCore/html/HTMLFormCollection.cpp
+++ b/Source/WebCore/html/HTMLFormCollection.cpp
@@ -38,7 +38,6 @@ using namespace HTMLNames;
 
 HTMLFormCollection::HTMLFormCollection(HTMLElement* base)
     : HTMLCollection(base, FormControls)
-    , currentPos(0)
 {
 }
 

diff --git a/Source/WebCore/html/HTMLFormCollection.h b/Source/WebCore/html/HTMLFormCollection.h
index 32fb1eb..315ea68 100644 (file)
--- a/Source/WebCore/html/HTMLFormCollection.h
+++ b/Source/WebCore/html/HTMLFormCollection.h
@@ -57,8 +57,6 @@ private:
     const Vector<FormAssociatedElement*>& formControlElements() const;
     const Vector<HTMLImageElement*>& formImageElements() const;
     unsigned numberOfFormControlElements() const;
-
-    mutable int currentPos;
 };
 
 } //namespace

diff --git a/Source/WebCore/html/shadow/MediaControlElements.cpp b/Source/WebCore/html/shadow/MediaControlElements.cpp
index 212048a..c0dafc9 100644 (file)
--- a/Source/WebCore/html/shadow/MediaControlElements.cpp
+++ b/Source/WebCore/html/shadow/MediaControlElements.cpp
@@ -973,9 +973,8 @@ const AtomicString& MediaControlFullscreenVolumeSliderElement::shadowPseudoId()
 
 // ----------------------------
 
-inline MediaControlFullscreenButtonElement::MediaControlFullscreenButtonElement(Document* document, MediaControls* controls)
+inline MediaControlFullscreenButtonElement::MediaControlFullscreenButtonElement(Document* document, MediaControls*)
     : MediaControlInputElement(document, MediaEnterFullscreenButton)
-    , m_controls(controls)
 {
 }
 

diff --git a/Source/WebCore/html/shadow/MediaControlElements.h b/Source/WebCore/html/shadow/MediaControlElements.h
index 03570f7..5bca5a9 100644 (file)
--- a/Source/WebCore/html/shadow/MediaControlElements.h
+++ b/Source/WebCore/html/shadow/MediaControlElements.h
@@ -410,8 +410,6 @@ private:
     MediaControlFullscreenButtonElement(Document*, MediaControls*);
 
     virtual const AtomicString& shadowPseudoId() const;
-
-    MediaControls* m_controls;
 };
 
 // ----------------------------

diff --git a/Source/WebCore/html/shadow/MediaControlRootElementChromium.cpp b/Source/WebCore/html/shadow/MediaControlRootElementChromium.cpp
index 140a184..cb8a3a8 100644 (file)
--- a/Source/WebCore/html/shadow/MediaControlRootElementChromium.cpp
+++ b/Source/WebCore/html/shadow/MediaControlRootElementChromium.cpp
@@ -80,7 +80,6 @@ MediaControlRootElementChromium::MediaControlRootElementChromium(Document* docum
     , m_enclosure(0)
 #if ENABLE(VIDEO_TRACK)
     , m_textDisplayContainer(0)
-    , m_textTrackDisplay(0)
 #endif
     , m_opaque(true)
     , m_isMouseOverControls(false)

diff --git a/Source/WebCore/html/shadow/MediaControlRootElementChromium.h b/Source/WebCore/html/shadow/MediaControlRootElementChromium.h
index 249c6a0..6ad32dd 100644 (file)
--- a/Source/WebCore/html/shadow/MediaControlRootElementChromium.h
+++ b/Source/WebCore/html/shadow/MediaControlRootElementChromium.h
@@ -147,7 +147,6 @@ private:
     MediaControlChromiumEnclosureElement* m_enclosure;
 #if ENABLE(VIDEO_TRACK)
     MediaControlTextTrackContainerElement* m_textDisplayContainer;
-    MediaControlTextTrackDisplayElement* m_textTrackDisplay;
 #endif
 
     bool m_opaque;

diff --git a/Source/WebCore/html/track/LoadableTextTrack.cpp b/Source/WebCore/html/track/LoadableTextTrack.cpp
index e03ff4b..d95e8cc 100644 (file)
--- a/Source/WebCore/html/track/LoadableTextTrack.cpp
+++ b/Source/WebCore/html/track/LoadableTextTrack.cpp
@@ -37,11 +37,10 @@
 
 namespace WebCore {
 
-LoadableTextTrack::LoadableTextTrack(HTMLTrackElement* track, const String& kind, const String& label, const String& language, bool isDefault)
+LoadableTextTrack::LoadableTextTrack(HTMLTrackElement* track, const String& kind, const String& label, const String& language, bool)
     : TextTrack(track->document(), track, kind, label, language, TrackElement)
     , m_trackElement(track)
     , m_loadTimer(this, &LoadableTextTrack::loadTimerFired)
-    , m_isDefault(isDefault)
 {
 }
 

diff --git a/Source/WebCore/html/track/LoadableTextTrack.h b/Source/WebCore/html/track/LoadableTextTrack.h
index ad6f6ad..33183db 100644 (file)
--- a/Source/WebCore/html/track/LoadableTextTrack.h
+++ b/Source/WebCore/html/track/LoadableTextTrack.h
@@ -76,7 +76,6 @@ private:
     Timer<LoadableTextTrack> m_loadTimer;
     OwnPtr<TextTrackLoader> m_loader;
     KURL m_url;
-    bool m_isDefault;
 };
 } // namespace WebCore
 

diff --git a/Source/WebCore/inspector/CodeGeneratorInspector.py b/Source/WebCore/inspector/CodeGeneratorInspector.py
index 345313d..3674406 100755 (executable)
--- a/Source/WebCore/inspector/CodeGeneratorInspector.py
+++ b/Source/WebCore/inspector/CodeGeneratorInspector.py
@@ -1834,7 +1834,6 @@ public:
 
 $domainClassList
 private:
-    InspectorFrontendChannel* m_inspectorFrontendChannel;
 ${fieldDeclarations}};
 
 #endif // ENABLE(INSPECTOR)
@@ -2190,8 +2189,7 @@ bool InspectorBackendDispatcher::getCommandName(const String& message, String* r
 namespace WebCore {
 
 InspectorFrontend::InspectorFrontend(InspectorFrontendChannel* inspectorFrontendChannel)
-    : m_inspectorFrontendChannel(inspectorFrontendChannel)
-$constructorInit{
+    : $constructorInit{
 }
 
 $methods
@@ -2596,7 +2594,9 @@ class Generator:
                     Generator.process_event(json_event, domain_name, frontend_method_declaration_lines)
 
             Generator.frontend_class_field_lines.append("    %s m_%s;\n" % (domain_name, domain_name_lower))
-            Generator.frontend_constructor_init_list.append("    , m_%s(inspectorFrontendChannel)\n" % domain_name_lower)
+            if Generator.frontend_constructor_init_list:
+                Generator.frontend_constructor_init_list.append("    , ")
+            Generator.frontend_constructor_init_list.append("m_%s(inspectorFrontendChannel)\n" % domain_name_lower)
             Generator.frontend_domain_class_lines.append(Templates.frontend_domain_class.substitute(None,
                 domainClassName=domain_name,
                 domainFieldName=domain_name_lower,

diff --git a/Source/WebCore/inspector/InspectorCSSAgent.cpp b/Source/WebCore/inspector/InspectorCSSAgent.cpp
index 6fa88c4..917027f 100644 (file)
--- a/Source/WebCore/inspector/InspectorCSSAgent.cpp
+++ b/Source/WebCore/inspector/InspectorCSSAgent.cpp
@@ -463,8 +463,6 @@ InspectorCSSAgent::InspectorCSSAgent(InstrumentingAgents* instrumentingAgents, I
     , m_domAgent(domAgent)
     , m_lastPseudoState(0)
     , m_lastStyleSheetId(1)
-    , m_lastRuleId(1)
-    , m_lastStyleId(1)
 {
     m_domAgent->setDOMListener(this);
     m_instrumentingAgents->setInspectorCSSAgent(this);

diff --git a/Source/WebCore/inspector/InspectorCSSAgent.h b/Source/WebCore/inspector/InspectorCSSAgent.h
index 890391a..d6390f7 100644 (file)
--- a/Source/WebCore/inspector/InspectorCSSAgent.h
+++ b/Source/WebCore/inspector/InspectorCSSAgent.h
@@ -170,8 +170,6 @@ private:
     unsigned m_lastPseudoState;
 
     int m_lastStyleSheetId;
-    int m_lastRuleId;
-    int m_lastStyleId;
 
     OwnPtr<SelectorProfile> m_currentSelectorProfile;
 };

diff --git a/Source/WebCore/inspector/InspectorDOMDebuggerAgent.cpp b/Source/WebCore/inspector/InspectorDOMDebuggerAgent.cpp
index b07a71f..8032295 100644 (file)
--- a/Source/WebCore/inspector/InspectorDOMDebuggerAgent.cpp
+++ b/Source/WebCore/inspector/InspectorDOMDebuggerAgent.cpp
@@ -75,11 +75,10 @@ PassOwnPtr<InspectorDOMDebuggerAgent> InspectorDOMDebuggerAgent::create(Instrume
     return adoptPtr(new InspectorDOMDebuggerAgent(instrumentingAgents, inspectorState, domAgent, debuggerAgent, inspectorAgent));
 }
 
-InspectorDOMDebuggerAgent::InspectorDOMDebuggerAgent(InstrumentingAgents* instrumentingAgents, InspectorState* inspectorState, InspectorDOMAgent* domAgent, InspectorDebuggerAgent* debuggerAgent, InspectorAgent* inspectorAgent)
+InspectorDOMDebuggerAgent::InspectorDOMDebuggerAgent(InstrumentingAgents* instrumentingAgents, InspectorState* inspectorState, InspectorDOMAgent* domAgent, InspectorDebuggerAgent* debuggerAgent, InspectorAgent*)
     : InspectorBaseAgent<InspectorDOMDebuggerAgent>("DOMDebugger", instrumentingAgents, inspectorState)
     , m_domAgent(domAgent)
     , m_debuggerAgent(debuggerAgent)
-    , m_inspectorAgent(inspectorAgent)
 {
     m_debuggerAgent->setListener(this);
 }

diff --git a/Source/WebCore/inspector/InspectorDOMDebuggerAgent.h b/Source/WebCore/inspector/InspectorDOMDebuggerAgent.h
index 1bd06ab..7b111f6 100644 (file)
--- a/Source/WebCore/inspector/InspectorDOMDebuggerAgent.h
+++ b/Source/WebCore/inspector/InspectorDOMDebuggerAgent.h
@@ -103,7 +103,6 @@ private:
 
     InspectorDOMAgent* m_domAgent;
     InspectorDebuggerAgent* m_debuggerAgent;
-    InspectorAgent* m_inspectorAgent;
     HashMap<Node*, uint32_t> m_domBreakpoints;
 };
 

diff --git a/Source/WebCore/inspector/InspectorMemoryAgent.cpp b/Source/WebCore/inspector/InspectorMemoryAgent.cpp
index 6095641..e5651e3 100644 (file)
--- a/Source/WebCore/inspector/InspectorMemoryAgent.cpp
+++ b/Source/WebCore/inspector/InspectorMemoryAgent.cpp
@@ -406,10 +406,9 @@ void InspectorMemoryAgent::getProcessMemoryDistribution(ErrorString*, RefPtr<Ins
     processMemory->setChildren(children);
 }
 
-InspectorMemoryAgent::InspectorMemoryAgent(InstrumentingAgents* instrumentingAgents, InspectorState* state, Page* page, InspectorDOMAgent* domAgent)
+InspectorMemoryAgent::InspectorMemoryAgent(InstrumentingAgents* instrumentingAgents, InspectorState* state, Page* page, InspectorDOMAgent*)
     : InspectorBaseAgent<InspectorMemoryAgent>("Memory", instrumentingAgents, state)
     , m_page(page)
-    , m_domAgent(domAgent)
 {
 }
 

diff --git a/Source/WebCore/inspector/InspectorMemoryAgent.h b/Source/WebCore/inspector/InspectorMemoryAgent.h
index 8a24b4c..91f3fbe 100644 (file)
--- a/Source/WebCore/inspector/InspectorMemoryAgent.h
+++ b/Source/WebCore/inspector/InspectorMemoryAgent.h
@@ -65,7 +65,6 @@ public:
 private:
     InspectorMemoryAgent(InstrumentingAgents*, InspectorState*, Page*, InspectorDOMAgent* domAgent);
     Page* m_page;
-    InspectorDOMAgent* m_domAgent;
 };
 
 } // namespace WebCore

diff --git a/Source/WebCore/notifications/NotificationController.cpp b/Source/WebCore/notifications/NotificationController.cpp
index e8efb03..eeafb6d 100644 (file)
--- a/Source/WebCore/notifications/NotificationController.cpp
+++ b/Source/WebCore/notifications/NotificationController.cpp
@@ -34,8 +34,7 @@
 namespace WebCore {
 
 NotificationController::NotificationController(Page* page, NotificationClient* client)
-    : m_page(page)
-    , m_client(client)
+    : m_client(client)
 {
 }
 

diff --git a/Source/WebCore/notifications/NotificationController.h b/Source/WebCore/notifications/NotificationController.h
index a155268..f84bcef 100644 (file)
--- a/Source/WebCore/notifications/NotificationController.h
+++ b/Source/WebCore/notifications/NotificationController.h
@@ -51,7 +51,6 @@ public:
 private:
     NotificationController(Page*, NotificationClient*);
 
-    Page* m_page;
     NotificationClient* m_client;
 };
 

diff --git a/Source/WebCore/page/animation/CompositeAnimation.h b/Source/WebCore/page/animation/CompositeAnimation.h
index 2475aea..91a35f0 100644 (file)
--- a/Source/WebCore/page/animation/CompositeAnimation.h
+++ b/Source/WebCore/page/animation/CompositeAnimation.h
@@ -86,7 +86,6 @@ public:
 private:
     CompositeAnimation(AnimationControllerPrivate* animationController)
         : m_animationController(animationController)
-        , m_numStyleAvailableWaiters(0)
         , m_suspended(false)
     {
     }
@@ -101,7 +100,6 @@ private:
     CSSPropertyTransitionsMap m_transitions;
     AnimationNameMap m_keyframeAnimations;
     Vector<AtomicStringImpl*> m_keyframeAnimationOrderMap;
-    unsigned m_numStyleAvailableWaiters;
     bool m_suspended;
 };
 

diff --git a/Source/WebCore/platform/Length.cpp b/Source/WebCore/platform/Length.cpp
index 3811d4d..086f221 100644 (file)
--- a/Source/WebCore/platform/Length.cpp
+++ b/Source/WebCore/platform/Length.cpp
@@ -237,7 +237,7 @@ bool Length::isCalculatedEqual(const Length& o) const
     return isCalculated() && (calculationValue() == o.calculationValue() || *calculationValue() == *o.calculationValue());
 }
 
-class SameSizeAsLength {
+struct SameSizeAsLength {
     int32_t value;
     int32_t metaData;
 };

diff --git a/Source/WebCore/platform/audio/ReverbConvolver.cpp b/Source/WebCore/platform/audio/ReverbConvolver.cpp
index ad9cfcf..a5f07e0 100644 (file)
--- a/Source/WebCore/platform/audio/ReverbConvolver.cpp
+++ b/Source/WebCore/platform/audio/ReverbConvolver.cpp
@@ -63,7 +63,6 @@ ReverbConvolver::ReverbConvolver(AudioChannel* impulseResponse, size_t renderSli
     : m_impulseResponseLength(impulseResponse->length())
     , m_accumulationBuffer(impulseResponse->length() + renderSliceSize)
     , m_inputBuffer(InputBufferSize)
-    , m_renderSliceSize(renderSliceSize)
     , m_minFFTSize(MinFFTSize) // First stage will have this size - successive stages will double in size each time
     , m_maxFFTSize(maxFFTSize) // until we hit m_maxFFTSize
     , m_useBackgroundThreads(useBackgroundThreads)

diff --git a/Source/WebCore/platform/audio/ReverbConvolver.h b/Source/WebCore/platform/audio/ReverbConvolver.h
index a7d6619..de3522c 100644 (file)
--- a/Source/WebCore/platform/audio/ReverbConvolver.h
+++ b/Source/WebCore/platform/audio/ReverbConvolver.h
@@ -74,10 +74,6 @@ private:
     // One or more background threads read from this input buffer which is fed from the realtime thread.
     ReverbInputBuffer m_inputBuffer;
 
-    // We're given a rendering hint, so the FFTs can be optimized to not all occur at the same time
-    // (very bad when rendering on a real-time thread).
-    size_t m_renderSliceSize;
-
     // First stage will be of size m_minFFTSize.  Each next stage will be twice as big until we hit m_maxFFTSize.
     size_t m_minFFTSize;
     size_t m_maxFFTSize;

diff --git a/Source/WebCore/platform/audio/ReverbConvolverStage.cpp b/Source/WebCore/platform/audio/ReverbConvolverStage.cpp
index e8c4d3f..41f76ba 100644 (file)
--- a/Source/WebCore/platform/audio/ReverbConvolverStage.cpp
+++ b/Source/WebCore/platform/audio/ReverbConvolverStage.cpp
@@ -43,12 +43,11 @@ namespace WebCore {
 
 using namespace VectorMath;
 
-ReverbConvolverStage::ReverbConvolverStage(const float* impulseResponse, size_t responseLength, size_t reverbTotalLatency, size_t stageOffset, size_t stageLength,
+ReverbConvolverStage::ReverbConvolverStage(const float* impulseResponse, size_t, size_t reverbTotalLatency, size_t stageOffset, size_t stageLength,
                                            size_t fftSize, size_t renderPhase, size_t renderSliceSize, ReverbAccumulationBuffer* accumulationBuffer, bool directMode)
     : m_accumulationBuffer(accumulationBuffer)
     , m_accumulationReadIndex(0)
     , m_inputReadIndex(0)
-    , m_impulseResponseLength(responseLength)
     , m_directMode(directMode)
 {
     ASSERT(impulseResponse);

diff --git a/Source/WebCore/platform/audio/ReverbConvolverStage.h b/Source/WebCore/platform/audio/ReverbConvolverStage.h
index 9ce8dca..a8a9f47 100644 (file)
--- a/Source/WebCore/platform/audio/ReverbConvolverStage.h
+++ b/Source/WebCore/platform/audio/ReverbConvolverStage.h
@@ -75,8 +75,6 @@ private:
 
     AudioFloatArray m_temporaryBuffer;
 
-    size_t m_impulseResponseLength;
-
     bool m_directMode;
     OwnPtr<AudioFloatArray> m_directKernel;
     OwnPtr<DirectConvolver> m_directConvolver;

diff --git a/Source/WebCore/platform/graphics/TextRun.cpp b/Source/WebCore/platform/graphics/TextRun.cpp
index aa39e9f..7d58efd 100644 (file)
--- a/Source/WebCore/platform/graphics/TextRun.cpp
+++ b/Source/WebCore/platform/graphics/TextRun.cpp
@@ -28,8 +28,8 @@
 
 namespace WebCore {
 
-class ExpectedTextRunSize {
-    const void* pointer;;
+struct ExpectedTextRunSize {
+    const void* pointer;
     int integers[2];
     float float1;
 #if ENABLE(SVG)

diff --git a/Source/WebCore/platform/graphics/chromium/cc/CCThreadProxy.h b/Source/WebCore/platform/graphics/chromium/cc/CCThreadProxy.h
index 24db92e..2c2beb0 100644 (file)
--- a/Source/WebCore/platform/graphics/chromium/cc/CCThreadProxy.h
+++ b/Source/WebCore/platform/graphics/chromium/cc/CCThreadProxy.h
@@ -178,9 +178,6 @@ private:
     // Set when the main thread is waiting on a readback.
     ReadbackRequest* m_readbackRequestOnImplThread;
 
-    // Set when the main thread is waiting on a finishAllRendering call.
-    CCCompletionEvent* m_finishAllRenderingCompletionEventOnImplThread;
-
     // Set when the main thread is waiting on a commit to complete.
     CCCompletionEvent* m_commitCompletionEventOnImplThread;
 

diff --git a/Source/WebCore/platform/graphics/filters/FECustomFilter.cpp b/Source/WebCore/platform/graphics/filters/FECustomFilter.cpp
index 010521c..fffc695 100644 (file)
--- a/Source/WebCore/platform/graphics/filters/FECustomFilter.cpp
+++ b/Source/WebCore/platform/graphics/filters/FECustomFilter.cpp
@@ -84,7 +84,6 @@ FECustomFilter::FECustomFilter(Filter* filter, HostWindow* hostWindow, PassRefPt
     , m_parameters(parameters)
     , m_meshRows(meshRows)
     , m_meshColumns(meshColumns)
-    , m_meshBoxType(meshBoxType)
     , m_meshType(meshType)
 {
 }

diff --git a/Source/WebCore/platform/graphics/filters/FECustomFilter.h b/Source/WebCore/platform/graphics/filters/FECustomFilter.h
index f56dac0..4102ed2 100644 (file)
--- a/Source/WebCore/platform/graphics/filters/FECustomFilter.h
+++ b/Source/WebCore/platform/graphics/filters/FECustomFilter.h
@@ -97,7 +97,6 @@ private:
 
     unsigned m_meshRows;
     unsigned m_meshColumns;
-    CustomFilterOperation::MeshBoxType m_meshBoxType;
     CustomFilterOperation::MeshType m_meshType;
 };
 

diff --git a/Source/WebCore/platform/image-decoders/jpeg/JPEGImageDecoder.cpp b/Source/WebCore/platform/image-decoders/jpeg/JPEGImageDecoder.cpp
index d33f6f2..46a28ba 100644 (file)
--- a/Source/WebCore/platform/image-decoders/jpeg/JPEGImageDecoder.cpp
+++ b/Source/WebCore/platform/image-decoders/jpeg/JPEGImageDecoder.cpp
@@ -408,7 +408,6 @@ private:
     unsigned m_bufferLength;
     int m_bytesToSkip;
     bool m_decodingSizeOnly;
-    bool m_initialized;
 
     jpeg_decompress_struct m_info;
     decoder_error_mgr m_err;

diff --git a/Source/WebCore/platform/leveldb/LevelDBTransaction.cpp b/Source/WebCore/platform/leveldb/LevelDBTransaction.cpp
index 5bb1b45..862a5fb 100644 (file)
--- a/Source/WebCore/platform/leveldb/LevelDBTransaction.cpp
+++ b/Source/WebCore/platform/leveldb/LevelDBTransaction.cpp
@@ -192,6 +192,7 @@ void LevelDBTransaction::TreeIterator::next()
     ++m_iterator;
     if (isValid()) {
         ASSERT(m_transaction->m_comparator->compare((*m_iterator)->key, m_key) > 0);
+        (void)m_transaction;
         m_key = (*m_iterator)->key;
     }
 }

diff --git a/Source/WebCore/platform/text/TextCodecICU.cpp b/Source/WebCore/platform/text/TextCodecICU.cpp
index f0f2898..8285284 100644 (file)
--- a/Source/WebCore/platform/text/TextCodecICU.cpp
+++ b/Source/WebCore/platform/text/TextCodecICU.cpp
@@ -199,7 +199,6 @@ void TextCodecICU::registerCodecs(TextCodecRegistrar registrar)
 
 TextCodecICU::TextCodecICU(const TextEncoding& encoding)
     : m_encoding(encoding)
-    , m_numBufferedBytes(0)
     , m_converterICU(0)
     , m_needsGBKFallbacks(false)
 {

diff --git a/Source/WebCore/platform/text/TextCodecICU.h b/Source/WebCore/platform/text/TextCodecICU.h
index f02c36d..28e3da5 100644 (file)
--- a/Source/WebCore/platform/text/TextCodecICU.h
+++ b/Source/WebCore/platform/text/TextCodecICU.h
@@ -58,8 +58,6 @@ namespace WebCore {
             const char* sourceLimit, int32_t* offsets, bool flush, UErrorCode& err);
 
         TextEncoding m_encoding;
-        unsigned m_numBufferedBytes;
-        unsigned char m_bufferedBytes[16]; // bigger than any single multi-byte character
         mutable UConverter* m_converterICU;
         mutable bool m_needsGBKFallbacks;
     };

diff --git a/Source/WebCore/rendering/InlineBox.cpp b/Source/WebCore/rendering/InlineBox.cpp
index 957e0f0..6f328c1 100644 (file)
--- a/Source/WebCore/rendering/InlineBox.cpp
+++ b/Source/WebCore/rendering/InlineBox.cpp
@@ -37,7 +37,7 @@ using namespace std;
 
 namespace WebCore {
 
-class SameSizeAsInlineBox {
+struct SameSizeAsInlineBox {
     virtual ~SameSizeAsInlineBox() { }
     void* a[4];
     FloatPoint b;

diff --git a/Source/WebCore/rendering/InlineFlowBox.cpp b/Source/WebCore/rendering/InlineFlowBox.cpp
index 58c97dd..a659514 100644 (file)
--- a/Source/WebCore/rendering/InlineFlowBox.cpp
+++ b/Source/WebCore/rendering/InlineFlowBox.cpp
@@ -45,7 +45,7 @@ using namespace std;
 
 namespace WebCore {
 
-class SameSizeAsInlineFlowBox : public InlineBox {
+struct SameSizeAsInlineFlowBox : public InlineBox {
     void* pointers[5];
     uint32_t bitfields : 24;
 };

diff --git a/Source/WebCore/rendering/RenderText.cpp b/Source/WebCore/rendering/RenderText.cpp
index 16c1ea1..f3e5704 100644 (file)
--- a/Source/WebCore/rendering/RenderText.cpp
+++ b/Source/WebCore/rendering/RenderText.cpp
@@ -53,7 +53,7 @@ using namespace Unicode;
 
 namespace WebCore {
 
-class SameSizeAsRenderText : public RenderObject {
+struct SameSizeAsRenderText : public RenderObject {
     uint32_t bitfields : 16;
     float widths[4];
     String text;

diff --git a/Source/WebCore/rendering/style/KeyframeList.h b/Source/WebCore/rendering/style/KeyframeList.h
index fb352f9..5101b06 100644 (file)
--- a/Source/WebCore/rendering/style/KeyframeList.h
+++ b/Source/WebCore/rendering/style/KeyframeList.h
@@ -62,9 +62,8 @@ private:
 
 class KeyframeList {
 public:
-    KeyframeList(RenderObject* renderer, const AtomicString& animationName)
+    KeyframeList(RenderObject*, const AtomicString& animationName)
         : m_animationName(animationName)
-        , m_renderer(renderer)
     {
         insert(KeyframeValue(0, 0));
         insert(KeyframeValue(1, 0));
@@ -92,7 +91,6 @@ private:
     AtomicString m_animationName;
     Vector<KeyframeValue> m_keyframes; // Kept sorted by key.
     HashSet<CSSPropertyID> m_properties; // The properties being animated.
-    RenderObject* m_renderer;
 };
 
 } // namespace WebCore

diff --git a/Source/WebCore/rendering/svg/RenderSVGTextPath.cpp b/Source/WebCore/rendering/svg/RenderSVGTextPath.cpp
index c30fad5..3ed63dd 100644 (file)
--- a/Source/WebCore/rendering/svg/RenderSVGTextPath.cpp
+++ b/Source/WebCore/rendering/svg/RenderSVGTextPath.cpp
@@ -36,7 +36,6 @@ namespace WebCore {
 
 RenderSVGTextPath::RenderSVGTextPath(Node* n)
     : RenderSVGInline(n)
-    , m_startOffset(0)
     , m_exactAlignment(true)
     , m_stretchMethod(false)
 {

diff --git a/Source/WebCore/rendering/svg/RenderSVGTextPath.h b/Source/WebCore/rendering/svg/RenderSVGTextPath.h
index f1871b0..be156ba 100644 (file)
--- a/Source/WebCore/rendering/svg/RenderSVGTextPath.h
+++ b/Source/WebCore/rendering/svg/RenderSVGTextPath.h
@@ -40,8 +40,6 @@ public:
 private:
     virtual const char* renderName() const { return "RenderSVGTextPath"; }
 
-    float m_startOffset;
-
     bool m_exactAlignment : 1;
     bool m_stretchMethod : 1;
 

diff --git a/Source/WebCore/rendering/svg/SVGInlineTextBox.cpp b/Source/WebCore/rendering/svg/SVGInlineTextBox.cpp
index 24e9a82..9302aef 100644 (file)
--- a/Source/WebCore/rendering/svg/SVGInlineTextBox.cpp
+++ b/Source/WebCore/rendering/svg/SVGInlineTextBox.cpp
@@ -44,7 +44,7 @@ using namespace std;
 
 namespace WebCore {
 
-class ExpectedSVGInlineTextBoxSize : public InlineTextBox {
+struct ExpectedSVGInlineTextBoxSize : public InlineTextBox {
     float float1;
     uint32_t bitfields : 5;
     void* pointer;

diff --git a/Source/WebCore/svg/SVGPathByteStreamSource.cpp b/Source/WebCore/svg/SVGPathByteStreamSource.cpp
index d0475f3..35f03fa 100644 (file)
--- a/Source/WebCore/svg/SVGPathByteStreamSource.cpp
+++ b/Source/WebCore/svg/SVGPathByteStreamSource.cpp
@@ -25,7 +25,6 @@
 namespace WebCore {
 
 SVGPathByteStreamSource::SVGPathByteStreamSource(SVGPathByteStream* stream)
-    : m_stream(stream)
 {
     ASSERT(stream);
     m_streamCurrent = stream->begin();

diff --git a/Source/WebCore/svg/SVGPathByteStreamSource.h b/Source/WebCore/svg/SVGPathByteStreamSource.h
index 6895c73..26373eb 100644 (file)
--- a/Source/WebCore/svg/SVGPathByteStreamSource.h
+++ b/Source/WebCore/svg/SVGPathByteStreamSource.h
@@ -93,7 +93,6 @@ private:
         return FloatPoint(x, y);
     }
 
-    SVGPathByteStream* m_stream;
     SVGPathByteStream::DataIterator m_streamCurrent;
     SVGPathByteStream::DataIterator m_streamEnd;
 };

diff --git a/Source/WebCore/svg/SVGPathTraversalStateBuilder.cpp b/Source/WebCore/svg/SVGPathTraversalStateBuilder.cpp
index 2bd98e5..3527341 100644 (file)
--- a/Source/WebCore/svg/SVGPathTraversalStateBuilder.cpp
+++ b/Source/WebCore/svg/SVGPathTraversalStateBuilder.cpp
@@ -29,7 +29,6 @@ namespace WebCore {
 
 SVGPathTraversalStateBuilder::SVGPathTraversalStateBuilder()
     : m_traversalState(0)
-    , m_desiredLength(0)
 {
 }
 

diff --git a/Source/WebCore/svg/SVGPathTraversalStateBuilder.h b/Source/WebCore/svg/SVGPathTraversalStateBuilder.h
index b262ddf..32b5991 100644 (file)
--- a/Source/WebCore/svg/SVGPathTraversalStateBuilder.h
+++ b/Source/WebCore/svg/SVGPathTraversalStateBuilder.h
@@ -59,7 +59,6 @@ private:
     virtual void arcTo(float, float, float, bool, bool, const FloatPoint&, PathCoordinateMode) { ASSERT_NOT_REACHED(); }
 
     PathTraversalState* m_traversalState;
-    float m_desiredLength;
 };
 
 } // namespace WebCore

diff --git a/Source/WebCore/xml/XSLStyleSheet.h b/Source/WebCore/xml/XSLStyleSheet.h
index e6bd9bc..b60213e 100644 (file)
--- a/Source/WebCore/xml/XSLStyleSheet.h
+++ b/Source/WebCore/xml/XSLStyleSheet.h
@@ -119,7 +119,6 @@ private:
 
     Vector<OwnPtr<XSLImportRule> > m_children;
 
-    Document* m_ownerDocument;
     bool m_embedded;
     bool m_processed;
 

diff --git a/Source/WebKit/chromium/ChangeLog b/Source/WebKit/chromium/ChangeLog
index 1e52896..9ab3cf1 100644 (file)
--- a/Source/WebKit/chromium/ChangeLog
+++ b/Source/WebKit/chromium/ChangeLog
@@ -1,3 +1,31 @@
+2012-06-11  Nico Weber  <thakis@chromium.org>
+
+        Remove unused member variables found by clang's -Wunused-private-field
+        https://bugs.webkit.org/show_bug.cgi?id=88812
+
+        Reviewed by Anders Carlsson.
+
+        * src/AudioDestinationChromium.cpp:
+        (WebCore::AudioDestinationChromium::AudioDestinationChromium):
+        * src/AudioDestinationChromium.h:
+        (AudioDestinationChromium):
+        * src/InspectorFrontendClientImpl.cpp:
+        (WebKit::InspectorFrontendClientImpl::InspectorFrontendClientImpl):
+        * src/InspectorFrontendClientImpl.h:
+        (InspectorFrontendClientImpl):
+        * src/WebFrameImpl.cpp:
+        (ChromePluginPrintContext):
+        * src/WebInputEvent.cpp:
+        * src/WorkerAsyncFileSystemChromium.cpp:
+        (WebCore::WorkerAsyncFileSystemChromium::createWorkerFileSystemCallbacksBridge):
+        * src/WorkerAsyncFileWriterChromium.cpp:
+        (WebCore::WorkerAsyncFileWriterChromium::WorkerAsyncFileWriterChromium):
+        * src/WorkerAsyncFileWriterChromium.h:
+        (WorkerAsyncFileWriterChromium):
+        * tests/CCLayerTreeHostTest.cpp:
+        (WTF::CCLayerTreeHostTestSetVisible::CCLayerTreeHostTestSetVisible):
+        (CCLayerTreeHostTestSetVisible):
+
 2012-06-11  Vincent Scheib  <scheib@chromium.org>
 
         Consolidate Pointer Lock runtime enabled flags to just one.

diff --git a/Source/WebKit/chromium/src/AudioDestinationChromium.cpp b/Source/WebKit/chromium/src/AudioDestinationChromium.cpp
index 44558de..cadb2e3 100644 (file)
--- a/Source/WebKit/chromium/src/AudioDestinationChromium.cpp
+++ b/Source/WebKit/chromium/src/AudioDestinationChromium.cpp
@@ -58,8 +58,7 @@ PassOwnPtr<AudioDestination> AudioDestination::create(AudioSourceProvider& provi
 }
 
 AudioDestinationChromium::AudioDestinationChromium(AudioSourceProvider& provider, float sampleRate)
-    : m_provider(provider)
-    , m_renderBus(numberOfChannels, renderBufferSize, false)
+    : m_renderBus(numberOfChannels, renderBufferSize, false)
     , m_sampleRate(sampleRate)
     , m_isPlaying(false)
 {

diff --git a/Source/WebKit/chromium/src/AudioDestinationChromium.h b/Source/WebKit/chromium/src/AudioDestinationChromium.h
index dfe5ebd..be4cc4b 100644 (file)
--- a/Source/WebKit/chromium/src/AudioDestinationChromium.h
+++ b/Source/WebKit/chromium/src/AudioDestinationChromium.h
@@ -58,7 +58,6 @@ public:
     virtual void render(const WebKit::WebVector<float*>& audioData, size_t numberOfFrames);
 
 private:
-    AudioSourceProvider& m_provider;
     AudioBus m_renderBus;
     float m_sampleRate;
     bool m_isPlaying;

diff --git a/Source/WebKit/chromium/src/InspectorFrontendClientImpl.cpp b/Source/WebKit/chromium/src/InspectorFrontendClientImpl.cpp
index af90bad..e3f7f13 100644 (file)
--- a/Source/WebKit/chromium/src/InspectorFrontendClientImpl.cpp
+++ b/Source/WebKit/chromium/src/InspectorFrontendClientImpl.cpp
@@ -50,7 +50,6 @@ namespace WebKit {
 InspectorFrontendClientImpl::InspectorFrontendClientImpl(Page* frontendPage, WebDevToolsFrontendClient* client, WebDevToolsFrontendImpl* frontend)
     : m_frontendPage(frontendPage)
     , m_client(client)
-    , m_frontend(frontend)
 {
 }
 

diff --git a/Source/WebKit/chromium/src/InspectorFrontendClientImpl.h b/Source/WebKit/chromium/src/InspectorFrontendClientImpl.h
index 1aedc1f..4f66e1b 100644 (file)
--- a/Source/WebKit/chromium/src/InspectorFrontendClientImpl.h
+++ b/Source/WebKit/chromium/src/InspectorFrontendClientImpl.h
@@ -79,7 +79,6 @@ public:
 private:
     WebCore::Page* m_frontendPage;
     WebDevToolsFrontendClient* m_client;
-    WebDevToolsFrontendImpl* m_frontend;
     RefPtr<WebCore::InspectorFrontendHost> m_frontendHost;
 };
 

diff --git a/Source/WebKit/chromium/src/WebFrameImpl.cpp b/Source/WebKit/chromium/src/WebFrameImpl.cpp
index 78b0ce2..c78e3af 100644 (file)
--- a/Source/WebKit/chromium/src/WebFrameImpl.cpp
+++ b/Source/WebKit/chromium/src/WebFrameImpl.cpp
@@ -506,7 +506,6 @@ private:
     WebPluginContainerImpl* m_plugin;
     int m_pageCount;
     WebPrintParams m_printParams;
-    WebPrintScalingOption m_printScalingOption;
 
 };
 

diff --git a/Source/WebKit/chromium/src/WebInputEvent.cpp b/Source/WebKit/chromium/src/WebInputEvent.cpp
index e61b4ac..c0690f8 100644 (file)
--- a/Source/WebKit/chromium/src/WebInputEvent.cpp
+++ b/Source/WebKit/chromium/src/WebInputEvent.cpp
@@ -43,27 +43,27 @@ using namespace WebCore;
 
 namespace WebKit {
 
-class SameSizeAsWebInputEvent {
+struct SameSizeAsWebInputEvent {
     int inputData[5];
 };
 
-class SameSizeAsWebKeyboardEvent : public SameSizeAsWebInputEvent {
+struct SameSizeAsWebKeyboardEvent : public SameSizeAsWebInputEvent {
     int keyboardData[12];
 };
 
-class SameSizeAsWebMouseEvent : public SameSizeAsWebInputEvent {
+struct SameSizeAsWebMouseEvent : public SameSizeAsWebInputEvent {
     int mouseData[10];
 };
 
-class SameSizeAsWebMouseWheelEvent : public SameSizeAsWebMouseEvent {
+struct SameSizeAsWebMouseWheelEvent : public SameSizeAsWebMouseEvent {
     int mousewheelData[8];
 };
 
-class SameSizeAsWebGestureEvent : public SameSizeAsWebInputEvent {
+struct SameSizeAsWebGestureEvent : public SameSizeAsWebInputEvent {
     int gestureData[6];
 };
 
-class SameSizeAsWebTouchEvent : public SameSizeAsWebInputEvent {
+struct SameSizeAsWebTouchEvent : public SameSizeAsWebInputEvent {
     WebTouchPoint touchPoints[3 * WebTouchEvent::touchesLengthCap];
     int touchData[3];
 };

diff --git a/Source/WebKit/chromium/src/WorkerAsyncFileSystemChromium.cpp b/Source/WebKit/chromium/src/WorkerAsyncFileSystemChromium.cpp
index 09021ef..7a387c7 100644 (file)
--- a/Source/WebKit/chromium/src/WorkerAsyncFileSystemChromium.cpp
+++ b/Source/WebKit/chromium/src/WorkerAsyncFileSystemChromium.cpp
@@ -191,6 +191,7 @@ void WorkerAsyncFileSystemChromium::createSnapshotFileAndReadMetadata(const KURL
 PassRefPtr<WorkerFileSystemCallbacksBridge> WorkerAsyncFileSystemChromium::createWorkerFileSystemCallbacksBridge(PassOwnPtr<AsyncFileSystemCallbacks> callbacks)
 {
     ASSERT(m_synchronousType == AsynchronousFileSystem || !m_bridgeForCurrentOperation);
+    (void)m_synchronousType;
 
     m_modeForCurrentOperation = fileSystemOperationsMode;
     m_modeForCurrentOperation.append(String::number(m_workerContext->thread()->runLoop().createUniqueId()));

diff --git a/Source/WebKit/chromium/src/WorkerAsyncFileWriterChromium.cpp b/Source/WebKit/chromium/src/WorkerAsyncFileWriterChromium.cpp
index 6d62098..e127cfc 100644 (file)
--- a/Source/WebKit/chromium/src/WorkerAsyncFileWriterChromium.cpp
+++ b/Source/WebKit/chromium/src/WorkerAsyncFileWriterChromium.cpp
@@ -51,9 +51,8 @@ using namespace WebKit;
 namespace WebCore {
 
 WorkerAsyncFileWriterChromium::WorkerAsyncFileWriterChromium(WebFileSystem* webFileSystem, const WebURL& path, WorkerContext* workerContext, AsyncFileWriterClient* client, WriterType type)
-    : m_type(type)
 {
-    ASSERT(m_type == Asynchronous); // Synchronous is not implemented yet.
+    ASSERT(type == Asynchronous); // Synchronous is not implemented yet.
 
     WorkerLoaderProxy* proxy = &workerContext->thread()->workerLoaderProxy();
     m_bridge = WorkerFileWriterCallbacksBridge::create(path, proxy, workerContext, client);

diff --git a/Source/WebKit/chromium/src/WorkerAsyncFileWriterChromium.h b/Source/WebKit/chromium/src/WorkerAsyncFileWriterChromium.h
index 86e6517..2408a02 100644 (file)
--- a/Source/WebKit/chromium/src/WorkerAsyncFileWriterChromium.h
+++ b/Source/WebKit/chromium/src/WorkerAsyncFileWriterChromium.h
@@ -79,7 +79,6 @@ private:
 
     WorkerAsyncFileWriterChromium(WebKit::WebFileSystem*, const WebKit::WebURL& path, WorkerContext*, AsyncFileWriterClient*, WriterType);
     RefPtr<WebKit::WorkerFileWriterCallbacksBridge> m_bridge;
-    WriterType m_type;
 };
 
 } // namespace

diff --git a/Source/WebKit/chromium/tests/CCLayerTreeHostTest.cpp b/Source/WebKit/chromium/tests/CCLayerTreeHostTest.cpp
index b034370..aacd9a5 100644 (file)
--- a/Source/WebKit/chromium/tests/CCLayerTreeHostTest.cpp
+++ b/Source/WebKit/chromium/tests/CCLayerTreeHostTest.cpp
@@ -1111,8 +1111,7 @@ class CCLayerTreeHostTestSetVisible : public CCLayerTreeHostTest {
 public:
 
     CCLayerTreeHostTestSetVisible()
-        : m_numCommits(0)
-        , m_numDraws(0)
+        : m_numDraws(0)
     {
     }
 
@@ -1136,7 +1135,6 @@ public:
     }
 
 private:
-    int m_numCommits;
     int m_numDraws;
 };