Web Inspector: [CodeMirror] token highlight still has some problems
authorcommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 13 Mar 2013 12:48:28 +0000 (12:48 +0000)
committercommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 13 Mar 2013 12:48:28 +0000 (12:48 +0000)
https://bugs.webkit.org/show_bug.cgi?id=112173

Patch by Andrey Lushnikov <lushnikov@chromium.org> on 2013-03-13
Reviewed by Vsevolod Vlasov.

Use pseudo elements with borders to draw token highlight.

No new tests.

* inspector/front-end/cm/cmdevtools.css:
(.cm-token-highlight):
(.cm-token-highlight:before):
(.cm-line-with-selection .cm-column-with-selection:before):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@145707 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/WebCore/ChangeLog
Source/WebCore/inspector/front-end/cm/cmdevtools.css

index 6d243d8..b05014a 100644 (file)
@@ -1,3 +1,19 @@
+2013-03-13  Andrey Lushnikov  <lushnikov@chromium.org>
+
+        Web Inspector: [CodeMirror] token highlight still has some problems
+        https://bugs.webkit.org/show_bug.cgi?id=112173
+
+        Reviewed by Vsevolod Vlasov.
+
+        Use pseudo elements with borders to draw token highlight.
+
+        No new tests.
+
+        * inspector/front-end/cm/cmdevtools.css:
+        (.cm-token-highlight):
+        (.cm-token-highlight:before):
+        (.cm-line-with-selection .cm-column-with-selection:before):
+
 2013-03-13  Alberto Garcia  <agarcia@igalia.com>
 
         [BlackBerry] SimpleFontData: remove duplicate code
index 7c92498..5850f6a 100644 (file)
 }
 
 .cm-token-highlight {
+    position: relative;
+}
+
+.cm-token-highlight:before {
+    position: absolute;
     border: 1px solid gray;
     border-radius: 3px;
-    margin: -1px;
+    top: 0px;
+    bottom: 0px;
+    left: 0px;
+    right: 0px;
+    content: "";
 }
 
-.cm-line-with-selection .cm-column-with-selection {
+.cm-line-with-selection .cm-column-with-selection:before {
     border: 0px;
-    margin: 0px;
 }
 
 .cm-s-web-inspector-js span.cm-keyword {color: rgb(170, 13, 145);}