Add missing call to completionHandler
authorkrollin@apple.com <krollin@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 13 Feb 2020 23:53:37 +0000 (23:53 +0000)
committerkrollin@apple.com <krollin@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 13 Feb 2020 23:53:37 +0000 (23:53 +0000)
https://bugs.webkit.org/show_bug.cgi?id=207720
<rdar://problem/59436915>

Reviewed by Chris Dumez.

Bug 179641 (r225702) updated
SubresourceLoader::willSendRequestInternal with a return call without
first calling the completionHandler. Address this by adding the call
to the completionHandler.

No new tests -- it's not possible to control execution into the
affected code path.

* loader/SubresourceLoader.cpp:
(WebCore::SubresourceLoader::willSendRequestInternal):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@256569 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/WebCore/ChangeLog
Source/WebCore/loader/SubresourceLoader.cpp

index 8a8e27f..bd215c2 100644 (file)
@@ -1,3 +1,22 @@
+2020-02-13  Keith Rollin  <krollin@apple.com>
+
+        Add missing call to completionHandler
+        https://bugs.webkit.org/show_bug.cgi?id=207720
+        <rdar://problem/59436915>
+
+        Reviewed by Chris Dumez.
+
+        Bug 179641 (r225702) updated
+        SubresourceLoader::willSendRequestInternal with a return call without
+        first calling the completionHandler. Address this by adding the call
+        to the completionHandler.
+
+        No new tests -- it's not possible to control execution into the
+        affected code path.
+
+        * loader/SubresourceLoader.cpp:
+        (WebCore::SubresourceLoader::willSendRequestInternal):
+
 2020-02-13  Tim Horton  <timothy_horton@apple.com>
 
         iOS: Autoscrolling is too fast and way too aggressive
index b7482aa..2b810c6 100644 (file)
@@ -239,7 +239,7 @@ void SubresourceLoader::willSendRequestInternal(ResourceRequest&& newRequest, co
             m_resource->responseReceived(opaqueRedirectedResponse);
             if (reachedTerminalState()) {
                 RELEASE_LOG_IF_ALLOWED("willSendRequestinternal: reached terminal state (frame = %p, frameLoader = %p, resourceID = %lu)", frame(), frameLoader(), identifier());
-                return;
+                return completionHandler(WTFMove(newRequest));
             }
 
             RELEASE_LOG_IF_ALLOWED("willSendRequestinternal: resource load completed (frame = %p, frameLoader = %p, resourceID = %lu)", frame(), frameLoader(), identifier());