webkitpy: --dedicated-simulators does not boot the correct number of simulators
authorjbedard@apple.com <jbedard@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 8 Mar 2018 00:07:26 +0000 (00:07 +0000)
committerjbedard@apple.com <jbedard@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 8 Mar 2018 00:07:26 +0000 (00:07 +0000)
https://bugs.webkit.org/show_bug.cgi?id=183409
<rdar://problem/38224631>

Reviewed by Aakash Jain.

* Scripts/webkitpy/port/ios_simulator.py:
(IOSSimulatorPort.default_child_processes): When not using dedicated simulators,
we should use the number of booted simulators as our default child processes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@229379 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Tools/ChangeLog
Tools/Scripts/webkitpy/port/ios_simulator.py

index 8165afd..9807727 100644 (file)
@@ -1,3 +1,15 @@
+2018-03-07  Jonathan Bedard  <jbedard@apple.com>
+
+        webkitpy: --dedicated-simulators does not boot the correct number of simulators
+        https://bugs.webkit.org/show_bug.cgi?id=183409
+        <rdar://problem/38224631>
+
+        Reviewed by Aakash Jain.
+
+        * Scripts/webkitpy/port/ios_simulator.py:
+        (IOSSimulatorPort.default_child_processes): When not using dedicated simulators,
+        we should use the number of booted simulators as our default child processes.
+
 2018-03-07  Alejandro G. Castro  <alex@igalia.com>
 
         Make NetworkRTCResolver port agnostic
index 9a1686b..4e2dd14 100644 (file)
@@ -73,7 +73,7 @@ class IOSSimulatorPort(IOSPort):
             return device.platform_device.device_type in DeviceType(software_variant='iOS',
                                                                     software_version=self.ios_version())
 
-        if self.get_option('dedicated_simulators', False):
+        if not self.get_option('dedicated_simulators', False):
             num_booted_sims = len(SimulatedDeviceManager.device_by_filter(booted_ios_devices_filter, host=self.host))
             if num_booted_sims:
                 return num_booted_sims