Unreviewed, test gardening
authorjiewen_tan@apple.com <jiewen_tan@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 28 Nov 2018 02:16:25 +0000 (02:16 +0000)
committerjiewen_tan@apple.com <jiewen_tan@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Wed, 28 Nov 2018 02:16:25 +0000 (02:16 +0000)
Add a time out parameter to the following test cases such that WebAuthN requests will timeout
themselves instead of letting the wpt wrapper or test runner kill them.

* http/wpt/webauthn/public-key-credential-create-success-hid.https.html:
* http/wpt/webauthn/public-key-credential-get-success-hid.https.html:
* platform/mac-wk2/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@238598 268f45cc-cd09-0410-ab3c-d52691b4dbfc

LayoutTests/ChangeLog
LayoutTests/http/wpt/webauthn/public-key-credential-create-success-hid.https.html
LayoutTests/http/wpt/webauthn/public-key-credential-get-success-hid.https.html
LayoutTests/platform/mac-wk2/TestExpectations

index 0376665..e1622f5 100644 (file)
@@ -1,3 +1,14 @@
+2018-11-27  Jiewen Tan  <jiewen_tan@apple.com>
+
+        Unreviewed, test gardening
+
+        Add a time out parameter to the following test cases such that WebAuthN requests will timeout
+        themselves instead of letting the wpt wrapper or test runner kill them.
+
+        * http/wpt/webauthn/public-key-credential-create-success-hid.https.html:
+        * http/wpt/webauthn/public-key-credential-get-success-hid.https.html:
+        * platform/mac-wk2/TestExpectations:
+
 2018-11-27  Chris Dumez  <cdumez@apple.com>
 
         Resync service-workers web platform tests from upstream
index a21ee3c..cc6cd16 100644 (file)
@@ -47,6 +47,7 @@
                 },
                 challenge: Base64URL.parse("MTIzNDU2"),
                 pubKeyCredParams: [{ type: "public-key", alg: -7 }],
+                timeout: 10
             }
         };
 
@@ -90,7 +91,8 @@
                 },
                 challenge: Base64URL.parse("MTIzNDU2"),
                 pubKeyCredParams: [{ type: "public-key", alg: -7 }],
-                authenticatorSelection: { requireResidentKey: false }
+                authenticatorSelection: { requireResidentKey: false },
+                timeout: 10
             }
         };
 
                 },
                 challenge: Base64URL.parse("MTIzNDU2"),
                 pubKeyCredParams: [{ type: "public-key", alg: -7 }],
-                authenticatorSelection: { userVerification: "preferred" }
+                authenticatorSelection: { userVerification: "preferred" },
+                timeout: 10
             }
         };
 
                 },
                 challenge: Base64URL.parse("MTIzNDU2"),
                 pubKeyCredParams: [{ type: "public-key", alg: -7 }],
-                authenticatorSelection: { userVerification: "discouraged" }
+                authenticatorSelection: { userVerification: "discouraged" },
+                timeout: 10
             }
         };
 
                 },
                 challenge: Base64URL.parse("MTIzNDU2"),
                 pubKeyCredParams: [{ type: "public-key", alg: -7 }],
-                authenticatorSelection: { authenticatorAttachment: "cross-platform", requireResidentKey: false, userVerification: "preferred" }
+                authenticatorSelection: { authenticatorAttachment: "cross-platform", requireResidentKey: false, userVerification: "preferred" },
+                timeout: 10
             }
         };
 
index ae57add..a783830 100644 (file)
@@ -27,7 +27,8 @@
     promise_test(t => {
         const options = {
             publicKey: {
-                challenge: Base64URL.parse("MTIzNDU2")
+                challenge: Base64URL.parse("MTIzNDU2"),
+                timeout: 10
             }
         };
 
@@ -42,7 +43,8 @@
                 challenge: Base64URL.parse("MTIzNDU2"),
                 allowCredentials: [
                     { type: "public-key", id: Base64URL.parse(testHidCredentialIdBase64), transports: ["usb"] }
-                ]
+                ],
+                timeout: 10
             }
         };
 
@@ -55,7 +57,8 @@
         const options = {
             publicKey: {
                 challenge: Base64URL.parse("MTIzNDU2"),
-                userVerification: "preferred"
+                userVerification: "preferred",
+                timeout: 10
             }
         };
 
@@ -68,7 +71,8 @@
         const options = {
             publicKey: {
                 challenge: Base64URL.parse("MTIzNDU2"),
-                userVerification: "discouraged"
+                userVerification: "discouraged",
+                timeout: 10
             }
         };
 
@@ -84,7 +88,8 @@
                 allowCredentials: [
                     { type: "public-key", id: Base64URL.parse(testHidCredentialIdBase64), transports: ["usb"] }
                 ],
-                userVerification: "preferred"
+                userVerification: "preferred",
+                timeout: 10
             }
         };
 
index 4e588ff..be06360 100644 (file)
@@ -906,8 +906,6 @@ http/wpt/webauthn/public-key-credential-get-success-local.https.html [ Skip ]
 # The following tests require PublicKeyCredential objects. We can only produce them via local authenticators now.
 http/wpt/credential-management/credentialscontainer-store-basics.https.html [ Skip ]
 http/wpt/webauthn/idl.https.html [ Skip ]
-# Slow WebAuthN tests.
-http/wpt/webauthn/public-key-credential-get-success-hid.https.html [ Slow ]
 
 webkit.org/b/183878 media/modern-media-controls/tracks-panel/tracks-panel-up-click-over-media-does-not-dimiss-media-controls-when-media-is-playing.html [ Pass Timeout ]