[CMake][Win] EventTargetInterfaces.h are generated twice
authorcommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 22 Sep 2017 18:44:54 +0000 (18:44 +0000)
committercommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 22 Sep 2017 18:44:54 +0000 (18:44 +0000)
https://bugs.webkit.org/show_bug.cgi?id=177286

Patch by Fujii Hironori <Hironori.Fujii@sony.com> on 2017-09-22
Reviewed by Brent Fulgham.

EventTargetInterfaces.h are generated twice in both
WebCoreDerivedSources.vcxproj and WebCore.vcxproj. This causes
unnecessary recompilation in CMake VisualStudio build.

WebCore target already has a dependency to WebCoreDerivedSources
target by calling add_dependencies. WebCore target doesn't need to
generate it.

* CMakeLists.txt: Don't ADD_SOURCE_WEBCORE_DERIVED_DEPENDENCIES with EventTargetInterfaces.h.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@222395 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/WebCore/CMakeLists.txt
Source/WebCore/ChangeLog

index d90f1f7..9cfd434 100644 (file)
@@ -4017,8 +4017,6 @@ list(APPEND WebCore_DERIVED_SOURCES ${DERIVED_SOURCES_WEBCORE_DIR}/EventInterfac
 
 
 GENERATE_EVENT_FACTORY(${WEBCORE_DIR}/dom/EventTargetFactory.in EventTargetInterfaces.h)
-ADD_SOURCE_WEBCORE_DERIVED_DEPENDENCIES(${WEBCORE_DIR}/dom/EventNames.cpp EventTargetInterfaces.h)
-ADD_SOURCE_WEBCORE_DERIVED_DEPENDENCIES(${WEBCORE_DIR}/dom/DOMAllInOne.cpp EventTargetInterfaces.h)
 list(APPEND WebCore_DERIVED_SOURCES ${DERIVED_SOURCES_WEBCORE_DIR}/EventTargetInterfaces.h)
 
 
index 25d0ba7..1d21274 100644 (file)
@@ -1,3 +1,20 @@
+2017-09-22  Fujii Hironori  <Hironori.Fujii@sony.com>
+
+        [CMake][Win] EventTargetInterfaces.h are generated twice
+        https://bugs.webkit.org/show_bug.cgi?id=177286
+
+        Reviewed by Brent Fulgham.
+
+        EventTargetInterfaces.h are generated twice in both
+        WebCoreDerivedSources.vcxproj and WebCore.vcxproj. This causes
+        unnecessary recompilation in CMake VisualStudio build.
+
+        WebCore target already has a dependency to WebCoreDerivedSources
+        target by calling add_dependencies. WebCore target doesn't need to
+        generate it.
+
+        * CMakeLists.txt: Don't ADD_SOURCE_WEBCORE_DERIVED_DEPENDENCIES with EventTargetInterfaces.h.
+
 2017-09-22  Antti Koivisto  <antti@apple.com>
 
         Add asserts against layout time render tree mutations