Use WTF::move() instead of std::move() to help ensure move semantics
authordbates@webkit.org <dbates@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 29 Jul 2014 15:47:39 +0000 (15:47 +0000)
committerdbates@webkit.org <dbates@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 29 Jul 2014 15:47:39 +0000 (15:47 +0000)
https://bugs.webkit.org/show_bug.cgi?id=135351

Reviewed by Alexey Proskuryakov.

Source/JavaScriptCore:
* bytecode/GetByIdStatus.cpp:
(JSC::GetByIdStatus::computeForStubInfo):
* bytecode/GetByIdVariant.cpp:
(JSC::GetByIdVariant::GetByIdVariant):

Source/WebCore:
* page/CaptionUserPreferences.cpp:
(WebCore::CaptionUserPreferences::updateCaptionStyleSheetOveride):

Source/WebKit2:
* UIProcess/API/Cocoa/_WKSessionState.mm:
(-[_WKSessionState _initWithSessionState:]):
* UIProcess/API/gtk/WebKitUserContent.cpp:
(toStringVector): Remove use of std::move(). It's unnecessary to call std::move() on an rvalue.
* WebProcess/WebPage/mac/ServicesOverlayController.mm:
(WebKit::ServicesOverlayController::mouseEvent):

Source/WTF:
* wtf/HashTable.h:
(WTF::KeyTraits>::HashTable):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@171746 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/JavaScriptCore/ChangeLog
Source/JavaScriptCore/bytecode/GetByIdStatus.cpp
Source/JavaScriptCore/bytecode/GetByIdVariant.cpp
Source/WTF/ChangeLog
Source/WTF/wtf/HashTable.h
Source/WebCore/ChangeLog
Source/WebCore/page/CaptionUserPreferences.cpp
Source/WebKit2/ChangeLog
Source/WebKit2/UIProcess/API/Cocoa/_WKSessionState.mm
Source/WebKit2/UIProcess/API/gtk/WebKitUserContent.cpp
Source/WebKit2/WebProcess/WebPage/mac/ServicesOverlayController.mm

index f253a0e..391fd19 100644 (file)
@@ -1,3 +1,15 @@
+2014-07-29  Daniel Bates  <dabates@apple.com>
+
+        Use WTF::move() instead of std::move() to help ensure move semantics
+        https://bugs.webkit.org/show_bug.cgi?id=135351
+
+        Reviewed by Alexey Proskuryakov.
+
+        * bytecode/GetByIdStatus.cpp:
+        (JSC::GetByIdStatus::computeForStubInfo):
+        * bytecode/GetByIdVariant.cpp:
+        (JSC::GetByIdVariant::GetByIdVariant):
+
 2014-07-28  Tamas Gergely  <tgergely.u-szeged@partner.samsung.com>
 
         BuildFix: JavaScriptCore/bytecode/StructureSet.h:262:77: warning.
index 2e9c9ef..1b04e83 100644 (file)
@@ -253,7 +253,7 @@ GetByIdStatus GetByIdStatus::computeForStubInfo(
             
             GetByIdVariant variant(
                 StructureSet(structure), myOffset, specificValue, chain.get(),
-                std::move(callLinkStatus));
+                WTF::move(callLinkStatus));
             
             if (!result.appendVariant(variant))
                 return GetByIdStatus(slowPathState, true);
index cd65f62..ac4e74a 100644 (file)
@@ -39,7 +39,7 @@ GetByIdVariant::GetByIdVariant(
     , m_alternateBase(nullptr)
     , m_specificValue(specificValue)
     , m_offset(offset)
-    , m_callLinkStatus(std::move(callLinkStatus))
+    , m_callLinkStatus(WTF::move(callLinkStatus))
 {
     if (!structureSet.size()) {
         ASSERT(offset == invalidOffset);
index b8bd41f..b4bd0dc 100644 (file)
@@ -1,3 +1,13 @@
+2014-07-29  Daniel Bates  <dabates@apple.com>
+
+        Use WTF::move() instead of std::move() to help ensure move semantics
+        https://bugs.webkit.org/show_bug.cgi?id=135351
+
+        Reviewed by Alexey Proskuryakov.
+
+        * wtf/HashTable.h:
+        (WTF::KeyTraits>::HashTable):
+
 2014-07-28  Brian J. Burg  <burg@cs.washington.edu>
 
         Should not export symbols for base64Encode inline adapter methods
index 1e22c3d..83c2d96 100644 (file)
@@ -1225,7 +1225,7 @@ namespace WTF {
         other.m_deletedCount = 0;
 
 #if DUMP_HASHTABLE_STATS_PER_TABLE
-        m_stats = std::move(other.m_stats);
+        m_stats = WTF::move(other.m_stats);
         other.m_stats = nullptr;
 #endif
     }
@@ -1249,7 +1249,7 @@ namespace WTF {
         other.m_deletedCount = 0;
 
 #if DUMP_HASHTABLE_STATS_PER_TABLE
-        m_stats = std::move(other.m_stats);
+        m_stats = WTF::move(other.m_stats);
         other.m_stats = nullptr;
 #endif
 
index 546aa0d..015b741 100644 (file)
@@ -1,3 +1,13 @@
+2014-07-29  Daniel Bates  <dabates@apple.com>
+
+        Use WTF::move() instead of std::move() to help ensure move semantics
+        https://bugs.webkit.org/show_bug.cgi?id=135351
+
+        Reviewed by Alexey Proskuryakov.
+
+        * page/CaptionUserPreferences.cpp:
+        (WebCore::CaptionUserPreferences::updateCaptionStyleSheetOveride):
+
 2014-07-29  Mihnea Ovidenie  <mihnea@adobe.com>
 
         [CSSRegions] Assertion failure hit testing a region-based multicolumn in a region
index fb8016b..6cdb574 100644 (file)
@@ -253,7 +253,7 @@ void CaptionUserPreferences::updateCaptionStyleSheetOveride()
     for (auto& page : pages) {
         if (auto* pageUserContentController = page->userContentController()) {
             auto userStyleSheet = std::make_unique<UserStyleSheet>(captionsOverrideStyleSheet, captionsStyleSheetURL, Vector<String>(), Vector<String>(), InjectInAllFrames, UserStyleAuthorLevel);
-            pageUserContentController->addUserStyleSheet(mainThreadNormalWorld(), std::move(userStyleSheet), InjectInExistingDocuments);
+            pageUserContentController->addUserStyleSheet(mainThreadNormalWorld(), WTF::move(userStyleSheet), InjectInExistingDocuments);
         }
     }
 }
index 0444ac0..1a8274e 100644 (file)
@@ -1,3 +1,17 @@
+2014-07-29  Daniel Bates  <dabates@apple.com>
+
+        Use WTF::move() instead of std::move() to help ensure move semantics
+        https://bugs.webkit.org/show_bug.cgi?id=135351
+
+        Reviewed by Alexey Proskuryakov.
+
+        * UIProcess/API/Cocoa/_WKSessionState.mm:
+        (-[_WKSessionState _initWithSessionState:]):
+        * UIProcess/API/gtk/WebKitUserContent.cpp:
+        (toStringVector): Remove use of std::move(). It's unnecessary to call std::move() on an rvalue.
+        * WebProcess/WebPage/mac/ServicesOverlayController.mm:
+        (WebKit::ServicesOverlayController::mouseEvent):
+
 2014-07-28  Pratik Solanki  <psolanki@apple.com>
 
         Get SharedBuffer.h out of ResourceBuffer.h (and a few other places)
index 0b70c6a..f87705a 100644 (file)
@@ -50,7 +50,7 @@
     if (!(self = [super init]))
         return nil;
 
-    _sessionState = std::move(sessionState);
+    _sessionState = WTF::move(sessionState);
 
     return self;
 }
index 5eaa951..21d172c 100644 (file)
@@ -70,7 +70,7 @@ static inline Vector<String> toStringVector(const char* const* strv)
 
     Vector<String> result;
     for (auto str = strv; *str; ++str)
-        result.append(std::move(String::fromUTF8(*str)));
+        result.append(String::fromUTF8(*str));
     return result;
 }
 
index 93d664b..32c7d94 100644 (file)
@@ -460,7 +460,7 @@ bool ServicesOverlayController::mouseEvent(PageOverlay*, const WebMouseEvent& ev
 
     // Check and see if the mouse went up and we have a current mouse down highlight button.
     if (event.type() == WebEvent::MouseUp) {
-        RetainPtr<DDHighlightRef> mouseDownHighlight = std::move(m_currentMouseDownOnButtonHighlight);
+        RetainPtr<DDHighlightRef> mouseDownHighlight = WTF::move(m_currentMouseDownOnButtonHighlight);
 
         // If the mouse lifted while still over the highlight button that it went down on, then that is a click.
         if (onButton && mouseDownHighlight) {