Added missing override and final specifiers
authorannulen@yandex.ru <annulen@yandex.ru@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 15 Dec 2016 21:26:08 +0000 (21:26 +0000)
committerannulen@yandex.ru <annulen@yandex.ru@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 15 Dec 2016 21:26:08 +0000 (21:26 +0000)
https://bugs.webkit.org/show_bug.cgi?id=165903

Reviewed by Darin Adler.

Source/JavaScriptCore:

* bytecompiler/BytecodeGenerator.h:
* jsc.cpp:
* parser/Nodes.h:

Source/WebCore:

No new tests needed.

* Modules/mediastream/OverconstrainedErrorEvent.h:
* bindings/js/JSCallbackData.h:
* bindings/js/JSCustomXPathNSResolver.h:
* bindings/js/JSErrorHandler.h:
* css/StyleRuleImport.h:
* dom/SecurityPolicyViolationEvent.h:
* editing/CreateLinkCommand.h:
* editing/DeleteSelectionCommand.h:
* editing/DictationCommand.h:
* editing/Editor.cpp:
* editing/FormatBlockCommand.h:
* editing/IndentOutdentCommand.h:
* editing/InsertLineBreakCommand.h:
* editing/InsertParagraphSeparatorCommand.h:
* editing/ModifySelectionListLevel.h:
* editing/MoveSelectionCommand.h:
* editing/RemoveFormatCommand.h:
* editing/RemoveNodePreservingChildrenCommand.h:
* editing/ReplaceSelectionCommand.h:
* editing/SimplifyMarkupCommand.h:
* editing/SplitTextNodeContainingElementCommand.h:
* editing/UnlinkCommand.h:
* fileapi/FileReaderLoader.h:
* html/canvas/ANGLEInstancedArrays.h:
* html/canvas/WebGLVertexArrayObjectBase.h:
* loader/SinkDocument.h:
* loader/archive/mhtml/MHTMLArchive.h:
* page/animation/CSSPropertyAnimation.cpp:
* platform/audio/MultiChannelResampler.cpp:
* platform/audio/SincResampler.cpp:
* platform/audio/gstreamer/AudioDestinationGStreamer.h:
* platform/audio/gstreamer/AudioSourceProviderGStreamer.h:
* platform/graphics/TextTrackRepresentation.cpp:
* platform/graphics/displaylists/DisplayListItems.h:
* platform/graphics/filters/FEBlend.h:
* platform/graphics/filters/FEColorMatrix.h:
* platform/graphics/filters/FEComponentTransfer.h:
* platform/graphics/filters/FEConvolveMatrix.h:
* platform/graphics/filters/FEDiffuseLighting.h:
* platform/graphics/filters/FEDropShadow.h:
* platform/graphics/filters/FEGaussianBlur.h:
* platform/graphics/filters/FELighting.h:
* platform/graphics/filters/FEMerge.h:
* platform/graphics/filters/FEMorphology.h:
* platform/graphics/filters/FEOffset.h:
* platform/graphics/filters/FESpecularLighting.h:
* platform/graphics/filters/FETile.h:
* platform/graphics/filters/FETurbulence.h:
* platform/graphics/filters/SourceAlpha.h:
* platform/graphics/filters/SourceGraphic.h:
* platform/graphics/opengl/Extensions3DOpenGL.h:
* platform/graphics/opengl/Extensions3DOpenGLCommon.h:
* platform/graphics/texmap/TextureMapperBackingStore.h:
* platform/mediastream/openwebrtc/RealtimeMediaSourceOwr.h:
* platform/mock/GeolocationClientMock.h:
* platform/text/TextCodecICU.h:
* platform/text/TextCodecLatin1.h:
* platform/text/TextCodecUTF16.h:
* platform/text/TextCodecUTF8.h:
* platform/text/TextCodecUserDefined.h:
* rendering/RenderFullScreen.cpp:
* storage/StorageEvent.h:
* svg/properties/SVGListProperty.h:
* svg/properties/SVGStaticListPropertyTearOff.h:
* svg/properties/SVGStaticPropertyTearOff.h:
* xml/NativeXPathNSResolver.h:
* xml/XMLHttpRequestProgressEvent.h:
* xml/XMLHttpRequestProgressEventThrottle.h:
* xml/XPathVariableReference.h:
* xml/XSLImportRule.h:

Source/WebKit2:

* UIProcess/API/gtk/WebKitGeolocationProvider.h:
* UIProcess/WebFormSubmissionListenerProxy.h:
* UIProcess/WebFramePolicyListenerProxy.h:
* WebProcess/Automation/WebAutomationSessionProxy.h:
* WebProcess/InjectedBundle/API/gtk/DOM/GObjectXPathNSResolver.h:
* WebProcess/MediaCache/WebMediaKeyStorageManager.h:
* WebProcess/Plugins/Netscape/NPRuntimeObjectMap.h:
* WebProcess/WebCoreSupport/WebPlugInClient.h:
* WebProcess/WebCoreSupport/soup/WebFrameNetworkingContext.h:
* WebProcess/WebPage/FindController.h:

Source/WTF:

* wtf/RunLoop.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@209871 268f45cc-cd09-0410-ab3c-d52691b4dbfc

88 files changed:
Source/JavaScriptCore/ChangeLog
Source/JavaScriptCore/bytecompiler/BytecodeGenerator.h
Source/JavaScriptCore/jsc.cpp
Source/JavaScriptCore/parser/Nodes.h
Source/WTF/ChangeLog
Source/WTF/wtf/RunLoop.h
Source/WebCore/ChangeLog
Source/WebCore/Modules/mediastream/OverconstrainedErrorEvent.h
Source/WebCore/bindings/js/JSCallbackData.h
Source/WebCore/bindings/js/JSCustomXPathNSResolver.h
Source/WebCore/bindings/js/JSErrorHandler.h
Source/WebCore/css/StyleRuleImport.h
Source/WebCore/dom/SecurityPolicyViolationEvent.h
Source/WebCore/editing/CreateLinkCommand.h
Source/WebCore/editing/DeleteSelectionCommand.h
Source/WebCore/editing/DictationCommand.h
Source/WebCore/editing/Editor.cpp
Source/WebCore/editing/FormatBlockCommand.h
Source/WebCore/editing/IndentOutdentCommand.h
Source/WebCore/editing/InsertLineBreakCommand.h
Source/WebCore/editing/InsertParagraphSeparatorCommand.h
Source/WebCore/editing/ModifySelectionListLevel.h
Source/WebCore/editing/MoveSelectionCommand.h
Source/WebCore/editing/RemoveFormatCommand.h
Source/WebCore/editing/RemoveNodePreservingChildrenCommand.h
Source/WebCore/editing/ReplaceSelectionCommand.h
Source/WebCore/editing/SimplifyMarkupCommand.h
Source/WebCore/editing/SplitTextNodeContainingElementCommand.h
Source/WebCore/editing/UnlinkCommand.h
Source/WebCore/fileapi/FileReaderLoader.h
Source/WebCore/html/canvas/ANGLEInstancedArrays.h
Source/WebCore/html/canvas/WebGLVertexArrayObjectBase.h
Source/WebCore/loader/SinkDocument.h
Source/WebCore/loader/archive/mhtml/MHTMLArchive.h
Source/WebCore/page/animation/CSSPropertyAnimation.cpp
Source/WebCore/platform/audio/MultiChannelResampler.cpp
Source/WebCore/platform/audio/SincResampler.cpp
Source/WebCore/platform/audio/gstreamer/AudioDestinationGStreamer.h
Source/WebCore/platform/audio/gstreamer/AudioSourceProviderGStreamer.h
Source/WebCore/platform/graphics/TextTrackRepresentation.cpp
Source/WebCore/platform/graphics/displaylists/DisplayListItems.h
Source/WebCore/platform/graphics/filters/FEBlend.h
Source/WebCore/platform/graphics/filters/FEColorMatrix.h
Source/WebCore/platform/graphics/filters/FEComponentTransfer.h
Source/WebCore/platform/graphics/filters/FEConvolveMatrix.h
Source/WebCore/platform/graphics/filters/FEDiffuseLighting.h
Source/WebCore/platform/graphics/filters/FEDropShadow.h
Source/WebCore/platform/graphics/filters/FEGaussianBlur.h
Source/WebCore/platform/graphics/filters/FELighting.h
Source/WebCore/platform/graphics/filters/FEMerge.h
Source/WebCore/platform/graphics/filters/FEMorphology.h
Source/WebCore/platform/graphics/filters/FEOffset.h
Source/WebCore/platform/graphics/filters/FESpecularLighting.h
Source/WebCore/platform/graphics/filters/FETile.h
Source/WebCore/platform/graphics/filters/FETurbulence.h
Source/WebCore/platform/graphics/filters/SourceAlpha.h
Source/WebCore/platform/graphics/filters/SourceGraphic.h
Source/WebCore/platform/graphics/opengl/Extensions3DOpenGL.h
Source/WebCore/platform/graphics/opengl/Extensions3DOpenGLCommon.h
Source/WebCore/platform/graphics/texmap/TextureMapperBackingStore.h
Source/WebCore/platform/mediastream/openwebrtc/RealtimeMediaSourceOwr.h
Source/WebCore/platform/mock/GeolocationClientMock.h
Source/WebCore/platform/text/TextCodecICU.h
Source/WebCore/platform/text/TextCodecLatin1.h
Source/WebCore/platform/text/TextCodecUTF16.h
Source/WebCore/platform/text/TextCodecUTF8.h
Source/WebCore/platform/text/TextCodecUserDefined.h
Source/WebCore/rendering/RenderFullScreen.cpp
Source/WebCore/storage/StorageEvent.h
Source/WebCore/svg/properties/SVGListProperty.h
Source/WebCore/svg/properties/SVGStaticListPropertyTearOff.h
Source/WebCore/svg/properties/SVGStaticPropertyTearOff.h
Source/WebCore/xml/NativeXPathNSResolver.h
Source/WebCore/xml/XMLHttpRequestProgressEvent.h
Source/WebCore/xml/XMLHttpRequestProgressEventThrottle.h
Source/WebCore/xml/XPathVariableReference.h
Source/WebCore/xml/XSLImportRule.h
Source/WebKit2/ChangeLog
Source/WebKit2/UIProcess/API/gtk/WebKitGeolocationProvider.h
Source/WebKit2/UIProcess/WebFormSubmissionListenerProxy.h
Source/WebKit2/UIProcess/WebFramePolicyListenerProxy.h
Source/WebKit2/WebProcess/Automation/WebAutomationSessionProxy.h
Source/WebKit2/WebProcess/InjectedBundle/API/gtk/DOM/GObjectXPathNSResolver.h
Source/WebKit2/WebProcess/MediaCache/WebMediaKeyStorageManager.h
Source/WebKit2/WebProcess/Plugins/Netscape/NPRuntimeObjectMap.h
Source/WebKit2/WebProcess/WebCoreSupport/WebPlugInClient.h
Source/WebKit2/WebProcess/WebCoreSupport/soup/WebFrameNetworkingContext.h
Source/WebKit2/WebProcess/WebPage/FindController.h

index 10fcfdd..bf04371 100644 (file)
@@ -1,3 +1,14 @@
+2016-12-15  Konstantin Tokarev  <annulen@yandex.ru>
+
+        Added missing override and final specifiers
+        https://bugs.webkit.org/show_bug.cgi?id=165903
+
+        Reviewed by Darin Adler.
+
+        * bytecompiler/BytecodeGenerator.h:
+        * jsc.cpp:
+        * parser/Nodes.h:
+
 2016-12-15  Chris Dumez  <cdumez@apple.com>
 
         Harden JSObject::getOwnPropertyDescriptor()
index b71ee0b..961af71 100644 (file)
@@ -139,7 +139,7 @@ namespace JSC {
         {
         }
 
-        virtual ForInContextType type() const
+        ForInContextType type() const override
         {
             return StructureForInContextType;
         }
@@ -162,7 +162,7 @@ namespace JSC {
         {
         }
 
-        virtual ForInContextType type() const
+        ForInContextType type() const override
         {
             return IndexedForInContextType;
         }
index ec79d83..4a29494 100644 (file)
@@ -201,7 +201,7 @@ private:
 
 class ElementHandleOwner : public WeakHandleOwner {
 public:
-    virtual bool isReachableFromOpaqueRoots(Handle<JSC::Unknown> handle, void*, SlotVisitor& visitor)
+    bool isReachableFromOpaqueRoots(Handle<JSC::Unknown> handle, void*, SlotVisitor& visitor) override
     {
         Element* element = jsCast<Element*>(handle.slot()->asCell());
         return visitor.containsOpaqueRoot(element->root());
index fb453e8..24110aa 100644 (file)
@@ -1752,7 +1752,7 @@ namespace JSC {
     class ModuleDeclarationNode : public StatementNode {
     public:
         virtual void analyzeModule(ModuleAnalyzer&) = 0;
-        virtual bool isModuleDeclarationNode() const { return true; }
+        bool isModuleDeclarationNode() const override { return true; }
 
     protected:
         ModuleDeclarationNode(const JSTokenLocation&);
index c3f27da..ab47ad8 100644 (file)
@@ -1,3 +1,12 @@
+2016-12-15  Konstantin Tokarev  <annulen@yandex.ru>
+
+        Added missing override and final specifiers
+        https://bugs.webkit.org/show_bug.cgi?id=165903
+
+        Reviewed by Darin Adler.
+
+        * wtf/RunLoop.h:
+
 2016-12-15  Yusuke Suzuki  <utatane.tea@gmail.com>
 
         [JSC] Optimize Kraken stringify
index 555d447..f6a1177 100644 (file)
@@ -142,7 +142,7 @@ public:
         }
 
     private:
-        virtual void fired() { (m_object->*m_function)(); }
+        void fired() override { (m_object->*m_function)(); }
 
         TimerFiredClass* m_object;
         TimerFiredFunction m_function;
index 9a19bb3..15d3d76 100644 (file)
@@ -1,3 +1,83 @@
+2016-12-15  Konstantin Tokarev  <annulen@yandex.ru>
+
+        Added missing override and final specifiers
+        https://bugs.webkit.org/show_bug.cgi?id=165903
+
+        Reviewed by Darin Adler.
+
+        No new tests needed.
+
+        * Modules/mediastream/OverconstrainedErrorEvent.h:
+        * bindings/js/JSCallbackData.h:
+        * bindings/js/JSCustomXPathNSResolver.h:
+        * bindings/js/JSErrorHandler.h:
+        * css/StyleRuleImport.h:
+        * dom/SecurityPolicyViolationEvent.h:
+        * editing/CreateLinkCommand.h:
+        * editing/DeleteSelectionCommand.h:
+        * editing/DictationCommand.h:
+        * editing/Editor.cpp:
+        * editing/FormatBlockCommand.h:
+        * editing/IndentOutdentCommand.h:
+        * editing/InsertLineBreakCommand.h:
+        * editing/InsertParagraphSeparatorCommand.h:
+        * editing/ModifySelectionListLevel.h:
+        * editing/MoveSelectionCommand.h:
+        * editing/RemoveFormatCommand.h:
+        * editing/RemoveNodePreservingChildrenCommand.h:
+        * editing/ReplaceSelectionCommand.h:
+        * editing/SimplifyMarkupCommand.h:
+        * editing/SplitTextNodeContainingElementCommand.h:
+        * editing/UnlinkCommand.h:
+        * fileapi/FileReaderLoader.h:
+        * html/canvas/ANGLEInstancedArrays.h:
+        * html/canvas/WebGLVertexArrayObjectBase.h:
+        * loader/SinkDocument.h:
+        * loader/archive/mhtml/MHTMLArchive.h:
+        * page/animation/CSSPropertyAnimation.cpp:
+        * platform/audio/MultiChannelResampler.cpp:
+        * platform/audio/SincResampler.cpp:
+        * platform/audio/gstreamer/AudioDestinationGStreamer.h:
+        * platform/audio/gstreamer/AudioSourceProviderGStreamer.h:
+        * platform/graphics/TextTrackRepresentation.cpp:
+        * platform/graphics/displaylists/DisplayListItems.h:
+        * platform/graphics/filters/FEBlend.h:
+        * platform/graphics/filters/FEColorMatrix.h:
+        * platform/graphics/filters/FEComponentTransfer.h:
+        * platform/graphics/filters/FEConvolveMatrix.h:
+        * platform/graphics/filters/FEDiffuseLighting.h:
+        * platform/graphics/filters/FEDropShadow.h:
+        * platform/graphics/filters/FEGaussianBlur.h:
+        * platform/graphics/filters/FELighting.h:
+        * platform/graphics/filters/FEMerge.h:
+        * platform/graphics/filters/FEMorphology.h:
+        * platform/graphics/filters/FEOffset.h:
+        * platform/graphics/filters/FESpecularLighting.h:
+        * platform/graphics/filters/FETile.h:
+        * platform/graphics/filters/FETurbulence.h:
+        * platform/graphics/filters/SourceAlpha.h:
+        * platform/graphics/filters/SourceGraphic.h:
+        * platform/graphics/opengl/Extensions3DOpenGL.h:
+        * platform/graphics/opengl/Extensions3DOpenGLCommon.h:
+        * platform/graphics/texmap/TextureMapperBackingStore.h:
+        * platform/mediastream/openwebrtc/RealtimeMediaSourceOwr.h:
+        * platform/mock/GeolocationClientMock.h:
+        * platform/text/TextCodecICU.h:
+        * platform/text/TextCodecLatin1.h:
+        * platform/text/TextCodecUTF16.h:
+        * platform/text/TextCodecUTF8.h:
+        * platform/text/TextCodecUserDefined.h:
+        * rendering/RenderFullScreen.cpp:
+        * storage/StorageEvent.h:
+        * svg/properties/SVGListProperty.h:
+        * svg/properties/SVGStaticListPropertyTearOff.h:
+        * svg/properties/SVGStaticPropertyTearOff.h:
+        * xml/NativeXPathNSResolver.h:
+        * xml/XMLHttpRequestProgressEvent.h:
+        * xml/XMLHttpRequestProgressEventThrottle.h:
+        * xml/XPathVariableReference.h:
+        * xml/XSLImportRule.h:
+
 2016-12-15  Chris Dumez  <cdumez@apple.com>
 
         Inline Document::existingAXObjectCache()
index 7e8fb1e..9c4f396 100644 (file)
@@ -55,7 +55,7 @@ public:
     }
 
     OverconstrainedError* error() const { return m_error.get(); }
-    virtual EventInterface eventInterface() const { return OverconstrainedErrorEventInterfaceType; }
+    EventInterface eventInterface() const override { return OverconstrainedErrorEventInterfaceType; }
 
 private:
     explicit OverconstrainedErrorEvent(const AtomicString& type, bool canBubble, bool cancelable, OverconstrainedError* error)
index a6bef7b..d3327c9 100644 (file)
@@ -105,7 +105,7 @@ public:
 
 private:
     class WeakOwner : public JSC::WeakHandleOwner {
-        virtual bool isReachableFromOpaqueRoots(JSC::Handle<JSC::Unknown>, void* context, JSC::SlotVisitor&);
+        bool isReachableFromOpaqueRoots(JSC::Handle<JSC::Unknown>, void* context, JSC::SlotVisitor&) override;
     };
     WeakOwner m_weakOwner;
     JSC::Weak<JSC::JSObject> m_callback;
index 0eedce2..0441f54 100644 (file)
@@ -49,7 +49,7 @@ namespace WebCore {
         
         virtual ~JSCustomXPathNSResolver();
 
-        virtual String lookupNamespaceURI(const String& prefix);
+        String lookupNamespaceURI(const String& prefix) override;
 
     private:
         JSCustomXPathNSResolver(JSC::ExecState*, JSC::JSObject*, JSDOMWindow*);
index 5a2dd34..ba01c0e 100644 (file)
@@ -45,7 +45,7 @@ public:
 
 private:
     JSErrorHandler(JSC::JSObject* function, JSC::JSObject* wrapper, bool isAttribute, DOMWrapperWorld&);
-    virtual void handleEvent(ScriptExecutionContext*, Event*);
+    void handleEvent(ScriptExecutionContext*, Event*) final;
 };
 
 // Creates a JS EventListener for "onerror" event handler in worker context. It has custom implementation because
index adaec6c..264d570 100644 (file)
@@ -59,7 +59,7 @@ class ImportedStyleSheetClient final : public CachedStyleSheetClient {
     public:
         ImportedStyleSheetClient(StyleRuleImport* ownerRule) : m_ownerRule(ownerRule) { }
         virtual ~ImportedStyleSheetClient() { }
-        virtual void setCSSStyleSheet(const String& href, const URL& baseURL, const String& charset, const CachedCSSStyleSheet* sheet)
+        void setCSSStyleSheet(const String& href, const URL& baseURL, const String& charset, const CachedCSSStyleSheet* sheet) final
         {
             m_ownerRule->setCSSStyleSheet(href, baseURL, charset, sheet);
         }
index 2672d12..a6032f2 100644 (file)
@@ -70,7 +70,7 @@ public:
     int lineNumber() const { return m_lineNumber; }
     int columnNumber() const { return m_columnNumber; }
 
-    virtual EventInterface eventInterface() const { return SecurityPolicyViolationEventInterfaceType; }
+    EventInterface eventInterface() const final { return SecurityPolicyViolationEventInterfaceType; }
 
 private:
     SecurityPolicyViolationEvent()
index b7ef2e9..39b98d0 100644 (file)
@@ -36,13 +36,13 @@ public:
         return adoptRef(*new CreateLinkCommand(document, linkURL));
     }
 
-    bool isCreateLinkCommand() const { return true; }
+    bool isCreateLinkCommand() const override { return true; }
 
 private:
     CreateLinkCommand(Document&, const String& linkURL);
 
-    virtual void doApply();
-    virtual EditAction editingAction() const { return EditActionCreateLink; }
+    void doApply() override;
+    EditAction editingAction() const override { return EditActionCreateLink; }
 
     String m_url;
 };
index 6860df6..484672f 100644 (file)
@@ -48,9 +48,9 @@ protected:
 private:
     DeleteSelectionCommand(const VisibleSelection&, bool smartDelete, bool mergeBlocksAfterDelete, bool replace, bool expandForSpecialElements, bool sanitizeMarkup, EditAction);
 
-    virtual void doApply();
+    void doApply() override;
     
-    virtual bool preservesTypingStyle() const;
+    bool preservesTypingStyle() const override;
 
     void initializeStartEnd(Position&, Position&);
     void setStartingSelectionOnSmartDelete(const Position&, const Position&);
@@ -66,8 +66,8 @@ private:
     void calculateTypingStyleAfterDelete();
     void clearTransientState();
     void makeStylingElementsDirectChildrenOfEditableRootToPreventStyleLoss();
-    virtual void removeNode(PassRefPtr<Node>, ShouldAssumeContentIsAlwaysEditable = DoNotAssumeContentIsAlwaysEditable);
-    virtual void deleteTextFromNode(PassRefPtr<Text>, unsigned, unsigned);
+    void removeNode(PassRefPtr<Node>, ShouldAssumeContentIsAlwaysEditable = DoNotAssumeContentIsAlwaysEditable) override;
+    void deleteTextFromNode(PassRefPtr<Text>, unsigned, unsigned) override;
     void removeRedundantBlocks();
 
     // This function provides access to original string after the correction has been deleted.
index b966028..13c1887 100644 (file)
@@ -34,7 +34,7 @@ class DictationCommand : public TextInsertionBaseCommand {
     friend class DictationCommandLineOperation;
 public:
     static void insertText(Document&, const String&, const Vector<DictationAlternative>& alternatives, const VisibleSelection&);
-    virtual bool isDictationCommand() const { return true; }
+    bool isDictationCommand() const override { return true; }
 private:
     static Ref<DictationCommand> create(Document& document, const String& text, const Vector<DictationAlternative>& alternatives)
     {
@@ -43,7 +43,7 @@ private:
 
     DictationCommand(Document&, const String& text, const Vector<DictationAlternative>& alternatives);
     
-    virtual void doApply();
+    void doApply() override;
 
     void insertTextRunWithoutNewlines(size_t lineStart, size_t lineLength);
     void insertParagraphSeparator();
index a9ef6fe..c432b91 100644 (file)
@@ -146,7 +146,7 @@ public:
     static void CreateAndApply(const RefPtr<Frame> frame);
     
 private:
-    virtual EditAction editingAction() const;
+    EditAction editingAction() const override;
 };
 
 ClearTextCommand::ClearTextCommand(Document& document)
index 0976a2a..42e4571 100644 (file)
@@ -44,7 +44,7 @@ public:
         return adoptRef(*new FormatBlockCommand(document, tagName));
     }
     
-    virtual bool preservesTypingStyle() const { return true; }
+    bool preservesTypingStyle() const override { return true; }
 
     static Element* elementForFormatBlockCommand(Range*);
     bool didApply() const { return m_didApply; }
@@ -52,9 +52,9 @@ public:
 private:
     FormatBlockCommand(Document&, const QualifiedName& tagName);
 
-    void formatSelection(const VisiblePosition& startOfSelection, const VisiblePosition& endOfSelection);
-    void formatRange(const Position& start, const Position& end, const Position& endOfSelection, RefPtr<Element>&);
-    EditAction editingAction() const { return EditActionFormatBlock; }
+    void formatSelection(const VisiblePosition& startOfSelection, const VisiblePosition& endOfSelection) override;
+    void formatRange(const Position& start, const Position& end, const Position& endOfSelection, RefPtr<Element>&) override;
+    EditAction editingAction() const override { return EditActionFormatBlock; }
 
     bool m_didApply;
 };
index 7554a6e..b6356b8 100644 (file)
@@ -38,12 +38,12 @@ public:
         return adoptRef(*new IndentOutdentCommand(document, type, marginInPixels));
     }
 
-    virtual bool preservesTypingStyle() const { return true; }
+    bool preservesTypingStyle() const override { return true; }
 
 private:
     IndentOutdentCommand(Document&, EIndentType, int marginInPixels);
 
-    virtual EditAction editingAction() const { return m_typeOfAction == Indent ? EditActionIndent : EditActionOutdent; }
+    EditAction editingAction() const override { return m_typeOfAction == Indent ? EditActionIndent : EditActionOutdent; }
 
     void indentRegion(const VisiblePosition&, const VisiblePosition&);
     void outdentRegion(const VisiblePosition&, const VisiblePosition&);
@@ -51,8 +51,8 @@ private:
     bool tryIndentingAsListItem(const Position&, const Position&);
     void indentIntoBlockquote(const Position&, const Position&, RefPtr<Element>&);
 
-    void formatSelection(const VisiblePosition& startOfSelection, const VisiblePosition& endOfSelection);
-    void formatRange(const Position& start, const Position& end, const Position& endOfSelection, RefPtr<Element>& blockquoteForNextIndent);
+    void formatSelection(const VisiblePosition& startOfSelection, const VisiblePosition& endOfSelection) override;
+    void formatRange(const Position& start, const Position& end, const Position& endOfSelection, RefPtr<Element>& blockquoteForNextIndent) override;
 
     EIndentType m_typeOfAction;
     int m_marginInPixels;
index 6fc6108..2b3d1bf 100644 (file)
@@ -39,9 +39,9 @@ public:
 private:
     explicit InsertLineBreakCommand(Document&);
 
-    virtual void doApply();
+    void doApply() override;
 
-    virtual bool preservesTypingStyle() const;
+    bool preservesTypingStyle() const override;
 
     void insertNodeAfterPosition(Node*, const Position&);
     void insertNodeBeforePosition(Node*, const Position&);
index 34c02ad..5efdd53 100644 (file)
@@ -41,7 +41,7 @@ public:
 private:
     InsertParagraphSeparatorCommand(Document&, bool useDefaultParagraphElement, bool pasteBlockqutoeIntoUnquotedArea, EditAction);
 
-    virtual void doApply();
+    void doApply() override;
 
     void calculateStyleBeforeInsertion(const Position&);
     void applyStyleAfterInsertion(Node* originalEnclosingBlock);
@@ -50,7 +50,7 @@ private:
 
     bool shouldUseDefaultParagraphElement(Node*) const;
 
-    virtual bool preservesTypingStyle() const;
+    bool preservesTypingStyle() const override;
 
     RefPtr<EditingStyle> m_style;
 
index cd3331b..cc06cf4 100644 (file)
@@ -41,7 +41,7 @@ protected:
     void insertSiblingNodeRangeAfter(Node* startNode, Node* endNode, Node* refNode);
 
 private:
-    virtual bool preservesTypingStyle() const;    
+    bool preservesTypingStyle() const override;
 };
 
 // IncreaseSelectionListLevelCommand moves the selected list items one level deeper.
@@ -63,7 +63,7 @@ private:
     
     IncreaseSelectionListLevelCommand(Document&, Type);
 
-    virtual void doApply();
+    void doApply() override;
 
     Type m_listType;
     RefPtr<Node> m_listElement;
@@ -83,7 +83,7 @@ private:
 
     explicit DecreaseSelectionListLevelCommand(Document&);
 
-    virtual void doApply();
+    void doApply() override;
 };
 
 } // namespace WebCore
index 3b6e118..8b3c338 100644 (file)
@@ -41,8 +41,8 @@ public:
 private:
     MoveSelectionCommand(PassRefPtr<DocumentFragment>, const Position&, bool smartInsert, bool smartDelete);
 
-    virtual void doApply();
-    virtual EditAction editingAction() const;
+    void doApply() override;
+    EditAction editingAction() const override;
     bool shouldDispatchInputEvents() const final { return false; }
     
     RefPtr<DocumentFragment> m_fragment;
index e7b272e..a493b3a 100644 (file)
@@ -39,8 +39,8 @@ public:
 private:
     explicit RemoveFormatCommand(Document&);
 
-    virtual void doApply();
-    virtual EditAction editingAction() const { return EditActionUnspecified; }
+    void doApply() override;
+    EditAction editingAction() const override { return EditActionUnspecified; }
 };
 
 } // namespace WebCore
index 1ed36a7..07ea088 100644 (file)
@@ -39,7 +39,7 @@ public:
 private:
     explicit RemoveNodePreservingChildrenCommand(PassRefPtr<Node>, ShouldAssumeContentIsAlwaysEditable, EditAction);
 
-    virtual void doApply();
+    void doApply() override;
 
     RefPtr<Node> m_node;
     ShouldAssumeContentIsAlwaysEditable m_shouldAssumeContentIsAlwaysEditable;
index cf9d467..3d2f419 100644 (file)
@@ -60,7 +60,7 @@ private:
     String inputEventData() const final;
     RefPtr<DataTransfer> inputEventDataTransfer() const final;
     bool willApplyCommand() final;
-    virtual void doApply();
+    void doApply() override;
 
     class InsertedNodes {
     public:
index 8c1843a..2d8257a 100644 (file)
@@ -39,7 +39,7 @@ public:
 private:
     SimplifyMarkupCommand(Document&, Node* firstNode, Node* nodeAfterLast);
 
-    virtual void doApply();
+    void doApply() override;
     int pruneSubsequentAncestorsToRemove(Vector<RefPtr<Node>>& nodesToRemove, size_t startNodeIndex);
 
     RefPtr<Node> m_firstNode;
index 32aa7e8..5e69e12 100644 (file)
@@ -39,7 +39,7 @@ public:
 private:
     SplitTextNodeContainingElementCommand(PassRefPtr<Text>, int offset);
 
-    virtual void doApply();
+    void doApply() override;
 
     RefPtr<Text> m_text;
     int m_offset;
index 34496b1..17c50a9 100644 (file)
@@ -39,8 +39,8 @@ public:
 private:
     explicit UnlinkCommand(Document&);
 
-    virtual void doApply();
-    virtual EditAction editingAction() const { return EditActionUnlink; }
+    void doApply() override;
+    EditAction editingAction() const override { return EditActionUnlink; }
 };
 
 } // namespace WebCore
index ac49b1d..5f4e73e 100644 (file)
@@ -68,10 +68,10 @@ public:
     void cancel();
 
     // ThreadableLoaderClient
-    virtual void didReceiveResponse(unsigned long, const ResourceResponse&);
-    virtual void didReceiveData(const char*, int);
-    virtual void didFinishLoading(unsigned long, double);
-    virtual void didFail(const ResourceError&);
+    void didReceiveResponse(unsigned long, const ResourceResponse&) override;
+    void didReceiveData(const char*, int) override;
+    void didFinishLoading(unsigned long, double) override;
+    void didFail(const ResourceError&) override;
 
     String stringResult();
     RefPtr<JSC::ArrayBuffer> arrayBufferResult() const;
index cd16c23..d413827 100644 (file)
@@ -36,7 +36,7 @@ public:
     explicit ANGLEInstancedArrays(WebGLRenderingContextBase&);
     virtual ~ANGLEInstancedArrays();
 
-    virtual ExtensionName getName() const;
+    ExtensionName getName() const final;
 
     static bool supported(WebGLRenderingContextBase&);
 
index 3f07dde..290ab8d 100644 (file)
@@ -85,7 +85,7 @@ public:
 
 protected:
     WebGLVertexArrayObjectBase(WebGLRenderingContextBase&, VAOType);
-    virtual void deleteObjectImpl(GraphicsContext3D*, Platform3DObject) = 0;
+    void deleteObjectImpl(GraphicsContext3D*, Platform3DObject) override = 0;
     
     VAOType m_type;
     bool m_hasEverBeenBound;
index f739297..f70f28c 100644 (file)
@@ -38,8 +38,8 @@ public:
 
 private:
     SinkDocument(Frame*, const URL&);
-    
-    virtual Ref<DocumentParser> createParser();
+
+    Ref<DocumentParser> createParser() final;
 };
 
 }; // namespace WebCore
index ef7d6a2..ca20003 100644 (file)
@@ -42,7 +42,7 @@ class SharedBuffer;
 
 class MHTMLArchive : public Archive {
 public:
-    virtual Type type() const { return MHTML; }
+    Type type() const override { return MHTML; }
 
     static Ref<MHTMLArchive> create();
     static RefPtr<MHTMLArchive> create(const URL&, SharedBuffer&);
index 9e53275..9016513 100644 (file)
@@ -461,7 +461,7 @@ public:
     {
     }
 
-    virtual void blend(const AnimationBase* anim, RenderStyle* dst, const RenderStyle* a, const RenderStyle* b, double progress) const
+    void blend(const AnimationBase* anim, RenderStyle* dst, const RenderStyle* a, const RenderStyle* b, double progress) const override
     {
         (dst->*m_setter)(blendFunc(anim, (a->*PropertyWrapperGetter<T>::m_getter)(), (b->*PropertyWrapperGetter<T>::m_getter)(), progress));
     }
@@ -480,7 +480,7 @@ public:
     {
     }
 
-    virtual void blend(const AnimationBase* anim, RenderStyle* dst, const RenderStyle* a, const RenderStyle* b, double progress) const
+    void blend(const AnimationBase* anim, RenderStyle* dst, const RenderStyle* a, const RenderStyle* b, double progress) const override
     {
         (dst->*m_setter)(blendFunc(anim, (a->*PropertyWrapperGetter<T*>::m_getter)(), (b->*PropertyWrapperGetter<T*>::m_getter)(), progress));
     }
@@ -499,7 +499,7 @@ public:
     {
     }
 
-    virtual void blend(const AnimationBase* anim, RenderStyle* dst, const RenderStyle* a, const RenderStyle* b, double progress) const
+    void blend(const AnimationBase* anim, RenderStyle* dst, const RenderStyle* a, const RenderStyle* b, double progress) const override
     {
         (dst->*m_setter)(blendFunc(anim, (a->*PropertyWrapperGetter<const T&>::m_getter)(), (b->*PropertyWrapperGetter<const T&>::m_getter)(), progress));
     }
@@ -998,7 +998,7 @@ public:
     {
     }
 
-    virtual void blend(const AnimationBase* anim, FillLayer* dst, const FillLayer* a, const FillLayer* b, double progress) const
+    void blend(const AnimationBase* anim, FillLayer* dst, const FillLayer* a, const FillLayer* b, double progress) const override
     {
         (dst->*m_setter)(blendFunc(anim, (a->*FillLayerPropertyWrapperGetter<const T&>::m_getter)(), (b->*FillLayerPropertyWrapperGetter<const T&>::m_getter)(), progress));
     }
@@ -1017,7 +1017,7 @@ public:
     {
     }
 
-    virtual void blend(const AnimationBase* anim, FillLayer* dst, const FillLayer* a, const FillLayer* b, double progress) const
+    void blend(const AnimationBase* anim, FillLayer* dst, const FillLayer* a, const FillLayer* b, double progress) const override
     {
         (dst->*m_setter)(blendFunc(anim, (a->*FillLayerPropertyWrapperGetter<T*>::m_getter)(), (b->*FillLayerPropertyWrapperGetter<T*>::m_getter)(), progress));
     }
index dbf4369..899a814 100644 (file)
@@ -53,7 +53,7 @@ public:
 
     // provideInput() will be called once for each channel, starting with the first channel.
     // Each time it's called, it will provide the next channel of data.
-    virtual void provideInput(AudioBus* bus, size_t framesToProcess)
+    void provideInput(AudioBus* bus, size_t framesToProcess) override
     {
         bool isBusGood = bus && bus->numberOfChannels() == 1;
         ASSERT(isBusGood);
index 9a9c546..c4cce86 100644 (file)
@@ -153,7 +153,7 @@ public:
     }
     
     // Consumes samples from the in-memory buffer.
-    virtual void provideInput(AudioBus* bus, size_t framesToProcess)
+    void provideInput(AudioBus* bus, size_t framesToProcess) override
     {
         ASSERT(m_source && bus);
         if (!m_source || !bus)
index fa06622..3b89feb 100644 (file)
@@ -34,11 +34,11 @@ public:
     AudioDestinationGStreamer(AudioIOCallback&, float sampleRate);
     virtual ~AudioDestinationGStreamer();
 
-    virtual void start();
-    virtual void stop();
+    void start() override;
+    void stop() override;
 
-    bool isPlaying() { return m_isPlaying; }
-    float sampleRate() const { return m_sampleRate; }
+    bool isPlaying() override { return m_isPlaying; }
+    float sampleRate() const override { return m_sampleRate; }
     AudioIOCallback& callback() const { return m_callback; }
 
     gboolean handleMessage(GstMessage*);
index 70e67c3..5b6480f 100644 (file)
@@ -40,8 +40,8 @@ public:
 
     void configureAudioBin(GstElement* audioBin, GstElement* teePredecessor);
 
-    void provideInput(AudioBus*, size_t framesToProcess);
-    void setClient(AudioSourceProviderClient*);
+    void provideInput(AudioBus*, size_t framesToProcess) override;
+    void setClient(AudioSourceProviderClient*) override;
     const AudioSourceProviderClient* client() const { return m_client; }
 
     void handleNewDeinterleavePad(GstPad*);
index 8a5d6a2..d06d3a2 100644 (file)
@@ -36,10 +36,10 @@ namespace WebCore {
 class NullTextTrackRepresentation : public TextTrackRepresentation {
 public:
     virtual ~NullTextTrackRepresentation() { }
-    virtual void update() { }
-    virtual PlatformLayer* platformLayer() { return nullptr; }
-    virtual void setContentScale(float) { }
-    virtual IntRect bounds() const { return IntRect(); }
+    void update() override { }
+    PlatformLayer* platformLayer() override { return nullptr; }
+    void setContentScale(float) override { }
+    IntRect bounds() const override { return IntRect(); }
 };
 
 #if !(PLATFORM(IOS) || (PLATFORM(MAC) && ENABLE(VIDEO_PRESENTATION_MODE)))
index a70fd6d..8158d3d 100644 (file)
@@ -175,7 +175,7 @@ public:
     virtual std::optional<FloatRect> localBounds(const GraphicsContext&) const { return std::nullopt; }
 
 private:
-    virtual bool isDrawingItem() const { return true; }
+    bool isDrawingItem() const override { return true; }
 
     std::optional<FloatRect> m_extent; // In base coordinates, taking shadows and transforms into account.
 };
index 34dbcdb..1c50a77 100644 (file)
@@ -40,10 +40,10 @@ public:
                            unsigned colorArrayLength);
     void platformApplyNEON(unsigned char* srcPixelArrayA, unsigned char* srcPixelArrayB, unsigned char* dstPixelArray,
                            unsigned colorArrayLength);
-    virtual void platformApplySoftware();
-    virtual void dump();
+    void platformApplySoftware() override;
+    void dump() override;
 
-    virtual TextStream& externalRepresentation(TextStream&, int indention) const;
+    TextStream& externalRepresentation(TextStream&, int indention) const override;
 
 private:
     FEBlend(Filter&, BlendMode);
index 55efcc8..36d3a24 100644 (file)
@@ -47,10 +47,10 @@ public:
     const Vector<float>& values() const;
     bool setValues(const Vector<float>&);
 
-    virtual void platformApplySoftware();
-    virtual void dump();
+    void platformApplySoftware() override;
+    void dump() override;
 
-    virtual TextStream& externalRepresentation(TextStream&, int indention) const;
+    TextStream& externalRepresentation(TextStream&, int indention) const override;
 
     static inline void calculateSaturateComponents(float* components, float value);
     static inline void calculateHueRotateComponents(float* components, float value);
index a34f499..6619755 100644 (file)
@@ -77,10 +77,10 @@ public:
     ComponentTransferFunction alphaFunction() const;
     void setAlphaFunction(const ComponentTransferFunction&);
 
-    virtual void platformApplySoftware();
-    virtual void dump();
+    void platformApplySoftware() override;
+    void dump() override;
 
-    virtual TextStream& externalRepresentation(TextStream&, int indention) const;
+    TextStream& externalRepresentation(TextStream&, int indention) const override;
 
 private:
     FEComponentTransfer(Filter&, const ComponentTransferFunction& redFunc, const ComponentTransferFunction& greenFunc,
index 05d64aa..00141fa 100644 (file)
@@ -68,12 +68,12 @@ public:
     bool preserveAlpha() const;
     bool setPreserveAlpha(bool);
 
-    virtual void platformApplySoftware();
-    virtual void dump();
+    void platformApplySoftware() override;
+    void dump() override;
 
-    virtual void determineAbsolutePaintRect() { setAbsolutePaintRect(enclosingIntRect(maxEffectRect())); }
+    void determineAbsolutePaintRect() override { setAbsolutePaintRect(enclosingIntRect(maxEffectRect())); }
 
-    virtual TextStream& externalRepresentation(TextStream&, int indention) const;
+    TextStream& externalRepresentation(TextStream&, int indention) const override;
 
 private:
 
index 9374d7a..5fe2be9 100644 (file)
@@ -52,9 +52,9 @@ public:
     const LightSource* lightSource() const;
     void setLightSource(PassRefPtr<LightSource>);
 
-    virtual void dump();
+    void dump() override;
 
-    virtual TextStream& externalRepresentation(TextStream&, int indention) const;
+    TextStream& externalRepresentation(TextStream&, int indention) const override;
 
 private:
     FEDiffuseLighting(Filter&, const Color&, float, float, float, float, PassRefPtr<LightSource>);
index 9a5c491..36c9d74 100644 (file)
@@ -48,12 +48,12 @@ public:
     float shadowOpacity() const { return m_shadowOpacity; }
     void setShadowOpacity(float shadowOpacity) { m_shadowOpacity = shadowOpacity; }
 
-    virtual void platformApplySoftware();
-    virtual void dump();
+    void platformApplySoftware() override;
+    void dump() override;
 
-    virtual void determineAbsolutePaintRect();
+    void determineAbsolutePaintRect() override;
 
-    virtual TextStream& externalRepresentation(TextStream&, int indention) const;
+    TextStream& externalRepresentation(TextStream&, int indention) const override;
 
 private:
     FEDropShadow(Filter&, float, float, float, float, const Color&, float);
index ce2328c..0748a22 100644 (file)
@@ -41,14 +41,14 @@ public:
     EdgeModeType edgeMode() const;
     void setEdgeMode(EdgeModeType);
 
-    virtual void platformApplySoftware();
-    virtual void dump();
+    void platformApplySoftware() override;
+    void dump() override;
 
-    virtual void determineAbsolutePaintRect();
+    void determineAbsolutePaintRect() override;
     static IntSize calculateKernelSize(const Filter&, const FloatPoint& stdDeviation);
     static IntSize calculateUnscaledKernelSize(const FloatPoint& stdDeviation);
 
-    virtual TextStream& externalRepresentation(TextStream&, int indention) const;
+    TextStream& externalRepresentation(TextStream&, int indention) const override;
 
 private:
     static const int s_minimalRectDimension = 100 * 100; // Empirical data limit for parallel jobs
index 0d1c744..bafbf47 100644 (file)
@@ -43,9 +43,9 @@ struct FELightingPaintingDataForNeon;
 
 class FELighting : public FilterEffect {
 public:
-    virtual void platformApplySoftware();
+    void platformApplySoftware() override;
 
-    virtual void determineAbsolutePaintRect() { setAbsolutePaintRect(enclosingIntRect(maxEffectRect())); }
+    void determineAbsolutePaintRect() override { setAbsolutePaintRect(enclosingIntRect(maxEffectRect())); }
 
 protected:
     static const int s_minimalRectDimension = 100 * 100; // Empirical data limit for parallel jobs
index 929a13b..620f220 100644 (file)
@@ -31,10 +31,10 @@ class FEMerge : public FilterEffect {
 public:
     static Ref<FEMerge> create(Filter&);
 
-    virtual void platformApplySoftware();
-    virtual void dump();
+    void platformApplySoftware() override;
+    void dump() override;
 
-    virtual TextStream& externalRepresentation(TextStream&, int indention) const;
+    TextStream& externalRepresentation(TextStream&, int indention) const override;
 
 private:
     FEMerge(Filter&);
index e4637bf..050fc73 100644 (file)
@@ -46,12 +46,12 @@ public:
     float radiusY() const { return m_radiusY; }
     bool setRadiusY(float);
 
-    virtual void platformApplySoftware();
-    virtual void dump();
+    void platformApplySoftware() override;
+    void dump() override;
 
-    virtual void determineAbsolutePaintRect();
+    void determineAbsolutePaintRect() override;
 
-    virtual TextStream& externalRepresentation(TextStream&, int indention) const;
+    TextStream& externalRepresentation(TextStream&, int indention) const override;
 
     struct PaintingData {
         Uint8ClampedArray* srcPixelArray;
index bb62c78..f196d49 100644 (file)
@@ -37,12 +37,12 @@ public:
     float dy() const;
     void setDy(float);
 
-    virtual void platformApplySoftware();
-    virtual void dump();
+    void platformApplySoftware() override;
+    void dump() override;
     
-    virtual void determineAbsolutePaintRect();
+    void determineAbsolutePaintRect() override;
 
-    virtual TextStream& externalRepresentation(TextStream&, int indention) const;
+    TextStream& externalRepresentation(TextStream&, int indention) const override;
 
 private:
     FEOffset(Filter&, float dx, float dy);
index 9d67722..e04f443 100644 (file)
@@ -53,9 +53,9 @@ public:
     const LightSource* lightSource() const;
     void setLightSource(PassRefPtr<LightSource>);
 
-    virtual void dump();
+    void dump() override;
 
-    virtual TextStream& externalRepresentation(TextStream&, int indention) const;
+    TextStream& externalRepresentation(TextStream&, int indention) const override;
 
 private:
     FESpecularLighting(Filter&, const Color&, float, float, float, float, float, PassRefPtr<LightSource>);
index b280076..c264cef 100644 (file)
@@ -31,14 +31,14 @@ class FETile : public FilterEffect {
 public:
     static Ref<FETile> create(Filter&);
 
-    virtual void platformApplySoftware();
-    virtual void dump();
+    void platformApplySoftware() override;
+    void dump() override;
 
-    virtual void determineAbsolutePaintRect() { setAbsolutePaintRect(enclosingIntRect(maxEffectRect())); }
+    void determineAbsolutePaintRect() override { setAbsolutePaintRect(enclosingIntRect(maxEffectRect())); }
 
-    virtual FilterEffectType filterEffectType() const { return FilterEffectTypeTile; }
+    FilterEffectType filterEffectType() const override { return FilterEffectTypeTile; }
 
-    virtual TextStream& externalRepresentation(TextStream&, int indention) const;
+    TextStream& externalRepresentation(TextStream&, int indention) const override;
 
 private:
     FETile(Filter&);
index cb4aea4..4987e3d 100644 (file)
@@ -59,12 +59,12 @@ public:
 
     static void fillRegionWorker(void*);
 
-    virtual void platformApplySoftware();
-    virtual void dump();
+    void platformApplySoftware() override;
+    void dump() override;
     
-    virtual void determineAbsolutePaintRect() { setAbsolutePaintRect(enclosingIntRect(maxEffectRect())); }
+    void determineAbsolutePaintRect() override { setAbsolutePaintRect(enclosingIntRect(maxEffectRect())); }
 
-    virtual TextStream& externalRepresentation(TextStream&, int indention) const;
+    TextStream& externalRepresentation(TextStream&, int indention) const override;
 
 private:
     static const int s_blockSize = 256;
index cab56ab..deef324 100644 (file)
@@ -31,14 +31,14 @@ public:
 
     static const AtomicString& effectName();
 
-    virtual void platformApplySoftware();
-    virtual void dump();
+    void platformApplySoftware() override;
+    void dump() override;
 
-    virtual void determineAbsolutePaintRect();
+    void determineAbsolutePaintRect() override;
 
-    virtual FilterEffectType filterEffectType() const { return FilterEffectTypeSourceInput; }
+    FilterEffectType filterEffectType() const override { return FilterEffectTypeSourceInput; }
 
-    virtual TextStream& externalRepresentation(TextStream&, int indention) const;
+    TextStream& externalRepresentation(TextStream&, int indention) const override;
 
 private:
     explicit SourceAlpha(FilterEffect&);
index 3969fc6..3ffd249 100644 (file)
@@ -32,14 +32,14 @@ public:
 
     static const AtomicString& effectName();
 
-    virtual void platformApplySoftware();
-    virtual void dump();
+    void platformApplySoftware() override;
+    void dump() override;
 
-    virtual void determineAbsolutePaintRect();
+    void determineAbsolutePaintRect() override;
 
-    virtual FilterEffectType filterEffectType() const { return FilterEffectTypeSourceInput; }
+    FilterEffectType filterEffectType() const override { return FilterEffectTypeSourceInput; }
 
-    virtual TextStream& externalRepresentation(TextStream&, int indention) const;
+    TextStream& externalRepresentation(TextStream&, int indention) const override;
 
 private:
     SourceGraphic(Filter& filter)
index 7d7221a..a81e5b8 100644 (file)
@@ -41,25 +41,25 @@ public:
     virtual ~Extensions3DOpenGL();
 
     // Extensions3D methods.
-    virtual void blitFramebuffer(long srcX0, long srcY0, long srcX1, long srcY1, long dstX0, long dstY0, long dstX1, long dstY1, unsigned long mask, unsigned long filter);
-    virtual void renderbufferStorageMultisample(unsigned long target, unsigned long samples, unsigned long internalformat, unsigned long width, unsigned long height);
+    void blitFramebuffer(long srcX0, long srcY0, long srcX1, long srcY1, long dstX0, long dstY0, long dstX1, long dstY1, unsigned long mask, unsigned long filter) override;
+    void renderbufferStorageMultisample(unsigned long target, unsigned long samples, unsigned long internalformat, unsigned long width, unsigned long height) override;
 
-    virtual Platform3DObject createVertexArrayOES();
-    virtual void deleteVertexArrayOES(Platform3DObject);
-    virtual GC3Dboolean isVertexArrayOES(Platform3DObject);
-    virtual void bindVertexArrayOES(Platform3DObject);
-    virtual void insertEventMarkerEXT(const String&);
-    virtual void pushGroupMarkerEXT(const String&);
-    virtual void popGroupMarkerEXT(void);
-    virtual void drawBuffersEXT(GC3Dsizei, const GC3Denum*);
+    Platform3DObject createVertexArrayOES() override;
+    void deleteVertexArrayOES(Platform3DObject) override;
+    GC3Dboolean isVertexArrayOES(Platform3DObject) override;
+    void bindVertexArrayOES(Platform3DObject) override;
+    void insertEventMarkerEXT(const String&) override;
+    void pushGroupMarkerEXT(const String&) override;
+    void popGroupMarkerEXT(void) override;
+    void drawBuffersEXT(GC3Dsizei, const GC3Denum*) override;
 
-    virtual void drawArraysInstanced(GC3Denum mode, GC3Dint first, GC3Dsizei count, GC3Dsizei primcount);
-    virtual void drawElementsInstanced(GC3Denum mode, GC3Dsizei count, GC3Denum type, long long offset, GC3Dsizei primcount);
-    virtual void vertexAttribDivisor(GC3Duint index, GC3Duint divisor);
+    void drawArraysInstanced(GC3Denum mode, GC3Dint first, GC3Dsizei count, GC3Dsizei primcount) override;
+    void drawElementsInstanced(GC3Denum mode, GC3Dsizei count, GC3Denum type, long long offset, GC3Dsizei primcount) override;
+    void vertexAttribDivisor(GC3Duint index, GC3Duint divisor) override;
 
 protected:
-    virtual bool supportsExtension(const WTF::String&);
-    virtual String getExtensions();
+    bool supportsExtension(const WTF::String&) override;
+    String getExtensions() override;
 
 private:
 #if (PLATFORM(GTK) || PLATFORM(EFL) || PLATFORM(WIN) || PLATFORM(IOS))
index a9d2ccc..7c614fb 100644 (file)
@@ -39,33 +39,33 @@ public:
     virtual ~Extensions3DOpenGLCommon();
 
     // Extensions3D methods.
-    virtual bool supports(const String&);
-    virtual void ensureEnabled(const String&);
-    virtual bool isEnabled(const String&);
-    virtual int getGraphicsResetStatusARB();
+    bool supports(const String&) override;
+    void ensureEnabled(const String&) override;
+    bool isEnabled(const String&) override;
+    int getGraphicsResetStatusARB() override;
 
-    virtual Platform3DObject createVertexArrayOES() = 0;
-    virtual void deleteVertexArrayOES(Platform3DObject) = 0;
-    virtual GC3Dboolean isVertexArrayOES(Platform3DObject) = 0;
-    virtual void bindVertexArrayOES(Platform3DObject) = 0;
+    Platform3DObject createVertexArrayOES() override = 0;
+    void deleteVertexArrayOES(Platform3DObject) override = 0;
+    GC3Dboolean isVertexArrayOES(Platform3DObject) override = 0;
+    void bindVertexArrayOES(Platform3DObject) override = 0;
 
-    virtual void drawBuffersEXT(GC3Dsizei, const GC3Denum*) = 0;
+    void drawBuffersEXT(GC3Dsizei, const GC3Denum*) override = 0;
 
-    virtual String getTranslatedShaderSourceANGLE(Platform3DObject);
+    String getTranslatedShaderSourceANGLE(Platform3DObject) override;
 
     // EXT Robustness - uses getGraphicsResetStatusARB()
-    virtual void readnPixelsEXT(int x, int y, GC3Dsizei width, GC3Dsizei height, GC3Denum format, GC3Denum type, GC3Dsizei bufSize, void *data);
-    virtual void getnUniformfvEXT(GC3Duint program, int location, GC3Dsizei bufSize, float *params);
-    virtual void getnUniformivEXT(GC3Duint program, int location, GC3Dsizei bufSize, int *params);
-
-    virtual bool isNVIDIA() { return m_isNVIDIA; }
-    virtual bool isAMD() { return m_isAMD; }
-    virtual bool isIntel() { return m_isIntel; }
-    virtual bool isImagination() { return m_isImagination; }
-    virtual String vendor() { return m_vendor; }
-
-    virtual bool requiresBuiltInFunctionEmulation() { return m_requiresBuiltInFunctionEmulation; }
-    virtual bool requiresRestrictedMaximumTextureSize() { return m_requiresRestrictedMaximumTextureSize; }
+    void readnPixelsEXT(int x, int y, GC3Dsizei width, GC3Dsizei height, GC3Denum format, GC3Denum type, GC3Dsizei bufSize, void *data) override;
+    void getnUniformfvEXT(GC3Duint program, int location, GC3Dsizei bufSize, float *params) override;
+    void getnUniformivEXT(GC3Duint program, int location, GC3Dsizei bufSize, int *params) override;
+
+    bool isNVIDIA() override { return m_isNVIDIA; }
+    bool isAMD() override { return m_isAMD; }
+    bool isIntel() override { return m_isIntel; }
+    bool isImagination() override { return m_isImagination; }
+    String vendor() override { return m_vendor; }
+
+    bool requiresBuiltInFunctionEmulation() override { return m_requiresBuiltInFunctionEmulation; }
+    bool requiresRestrictedMaximumTextureSize() override { return m_requiresRestrictedMaximumTextureSize; }
 
 protected:
     friend class Extensions3DOpenGLES;
index cf0b07d..f42adef 100644 (file)
@@ -37,7 +37,7 @@ class GraphicsLayer;
 class TextureMapperBackingStore : public TextureMapperPlatformLayer, public RefCounted<TextureMapperBackingStore> {
 public:
     virtual RefPtr<BitmapTexture> texture() const = 0;
-    virtual void paintToTextureMapper(TextureMapper&, const FloatRect&, const TransformationMatrix&, float) = 0;
+    void paintToTextureMapper(TextureMapper&, const FloatRect&, const TransformationMatrix&, float) override = 0;
     virtual void drawRepaintCounter(TextureMapper&, int /* repaintCount */, const Color&, const FloatRect&, const TransformationMatrix&) { }
     virtual ~TextureMapperBackingStore() { }
 
index 588ca2b..b9899f1 100644 (file)
@@ -72,8 +72,8 @@ RealtimeMediaSourceOwr(const String& id, RealtimeMediaSource::Type type, const S
         setMuted(false);
     }
 
-    virtual RefPtr<RealtimeMediaSourceCapabilities> capabilities() const { return m_capabilities; }
-    virtual const RealtimeMediaSourceSettings& settings() const;
+    RefPtr<RealtimeMediaSourceCapabilities> capabilities() const override { return m_capabilities; }
+    const RealtimeMediaSourceSettings& settings() const override;
 
     OwrMediaSource* mediaSource() const { return m_mediaSource; }
 
index 8ceeb19..b139877 100644 (file)
@@ -60,13 +60,13 @@ public:
     int numberOfPendingPermissionRequests() const;
 
     // GeolocationClient
-    virtual void geolocationDestroyed();
-    virtual void startUpdating();
-    virtual void stopUpdating();
-    virtual void setEnableHighAccuracy(bool);
-    virtual GeolocationPosition* lastPosition();
-    virtual void requestPermission(Geolocation*);
-    virtual void cancelPermissionRequest(Geolocation*);
+    void geolocationDestroyed() override;
+    void startUpdating() override;
+    void stopUpdating() override;
+    void setEnableHighAccuracy(bool) override;
+    GeolocationPosition* lastPosition() override;
+    void requestPermission(Geolocation*) override;
+    void cancelPermissionRequest(Geolocation*) override;
 
 private:
     void asyncUpdateController();
index 8f7d673..0c1798c 100644 (file)
@@ -46,8 +46,8 @@ namespace WebCore {
         virtual ~TextCodecICU();
 
     private:
-        virtual String decode(const char*, size_t length, bool flush, bool stopOnError, bool& sawError);
-        virtual CString encode(const UChar*, size_t length, UnencodableHandling);
+        String decode(const char*, size_t length, bool flush, bool stopOnError, bool& sawError) override;
+        CString encode(const UChar*, size_t length, UnencodableHandling) override;
 
         void createICUConverter() const;
         void releaseICUConverter() const;
index 2e3862f..9d08aa3 100644 (file)
@@ -35,8 +35,8 @@ namespace WebCore {
         static void registerEncodingNames(EncodingNameRegistrar);
         static void registerCodecs(TextCodecRegistrar);
 
-        virtual String decode(const char*, size_t length, bool flush, bool stopOnError, bool& sawError);
-        virtual CString encode(const UChar*, size_t length, UnencodableHandling);
+        String decode(const char*, size_t length, bool flush, bool stopOnError, bool& sawError) override;
+        CString encode(const UChar*, size_t length, UnencodableHandling) override;
     };
 
 } // namespace WebCore
index 57831b0..28760cd 100644 (file)
@@ -37,8 +37,8 @@ namespace WebCore {
 
         TextCodecUTF16(bool littleEndian) : m_littleEndian(littleEndian), m_haveBufferedByte(false) { }
 
-        virtual String decode(const char*, size_t length, bool flush, bool stopOnError, bool& sawError);
-        virtual CString encode(const UChar*, size_t length, UnencodableHandling);
+        String decode(const char*, size_t length, bool flush, bool stopOnError, bool& sawError) override;
+        CString encode(const UChar*, size_t length, UnencodableHandling) override;
 
     private:
         bool m_littleEndian;
index 94305ce..590fd5c 100644 (file)
@@ -42,8 +42,8 @@ public:
     static void registerCodecs(TextCodecRegistrar);
 
 private:
-    virtual String decode(const char*, size_t length, bool flush, bool stopOnError, bool& sawError);
-    virtual CString encode(const UChar*, size_t length, UnencodableHandling);
+    String decode(const char*, size_t length, bool flush, bool stopOnError, bool& sawError) override;
+    CString encode(const UChar*, size_t length, UnencodableHandling) override;
 
     template <typename CharType>
     bool handlePartialSequence(CharType*& destination, const uint8_t*& source, const uint8_t* end, bool flush, bool stopOnError, bool& sawError);
index af6149e..5821ca3 100644 (file)
@@ -35,8 +35,8 @@ namespace WebCore {
         static void registerEncodingNames(EncodingNameRegistrar);
         static void registerCodecs(TextCodecRegistrar);
 
-        virtual String decode(const char*, size_t length, bool flush, bool stopOnError, bool& sawError);
-        virtual CString encode(const UChar*, size_t length, UnencodableHandling);
+        String decode(const char*, size_t length, bool flush, bool stopOnError, bool& sawError) override;
+        CString encode(const UChar*, size_t length, UnencodableHandling) override;
     };
 
 } // namespace WebCore
index 326479e..afacfbc 100644 (file)
@@ -43,8 +43,8 @@ public:
     }
 
 private:
-    virtual bool isRenderFullScreenPlaceholder() const { return true; }
-    virtual void willBeDestroyed();
+    bool isRenderFullScreenPlaceholder() const override { return true; }
+    void willBeDestroyed() override;
     RenderFullScreen& m_owner;
 };
 
index 09c2fce..ac18aac 100644 (file)
@@ -59,7 +59,7 @@ public:
     // Needed once we support init<blank>EventNS
     // void initStorageEventNS(in DOMString namespaceURI, in DOMString typeArg, in boolean canBubbleArg, in boolean cancelableArg, in DOMString keyArg, in DOMString oldValueArg, in DOMString newValueArg, in DOMString urlArg, Storage storageAreaArg);
 
-    virtual EventInterface eventInterface() const;
+    EventInterface eventInterface() const override;
 
 private:
     StorageEvent();
index d6b99af..9b0d420 100644 (file)
@@ -470,7 +470,7 @@ protected:
             delete m_values;
     }
 
-    virtual void commitChange() = 0;
+    void commitChange() override = 0;
     virtual void commitChange(ListModification)
     {
         commitChange();
index b192e67..786874d 100644 (file)
@@ -82,24 +82,24 @@ protected:
     {
     }
 
-    virtual bool isReadOnly() const
+    bool isReadOnly() const override
     {
         return m_role == AnimValRole;
     }
 
-    virtual void commitChange()
+    void commitChange() override
     {
         ASSERT(m_values);
         m_values->commitChange(m_contextElement);
     }
 
-    virtual bool processIncomingListItemValue(const ListItemType&, unsigned*)
+    bool processIncomingListItemValue(const ListItemType&, unsigned*) override
     {
         // no-op for static lists
         return true;
     }
 
-    virtual bool processIncomingListItemWrapper(Ref<ListItemTearOff>&, unsigned*)
+    bool processIncomingListItemWrapper(Ref<ListItemTearOff>&, unsigned*) override
     {
         ASSERT_NOT_REACHED();
         return true;
index f1106d7..5e2ca09 100644 (file)
@@ -41,7 +41,7 @@ public:
         return adoptRef(*new Self(contextElement, value, update));
     }
 
-    virtual void commitChange() { (m_contextElement.get()->*m_update)(); }
+    void commitChange() final { (m_contextElement.get()->*m_update)(); }
 
 private:
     SVGStaticPropertyTearOff(ContextElement& contextElement, PropertyType& value, UpdateMethod update)
index 9d32b3b..0264207 100644 (file)
@@ -37,7 +37,7 @@ public:
     static Ref<NativeXPathNSResolver> create(RefPtr<Node>&& node) { return adoptRef(*new NativeXPathNSResolver(WTFMove(node))); }
     virtual ~NativeXPathNSResolver();
 
-    virtual String lookupNamespaceURI(const String& prefix);
+    String lookupNamespaceURI(const String& prefix) override;
 
 private:
     explicit NativeXPathNSResolver(RefPtr<Node>&&);
index 755b2a7..c0aeddd 100644 (file)
@@ -40,7 +40,7 @@ public:
     unsigned long long position() const { return loaded(); }
     unsigned long long totalSize() const { return total(); }
 
-    virtual EventInterface eventInterface() const { return XMLHttpRequestProgressEventInterfaceType; }
+    EventInterface eventInterface() const override { return XMLHttpRequestProgressEventInterfaceType; }
 
 private:
     XMLHttpRequestProgressEvent(const AtomicString& type, bool lengthComputable, unsigned long long loaded, unsigned long long total)
index 971bd23..781d6ec 100644 (file)
@@ -57,7 +57,7 @@ public:
 private:
     static const double minimumProgressEventDispatchingIntervalInSeconds;
 
-    virtual void fired();
+    void fired() override;
     void dispatchDeferredEvents();
     void flushProgressEvent();
     void dispatchEvent(Event&);
index b95b373..dc6e74e 100644 (file)
@@ -35,8 +35,8 @@ namespace WebCore {
         public:
             explicit VariableReference(const String& name);
         private:
-            virtual Value evaluate() const;
-            virtual Value::Type resultType() const { ASSERT_NOT_REACHED(); return Value::NumberValue; }
+            Value evaluate() const override;
+            Value::Type resultType() const override { ASSERT_NOT_REACHED(); return Value::NumberValue; }
             String m_name;
         };
 
index 0392e13..f3f9ffe 100644 (file)
@@ -48,7 +48,7 @@ public:
     void loadSheet();
     
 private:
-    virtual void setXSLStyleSheet(const String& href, const URL& baseURL, const String& sheet);
+    void setXSLStyleSheet(const String& href, const URL& baseURL, const String& sheet) override;
     
     XSLStyleSheet* m_parentStyleSheet;
     String m_strHref;
index 8d03f48..3e36e7d 100644 (file)
@@ -1,3 +1,21 @@
+2016-12-15  Konstantin Tokarev  <annulen@yandex.ru>
+
+        Added missing override and final specifiers
+        https://bugs.webkit.org/show_bug.cgi?id=165903
+
+        Reviewed by Darin Adler.
+
+        * UIProcess/API/gtk/WebKitGeolocationProvider.h:
+        * UIProcess/WebFormSubmissionListenerProxy.h:
+        * UIProcess/WebFramePolicyListenerProxy.h:
+        * WebProcess/Automation/WebAutomationSessionProxy.h:
+        * WebProcess/InjectedBundle/API/gtk/DOM/GObjectXPathNSResolver.h:
+        * WebProcess/MediaCache/WebMediaKeyStorageManager.h:
+        * WebProcess/Plugins/Netscape/NPRuntimeObjectMap.h:
+        * WebProcess/WebCoreSupport/WebPlugInClient.h:
+        * WebProcess/WebCoreSupport/soup/WebFrameNetworkingContext.h:
+        * WebProcess/WebPage/FindController.h:
+
 2016-12-15  Simon Fraser  <simon.fraser@apple.com>
 
         [iOS WK2] Don't disable position:fixed when a form element has focus
index 677bac2..e18dc56 100644 (file)
@@ -42,8 +42,8 @@ private:
     WebKitGeolocationProvider(WebGeolocationManagerProxy*);
 
     // GeolocationProviderGeoclueClient interface.
-    virtual void notifyPositionChanged(int, double, double, double, double, double);
-    virtual void notifyErrorOccurred(const char*);
+    void notifyPositionChanged(int, double, double, double, double, double) override;
+    void notifyErrorOccurred(const char*) override;
 
     RefPtr<WebGeolocationManagerProxy> m_geolocationManager;
     WebCore::GeolocationProviderGeoclue m_provider;
index 70bac5e..f6f6ec3 100644 (file)
@@ -52,7 +52,7 @@ public:
 private:
     WebFormSubmissionListenerProxy(WebFrameProxy*, uint64_t listenerID);
 
-    virtual Type type() const { return APIType; }
+    Type type() const override { return APIType; }
 
 #if DELEGATE_REF_COUNTING_TO_COCOA
     void* operator new(size_t size) { return newObject(size, APIType); }
index 071644b..379efd2 100644 (file)
@@ -51,7 +51,7 @@ public:
 private:
     WebFramePolicyListenerProxy(WebFrameProxy*, uint64_t listenerID);
 
-    virtual Type type() const { return APIType; }
+    Type type() const override { return APIType; }
 
 #if DELEGATE_REF_COUNTING_TO_COCOA
     void* operator new(size_t size) { return newObject(size, APIType); }
index fda756c..18d4038 100644 (file)
@@ -55,7 +55,7 @@ private:
     WebCore::Element* elementForNodeHandle(WebFrame&, const String&);
 
     // Implemented in generated WebAutomationSessionProxyMessageReceiver.cpp
-    void didReceiveMessage(IPC::Connection&, IPC::Decoder&);
+    void didReceiveMessage(IPC::Connection&, IPC::Decoder&) override;
 
     // Called by WebAutomationSessionProxy messages
     void evaluateJavaScriptFunction(uint64_t pageID, uint64_t frameID, const String& function, Vector<String> arguments, bool expectsImplicitCallbackArgument, int callbackTimeout, uint64_t callbackID);
index 3e5cc6f..0dd5a5d 100644 (file)
@@ -33,7 +33,7 @@ public:
     }
 
     virtual ~GObjectXPathNSResolver();
-    virtual String lookupNamespaceURI(const String& prefix);
+    String lookupNamespaceURI(const String& prefix) override;
 
 private:
     GObjectXPathNSResolver(WebKitDOMXPathNSResolver* resolver)
index fcc0f4d..ef746fe 100644 (file)
@@ -55,7 +55,7 @@ public:
     void deleteAllMediaKeyEntries();
 
 private:
-    virtual void initialize(const WebProcessCreationParameters&);
+    void initialize(const WebProcessCreationParameters&) override;
 
     String m_mediaKeyStorageDirectory;
 };
index fade41d..85509ab 100644 (file)
@@ -90,7 +90,7 @@ public:
 
 private:
     // WeakHandleOwner
-    virtual void finalize(JSC::Handle<JSC::Unknown>, void* context);
+    void finalize(JSC::Handle<JSC::Unknown>, void* context) override;
     void addToInvalidationQueue(NPObject*);
     void invalidateQueuedObjects();
 
index 5e75a00..93f9698 100644 (file)
@@ -39,9 +39,9 @@ public:
     virtual ~WebPlugInClient();
 
 private:
-    virtual void pageDestroyed();
-    virtual bool shouldAutoStartFromOrigin(const String& pageOrigin, const String& pluginOrigin, const String& mimeType);
-    virtual void didStartFromOrigin(const String& pageOrigin, const String& pluginOrigin, const String& mimeType, WebCore::SessionID);
+    void pageDestroyed() override;
+    bool shouldAutoStartFromOrigin(const String& pageOrigin, const String& pluginOrigin, const String& mimeType) override;
+    void didStartFromOrigin(const String& pageOrigin, const String& pluginOrigin, const String& mimeType, WebCore::SessionID) override;
 
     WebPage& m_webPage;
 };
index aed1b59..2c6eea7 100644 (file)
@@ -52,7 +52,7 @@ public:
 private:
     WebFrameNetworkingContext(WebFrame*);
 
-    virtual WebCore::NetworkStorageSession& storageSession() const;
+    WebCore::NetworkStorageSession& storageSession() const override;
 };
 
 }
index f30a46a..7ec0d5a 100644 (file)
@@ -73,10 +73,10 @@ public:
 
 private:
     // PageOverlay::Client.
-    virtual void willMoveToPage(WebCore::PageOverlay&, WebCore::Page*);
-    virtual void didMoveToPage(WebCore::PageOverlay&, WebCore::Page*);
-    virtual bool mouseEvent(WebCore::PageOverlay&, const WebCore::PlatformMouseEvent&);
-    virtual void drawRect(WebCore::PageOverlay&, WebCore::GraphicsContext&, const WebCore::IntRect& dirtyRect);
+    void willMoveToPage(WebCore::PageOverlay&, WebCore::Page*) override;
+    void didMoveToPage(WebCore::PageOverlay&, WebCore::Page*) override;
+    bool mouseEvent(WebCore::PageOverlay&, const WebCore::PlatformMouseEvent&) override;
+    void drawRect(WebCore::PageOverlay&, WebCore::GraphicsContext&, const WebCore::IntRect& dirtyRect) override;
 
     Vector<WebCore::IntRect> rectsForTextMatchesInRect(WebCore::IntRect clipRect);
     bool updateFindIndicator(WebCore::Frame& selectedFrame, bool isShowingOverlay, bool shouldAnimate = true);