Unreviewed, rolling out r219257.
authorjlewis3@apple.com <jlewis3@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 7 Jul 2017 20:05:27 +0000 (20:05 +0000)
committerjlewis3@apple.com <jlewis3@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 7 Jul 2017 20:05:27 +0000 (20:05 +0000)
The test added in the revision was still extreamly flaky on
all testers.

Reverted changeset:

"[SVG] Leak in SVGAnimatedListPropertyTearOff"
https://bugs.webkit.org/show_bug.cgi?id=172545
http://trac.webkit.org/changeset/219257

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@219264 268f45cc-cd09-0410-ab3c-d52691b4dbfc

LayoutTests/ChangeLog
LayoutTests/svg/animations/animation-leak-list-property-instances-expected.txt [deleted file]
LayoutTests/svg/animations/animation-leak-list-property-instances.html [deleted file]
Source/WebCore/ChangeLog
Source/WebCore/svg/properties/SVGAnimatedListPropertyTearOff.h

index 90f32b7..45620a0 100644 (file)
@@ -1,3 +1,16 @@
+2017-07-07  Matt Lewis  <jlewis3@apple.com>
+
+        Unreviewed, rolling out r219257.
+
+        The test added in the revision was still extreamly flaky on
+        all testers.
+
+        Reverted changeset:
+
+        "[SVG] Leak in SVGAnimatedListPropertyTearOff"
+        https://bugs.webkit.org/show_bug.cgi?id=172545
+        http://trac.webkit.org/changeset/219257
+
 2017-07-07  Mark Lam  <mark.lam@apple.com>
 
         \n\r is not the same as \r\n.
diff --git a/LayoutTests/svg/animations/animation-leak-list-property-instances-expected.txt b/LayoutTests/svg/animations/animation-leak-list-property-instances-expected.txt
deleted file mode 100644 (file)
index 47c838b..0000000
+++ /dev/null
@@ -1,2 +0,0 @@
-PASS: all nodes were properly removed.
-
diff --git a/LayoutTests/svg/animations/animation-leak-list-property-instances.html b/LayoutTests/svg/animations/animation-leak-list-property-instances.html
deleted file mode 100644 (file)
index 9b1f1d9..0000000
+++ /dev/null
@@ -1,72 +0,0 @@
-<!DOCTYPE html>
-<script>
-
- var xmlns = "http://www.w3.org/2000/svg";
-
- function log(message) {
-     var logDiv = document.getElementById('log');
-     logDiv.appendChild(document.createTextNode(message));
- }
-
- function addRect()
- {
-     var elem = document.createElementNS(xmlns, "rect");
-     elem.setAttributeNS(null,"id", "rect");
-     elem.setAttributeNS(null,"x",50);
-     elem.setAttributeNS(null,"y",50);
-     elem.setAttributeNS(null,"width",50);
-     elem.setAttributeNS(null,"height",50);
-     elem.setAttributeNS(null,"fill", "blue");
-
-     document.getElementById("rootSVG").appendChild(elem);
- }
-
- function applyTransform()
- {
-     var svgroot = document.getElementById("rootSVG");
-     var transformList = document.getElementById("rect").transform.baseVal;
-     var rotate = svgroot.createSVGTransform();
-     rotate.setRotate(15,0,0);
-     transformList.appendItem(rotate);
- }
-
- function removeRect()
- {
-     document.getElementById("rootSVG").removeChild(document.getElementById("rect"));
- }
-
- var originalLiveElements = 0;
-
- function test()
- {
-     if (!window.testRunner) {
-         log("This test requires testRunner");
-         return;
-     }
-
-     testRunner.dumpAsText();
-     testRunner.waitUntilDone();
-
-     GCController.collect();
-     originalLiveElements = window.internals.numberOfLiveNodes();
-
-     addRect();
-     applyTransform();
-     removeRect();
-
-     GCController.collect();
-     var delta = window.internals.numberOfLiveNodes() - originalLiveElements;
-     if (delta == 0)
-         log("PASS: all nodes were properly removed.");
-     else
-         log("FAIL: " + delta + " nodes leaked.")
-
-     testRunner.notifyDone();
- }
-</script>
-
-<body onload="test()">
-    <div id="log"></div>
-    <svg id="rootSVG" width="300" height="300" xmlns="http://www.w3.org/2000/svg" version="1.1">
-    </svg>
-</body>
index 417ddb5..a630c1f 100644 (file)
@@ -1,3 +1,16 @@
+2017-07-07  Matt Lewis  <jlewis3@apple.com>
+
+        Unreviewed, rolling out r219257.
+
+        The test added in the revision was still extreamly flaky on
+        all testers.
+
+        Reverted changeset:
+
+        "[SVG] Leak in SVGAnimatedListPropertyTearOff"
+        https://bugs.webkit.org/show_bug.cgi?id=172545
+        http://trac.webkit.org/changeset/219257
+
 2017-07-07  Commit Queue  <commit-queue@webkit.org>
 
         Unreviewed, rolling out r219238, r219239, and r219241.
index bfa8e13..0ce9937 100644 (file)
@@ -73,8 +73,6 @@ public:
             m_baseVal = nullptr;
         else if (&property == m_animVal)
             m_animVal = nullptr;
-        if (!m_baseVal && !m_animVal)
-            detachListWrappers(m_values.size());
     }
 
     int findItem(SVGProperty* property)