Missed images and missed new lines in the expected results of the imported w3c canvas...
authorcommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 13 Jan 2015 23:49:33 +0000 (23:49 +0000)
committercommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 13 Jan 2015 23:49:33 +0000 (23:49 +0000)
https://bugs.webkit.org/show_bug.cgi?id=140409.

Patch by Said Abou-Hallawa <sabouhallawa@apple.com> on 2015-01-13
Reviewed by Dean Jackson.
LayoutTests/imported/w3c:

Fix some failures in the imported W3C canvas tests. These failures were happening because
of missing images or missing new lines at the end of the expected results.

* canvas/2d.pattern.paint.repeat.basic-expected.txt:
* canvas/2d.pattern.paint.repeat.outside-expected.txt:
* canvas/2d.pattern.paint.repeatx.basic-expected.txt:
* canvas/2d.pattern.paint.repeaty.basic-expected.txt:
* canvas/resources/background.png: Added.
* canvas/resources/green-16x16.png: Added.
* common/canvas-tests.css:

LayoutTests:

Fix some failures in the imported W3C canvas tests. These failures were happening because
of missing images or missing new lines at the end of the expected results.

* TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@178386 268f45cc-cd09-0410-ab3c-d52691b4dbfc

LayoutTests/ChangeLog
LayoutTests/TestExpectations
LayoutTests/imported/w3c/ChangeLog
LayoutTests/imported/w3c/canvas/2d.pattern.paint.repeat.basic-expected.txt
LayoutTests/imported/w3c/canvas/2d.pattern.paint.repeat.outside-expected.txt
LayoutTests/imported/w3c/canvas/2d.pattern.paint.repeatx.basic-expected.txt
LayoutTests/imported/w3c/canvas/2d.pattern.paint.repeaty.basic-expected.txt
LayoutTests/imported/w3c/canvas/resources/background.png [new file with mode: 0644]
LayoutTests/imported/w3c/canvas/resources/green-16x16.png [new file with mode: 0644]
LayoutTests/imported/w3c/common/canvas-tests.css

index f861f47..7698582 100644 (file)
@@ -1,3 +1,15 @@
+2015-01-13  Said Abou-Hallawa  <sabouhallawa@apple.com>
+
+        Missed images and missed new lines in the expected results of the imported w3c canvas layout tests.
+        https://bugs.webkit.org/show_bug.cgi?id=140409.
+
+        Reviewed by Dean Jackson.
+        
+        Fix some failures in the imported W3C canvas tests. These failures were happening because
+        of missing images or missing new lines at the end of the expected results.
+
+        * TestExpectations:
+
 2015-01-13  Dean Jackson  <dino@apple.com>
 
         Filters aren't applied to elements in columns after the first
index 6c58279..7dfadf7 100644 (file)
@@ -225,7 +225,6 @@ webkit.org/b/137883 transitions/transition-shorthand-delay.html
 webkit.org/b/137883 transitions/transition-timing-function.html [ Pass Failure ]
 
 # Imported W3C canvas failed tests
-webkit.org/b/138676 imported/w3c/canvas/2d.pattern.paint.repeaty.basic.html [ Failure ]
 webkit.org/b/138676 imported/w3c/canvas/2d.pattern.image.null.html [ Failure ]
 webkit.org/b/138676 imported/w3c/canvas/2d.pattern.image.incomplete.omitted.html [ Failure ]
 webkit.org/b/138676 imported/w3c/canvas/2d.drawImage.null.html [ Failure ]
@@ -239,14 +238,12 @@ webkit.org/b/138676 imported/w3c/canvas/2d.drawImage.animated.poster.html [ Fail
 webkit.org/b/138676 imported/w3c/canvas/2d.fillStyle.parse.rgb-eof.html [ Failure ]
 webkit.org/b/138676 imported/w3c/canvas/2d.imageData.put.null.html [ Failure ]
 webkit.org/b/138676 imported/w3c/canvas/security.pattern.image.strokeStyle.html [ Failure ]
-webkit.org/b/138676 imported/w3c/canvas/2d.pattern.paint.repeat.basic.html [ Failure ]
 webkit.org/b/138676 imported/w3c/canvas/2d.imageData.get.nonfinite.html [ Failure ]
 webkit.org/b/138676 imported/w3c/canvas/2d.line.cap.round.html [ Failure ]
 webkit.org/b/138676 imported/w3c/canvas/2d.gradient.object.invalidoffset.html [ Failure ]
 webkit.org/b/138676 imported/w3c/canvas/security.pattern.canvas.strokeStyle.html [ Failure ]
 webkit.org/b/138676 imported/w3c/canvas/2d.gradient.radial.nonfinite.html [ Failure ]
 webkit.org/b/138676 imported/w3c/canvas/2d.imageData.object.ctor.html [ Failure ]
-webkit.org/b/138676 imported/w3c/canvas/2d.pattern.paint.repeatx.basic.html [ Failure ]
 webkit.org/b/138676 imported/w3c/canvas/2d.drawImage.incomplete.html [ Failure ]
 webkit.org/b/138676 imported/w3c/canvas/2d.imageData.create2.nonfinite.html [ Failure ]
 webkit.org/b/138676 imported/w3c/canvas/2d.composite.operation.clear.html [ Failure ]
@@ -255,7 +252,6 @@ webkit.org/b/138676 imported/w3c/canvas/security.drawImage.image.html [ Failure
 webkit.org/b/138676 imported/w3c/canvas/2d.drawImage.broken.html [ Failure ]
 webkit.org/b/138676 imported/w3c/canvas/2d.imageData.create1.zero.html [ Failure ]
 webkit.org/b/138676 imported/w3c/canvas/2d.gradient.linear.nonfinite.html [ Failure ]
-webkit.org/b/138676 imported/w3c/canvas/2d.pattern.paint.repeat.outside.html [ Failure ]
 webkit.org/b/138676 imported/w3c/canvas/2d.fillStyle.parse.rgba-eof.html [ Failure ]
 webkit.org/b/138676 imported/w3c/canvas/security.drawImage.canvas.html [ Failure ]
 webkit.org/b/138676 imported/w3c/canvas/security.pattern.image.fillStyle.html [ Failure ]
index 5f54127..3b4c4ea 100644 (file)
@@ -1,3 +1,21 @@
+2015-01-13  Said Abou-Hallawa  <sabouhallawa@apple.com>
+
+        Missed images and missed new lines in the expected results of the imported w3c canvas layout tests.
+        https://bugs.webkit.org/show_bug.cgi?id=140409.
+
+        Reviewed by Dean Jackson.
+
+        Fix some failures in the imported W3C canvas tests. These failures were happening because
+        of missing images or missing new lines at the end of the expected results.
+
+        * canvas/2d.pattern.paint.repeat.basic-expected.txt:
+        * canvas/2d.pattern.paint.repeat.outside-expected.txt:
+        * canvas/2d.pattern.paint.repeatx.basic-expected.txt:
+        * canvas/2d.pattern.paint.repeaty.basic-expected.txt:
+        * canvas/resources/background.png: Added.
+        * canvas/resources/green-16x16.png: Added.
+        * common/canvas-tests.css:
+
 2014-11-14  Said Abou-Hallawa  <sabouhallawa@apple.com>
 
         Import w3c tests for canvas
diff --git a/LayoutTests/imported/w3c/canvas/resources/background.png b/LayoutTests/imported/w3c/canvas/resources/background.png
new file mode 100644 (file)
index 0000000..6db6c6b
Binary files /dev/null and b/LayoutTests/imported/w3c/canvas/resources/background.png differ
diff --git a/LayoutTests/imported/w3c/canvas/resources/green-16x16.png b/LayoutTests/imported/w3c/canvas/resources/green-16x16.png
new file mode 100644 (file)
index 0000000..e19a3ff
Binary files /dev/null and b/LayoutTests/imported/w3c/canvas/resources/green-16x16.png differ
index e006e81..edc6b37 100644 (file)
@@ -70,13 +70,13 @@ canvas {
     display: none;
     visibility: hidden;
     border: 2px #f0f solid;
-    background: url(../images/background.png);
+    background: url(../resources/background.png);
 }
 
 img.expected {
     display: none;
     border: 2px #f0f solid;
-    background: url(../images/background.png);
+    background: url(../resources/background.png);
 }
 
 iframe {