2010-05-20 Martin Robinson <mrobinson@igalia.com>
authormrobinson@webkit.org <mrobinson@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 20 May 2010 17:15:03 +0000 (17:15 +0000)
committermrobinson@webkit.org <mrobinson@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 20 May 2010 17:15:03 +0000 (17:15 +0000)
        Reviewed by Ojan Vafai.

        editing/selection/extend-selection-after-double-click.html crashes on the Leopard Intel release bot
        https://bugs.webkit.org/show_bug.cgi?id=39431

        * DumpRenderTree/mac/LayoutTestControllerMac.mm:
        (LayoutTestController::setEditingBehavior):
        Prevent a double-free by not having this variable be in the auto-release pool.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59844 268f45cc-cd09-0410-ab3c-d52691b4dbfc

WebKitTools/ChangeLog
WebKitTools/DumpRenderTree/mac/LayoutTestControllerMac.mm

index ea48788..72395bf 100644 (file)
@@ -1,3 +1,14 @@
+2010-05-20  Martin Robinson  <mrobinson@igalia.com>
+
+        Reviewed by Ojan Vafai.
+
+        editing/selection/extend-selection-after-double-click.html crashes on the Leopard Intel release bot
+        https://bugs.webkit.org/show_bug.cgi?id=39431
+
+        * DumpRenderTree/mac/LayoutTestControllerMac.mm:
+        (LayoutTestController::setEditingBehavior):
+        Prevent a double-free by not having this variable be in the auto-release pool.
+
 2010-05-20  Martin Robinson  <mrobinson@webkit.org>
 
         Reviewed by Ojan Vafai.
index 9e5fd69..e5ebc02 100644 (file)
@@ -852,7 +852,7 @@ void LayoutTestController::authenticateSession(JSStringRef url, JSStringRef user
 
 void LayoutTestController::setEditingBehavior(const char* editingBehavior)
 {
-    NSString* editingBehaviorNS = [NSString stringWithUTF8String:editingBehavior];
+    NSString* editingBehaviorNS = [[NSString alloc] initWithUTF8String:editingBehavior];
     if ([editingBehaviorNS isEqualToString:@"mac"])
         [[WebPreferences standardPreferences] setEditingBehavior:WebKitEditingMacBehavior];
     if ([editingBehaviorNS isEqualToString:@"win"])