Web Inspector: REGRESSION(r244268): "Show Scope Chain on pause" setting has no effect
authordrousso@apple.com <drousso@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 16 Aug 2019 02:08:29 +0000 (02:08 +0000)
committerdrousso@apple.com <drousso@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 16 Aug 2019 02:08:29 +0000 (02:08 +0000)
https://bugs.webkit.org/show_bug.cgi?id=200797

Reviewed by Joseph Pecoraro.

* UserInterface/Views/DebuggerTabContentView.js:
(WI.DebuggerTabContentView.prototype.showDetailsSidebarPanels):
* UserInterface/Views/SourcesTabContentView.js:
(WI.SourcesTabContentView.prototype.showDetailsSidebarPanels):
When the sidebar panel isn't visible `parentSidebar` is `null`. Use `WI.DetailsSidebar` instead.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@248758 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/WebInspectorUI/ChangeLog
Source/WebInspectorUI/UserInterface/Views/DebuggerTabContentView.js
Source/WebInspectorUI/UserInterface/Views/SourcesTabContentView.js

index 62c7860..71ff09a 100644 (file)
@@ -1,5 +1,18 @@
 2019-08-15  Devin Rousso  <drousso@apple.com>
 
+        Web Inspector: REGRESSION(r244268): "Show Scope Chain on pause" setting has no effect
+        https://bugs.webkit.org/show_bug.cgi?id=200797
+
+        Reviewed by Joseph Pecoraro.
+
+        * UserInterface/Views/DebuggerTabContentView.js:
+        (WI.DebuggerTabContentView.prototype.showDetailsSidebarPanels):
+        * UserInterface/Views/SourcesTabContentView.js:
+        (WI.SourcesTabContentView.prototype.showDetailsSidebarPanels):
+        When the sidebar panel isn't visible `parentSidebar` is `null`. Use `WI.DetailsSidebar` instead.
+
+2019-08-15  Devin Rousso  <drousso@apple.com>
+
         Web Inspector: Uncaught Exception: TypeError: null is not an object (evaluating 'this._resource.initiatorSourceCodeLocation')
         https://bugs.webkit.org/show_bug.cgi?id=200798
 
index 03ab410..bbd55b4 100644 (file)
@@ -80,12 +80,8 @@ WI.DebuggerTabContentView = class DebuggerTabContentView extends WI.ContentBrows
         if (!scopeChainDetailsSidebarPanel)
             return;
 
-        let sidebar = scopeChainDetailsSidebarPanel.parentSidebar;
-        if (!sidebar)
-            return;
-
-        sidebar.selectedSidebarPanel = scopeChainDetailsSidebarPanel;
-        sidebar.collapsed = false;
+        WI.detailsSidebar.selectedSidebarPanel = scopeChainDetailsSidebarPanel;
+        WI.detailsSidebar.collapsed = false;
 
         this._showScopeChainDetailsSidebarPanel = false;
     }
index fb7cb31..2f895d7 100644 (file)
@@ -83,12 +83,8 @@ WI.SourcesTabContentView = class SourcesTabContentView extends WI.ContentBrowser
         if (!scopeChainDetailsSidebarPanel)
             return;
 
-        let sidebar = scopeChainDetailsSidebarPanel.parentSidebar;
-        if (!sidebar)
-            return;
-
-        sidebar.selectedSidebarPanel = scopeChainDetailsSidebarPanel;
-        sidebar.collapsed = false;
+        WI.detailsSidebar.selectedSidebarPanel = scopeChainDetailsSidebarPanel;
+        WI.detailsSidebar.collapsed = false;
 
         this._showScopeChainDetailsSidebarPanel = false;
     }