2010-05-25 Ojan Vafai <ojan@chromium.org>
authorojan@chromium.org <ojan@chromium.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 25 May 2010 22:41:19 +0000 (22:41 +0000)
committerojan@chromium.org <ojan@chromium.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 25 May 2010 22:41:19 +0000 (22:41 +0000)
        Reviewed by Chris Jerdonek.

        remove suppression of rietveld logging
        https://bugs.webkit.org/show_bug.cgi?id=39693

        Now that we only upload to rietveld explicitly, e.g. on the bot
        or via webkit-patch post-attachment-to-rietveld, we should print
        all the rietveld logging. It was suppressed before to avoid making
        webkit-patch upload too noisy.

        * Scripts/webkitpy/common/net/rietveld.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60191 268f45cc-cd09-0410-ab3c-d52691b4dbfc

WebKitTools/ChangeLog
WebKitTools/Scripts/webkitpy/common/net/rietveld.py

index 2fa5028..f7ed706 100644 (file)
@@ -1,3 +1,17 @@
+2010-05-25  Ojan Vafai  <ojan@chromium.org>
+
+        Reviewed by Chris Jerdonek.
+
+        remove suppression of rietveld logging
+        https://bugs.webkit.org/show_bug.cgi?id=39693
+
+        Now that we only upload to rietveld explicitly, e.g. on the bot
+        or via webkit-patch post-attachment-to-rietveld, we should print
+        all the rietveld logging. It was suppressed before to avoid making
+        webkit-patch upload too noisy.
+
+        * Scripts/webkitpy/common/net/rietveld.py:
+
 2010-05-25  Antonio Gomes  <tonikitoo@webkit.org>
 
         Reviewed by Ojan Vafai.
index c0d6119..572d1fd 100644 (file)
@@ -67,15 +67,8 @@ class Rietveld(object):
             log("Would have run %s" % args)
             return
 
-        # Set logging level to avoid rietveld's logging spew.
-        old_level_name = logging.getLogger().getEffectiveLevel()
-        logging.getLogger().setLevel(logging.ERROR)
-
         # Use RealMain instead of calling upload from the commandline so that
         # we can pass in the diff ourselves. Otherwise, upload will just use
         # git diff for git checkouts, which doesn't respect --squash and --git-commit.
         issue, patchset = upload.RealMain(args[1:], data=diff)
-
-        # Reset logging level to the original value.
-        logging.getLogger().setLevel(old_level_name)
         return issue