REGRESSION (r127882): accessibility/spinbutton-value.html failing on GTK
authorcommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 21 Sep 2012 20:03:57 +0000 (20:03 +0000)
committercommit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 21 Sep 2012 20:03:57 +0000 (20:03 +0000)
https://bugs.webkit.org/show_bug.cgi?id=96196

Patch by Joanmarie Diggs <jdiggs@igalia.com> on 2012-09-21
Reviewed by Martin Robinson.

The "regression" is that a new test was added but the support was missing
in the Gtk port for spin buttons.

Source/WebCore:

No new tests. Instead the new test which had been skipped was unskipped
as part of this fix.

* accessibility/gtk/WebKitAccessibleWrapperAtk.cpp:
(atkRole): Map SpinButtonRole to ATK_ROLE_SPIN_BUTTON
(getInterfaceMaskFromObject): Add SpinButtonRole to the roles implementing
the AtkValue interface.

Tools:

* DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
(AccessibilityUIElement::valueDescription): Updated the FIXME comment to
indicate that this cannot be implemented until it is implemented in ATK.
URL of the newly-filed ATK bug included for reference.

LayoutTests:

* platform/gtk/TestExpectations: Unskip the new test.
* platform/gtk/accessibility/spinbutton-value-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@129247 268f45cc-cd09-0410-ab3c-d52691b4dbfc

LayoutTests/ChangeLog
LayoutTests/platform/gtk/TestExpectations
LayoutTests/platform/gtk/accessibility/spinbutton-value-expected.txt [new file with mode: 0644]
Source/WebCore/ChangeLog
Source/WebCore/accessibility/gtk/WebKitAccessibleWrapperAtk.cpp
Tools/ChangeLog
Tools/DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp

index 9ad44ee..49af301 100644 (file)
@@ -1,5 +1,18 @@
 2012-09-21  Joanmarie Diggs  <jdiggs@igalia.com>
 
+        REGRESSION (r127882): accessibility/spinbutton-value.html failing on GTK
+        https://bugs.webkit.org/show_bug.cgi?id=96196
+
+        Reviewed by Martin Robinson.
+
+        The "regression" is that a new test was added but the support was missing
+        in the Gtk port for spin buttons.
+
+        * platform/gtk/TestExpectations: Unskip the new test.
+        * platform/gtk/accessibility/spinbutton-value-expected.txt: Added.
+
+2012-09-21  Joanmarie Diggs  <jdiggs@igalia.com>
+
         [GTK] [Stable] Infinite recursion in WebCore::AXObjectCache::getOrCreate
         https://bugs.webkit.org/show_bug.cgi?id=96932
 
index 351d4e6..3d2ce42 100644 (file)
@@ -1354,8 +1354,6 @@ webkit.org/b/95429 svg/custom/clamped-masking-clipping.svg [ ImageOnlyFailure ]
 
 webkit.org/b/88238 editing/pasteboard/paste-global-selection.html [ Failure ]
 
-webkit.org/b/96196 accessibility/spinbutton-value.html [ Failure ]
-
 webkit.org/b/73003 [ Debug ] editing/spelling/spellcheck-async.html [ Failure ]
 webkit.org/b/73003 [ Debug ] editing/spelling/spellcheck-paste.html [ Pass ]
 webkit.org/b/50740 [ Debug ] editing/spelling/spellcheck-queue.html [ Failure ]
diff --git a/LayoutTests/platform/gtk/accessibility/spinbutton-value-expected.txt b/LayoutTests/platform/gtk/accessibility/spinbutton-value-expected.txt
new file mode 100644 (file)
index 0000000..a84fda2
--- /dev/null
@@ -0,0 +1,16 @@
+
+42
+This tests that a spin button supports range value attributes.
+
+On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
+
+
+PASS endsWith(axSpin.intValue, '5') is true
+PASS endsWith(axSpin.minValue, '1') is true
+PASS endsWith(axSpin.maxValue, '9') is true
+FAIL endsWith(axSpin.valueDescription, '5 of 9') should be true. Was false.
+PASS axSpin.title is axUntitled.title
+PASS successfullyParsed is true
+
+TEST COMPLETE
+
index 5ac0708..4afe372 100644 (file)
@@ -1,5 +1,23 @@
 2012-09-21  Joanmarie Diggs  <jdiggs@igalia.com>
 
+        REGRESSION (r127882): accessibility/spinbutton-value.html failing on GTK
+        https://bugs.webkit.org/show_bug.cgi?id=96196
+
+        Reviewed by Martin Robinson.
+
+        The "regression" is that a new test was added but the support was missing
+        in the Gtk port for spin buttons.
+
+        No new tests. Instead the new test which had been skipped was unskipped
+        as part of this fix.
+
+        * accessibility/gtk/WebKitAccessibleWrapperAtk.cpp:
+        (atkRole): Map SpinButtonRole to ATK_ROLE_SPIN_BUTTON
+        (getInterfaceMaskFromObject): Add SpinButtonRole to the roles implementing
+        the AtkValue interface.
+
+2012-09-21  Joanmarie Diggs  <jdiggs@igalia.com>
+
         [GTK] [Stable] Infinite recursion in WebCore::AXObjectCache::getOrCreate
         https://bugs.webkit.org/show_bug.cgi?id=96932
 
index ec223aa..b197cb2 100644 (file)
@@ -555,6 +555,8 @@ static AtkRole atkRole(AccessibilityRole role)
         return ATK_ROLE_CANVAS;
     case HorizontalRuleRole:
         return ATK_ROLE_SEPARATOR;
+    case SpinButtonRole:
+        return ATK_ROLE_SPIN_BUTTON;
     default:
         return ATK_ROLE_UNKNOWN;
     }
@@ -923,7 +925,7 @@ static guint16 getInterfaceMaskFromObject(AccessibilityObject* coreObject)
         interfaceMask |= 1 << WAI_DOCUMENT;
 
     // Value
-    if (role == SliderRole)
+    if (role == SliderRole || role == SpinButtonRole)
         interfaceMask |= 1 << WAI_VALUE;
 
     return interfaceMask;
index 1c3b1d8..49289af 100644 (file)
@@ -1,3 +1,18 @@
+2012-09-21  Joanmarie Diggs  <jdiggs@igalia.com>
+
+        REGRESSION (r127882): accessibility/spinbutton-value.html failing on GTK
+        https://bugs.webkit.org/show_bug.cgi?id=96196
+
+        Reviewed by Martin Robinson.
+
+        The "regression" is that a new test was added but the support was missing
+        in the Gtk port for spin buttons.
+
+        * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
+        (AccessibilityUIElement::valueDescription): Updated the FIXME comment to
+        indicate that this cannot be implemented until it is implemented in ATK.
+        URL of the newly-filed ATK bug included for reference.
+
 2012-09-21  Dirk Pranke  <dpranke@chromium.org>
 
         Fix test_skip_and_wontfix failure
index d2b4e8b..6b9edc9 100644 (file)
@@ -409,7 +409,8 @@ double AccessibilityUIElement::maxValue()
 
 JSStringRef AccessibilityUIElement::valueDescription()
 {
-    // FIXME: implement
+    // FIXME: implement after it has been implemented in ATK.
+    // See: https://bugzilla.gnome.org/show_bug.cgi?id=684576
     return JSStringCreateWithCharacters(0, 0);
 }