Rebaseline and enable media/modern-media-controls/forward-button
authorgraouts@webkit.org <graouts@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 8 Jun 2017 18:54:43 +0000 (18:54 +0000)
committergraouts@webkit.org <graouts@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Thu, 8 Jun 2017 18:54:43 +0000 (18:54 +0000)
https://bugs.webkit.org/show_bug.cgi?id=173100

Reviewed by Dean Jackson.

Update the test to check an SVG asset now that we use those.

* media/modern-media-controls/forward-button/forward-button-expected.txt:
* media/modern-media-controls/forward-button/forward-button.html:
* platform/ios-simulator/TestExpectations:
* platform/mac/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@217940 268f45cc-cd09-0410-ab3c-d52691b4dbfc

LayoutTests/ChangeLog
LayoutTests/media/modern-media-controls/forward-button/forward-button-expected.txt
LayoutTests/media/modern-media-controls/forward-button/forward-button.html
LayoutTests/platform/ios-simulator/TestExpectations
LayoutTests/platform/mac/TestExpectations

index 6995b68..96ed57e 100644 (file)
@@ -1,5 +1,19 @@
 2017-06-08  Antoine Quint  <graouts@apple.com>
 
+        Rebaseline and enable media/modern-media-controls/forward-button
+        https://bugs.webkit.org/show_bug.cgi?id=173100
+
+        Reviewed by Dean Jackson.
+
+        Update the test to check an SVG asset now that we use those.
+
+        * media/modern-media-controls/forward-button/forward-button-expected.txt:
+        * media/modern-media-controls/forward-button/forward-button.html:
+        * platform/ios-simulator/TestExpectations:
+        * platform/mac/TestExpectations:
+
+2017-06-08  Antoine Quint  <graouts@apple.com>
+
         Layout Test media/modern-media-controls/button/button-icon-name.html is a flaky failure
         https://bugs.webkit.org/show_bug.cgi?id=173099
 
index c79ce24..ef8aa48 100644 (file)
@@ -4,10 +4,9 @@ On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE
 
 
 PASS forwardButton.element.localName is "button"
-PASS forwardButton.element.classList.contains("icon") is true
 PASS forwardButton.element.classList.contains("forward") is true
 PASS forwardButton.iconName is Icons.Forward
-PASS forwardButton.element.style.webkitMaskImage.includes("macOS/forward@") became true
+PASS forwardButton.image.element.style.webkitMaskImage.includes("macOS/Forward.svg") became true
 PASS successfullyParsed is true
 
 TEST COMPLETE
index ad2cdb5..2e87b64 100644 (file)
@@ -11,11 +11,10 @@ description("Testing the <code>ForwardButton</code> class.");
 const forwardButton = new ForwardButton({ layoutTraits: LayoutTraits.macOS });
 
 shouldBeEqualToString("forwardButton.element.localName", "button");
-shouldBeTrue('forwardButton.element.classList.contains("icon")');
 shouldBeTrue('forwardButton.element.classList.contains("forward")');
 shouldBe("forwardButton.iconName", "Icons.Forward");
 
-shouldBecomeEqual('forwardButton.element.style.webkitMaskImage.includes("macOS/forward@")', "true", finishMediaControlsTest);
+shouldBecomeEqual('forwardButton.image.element.style.webkitMaskImage.includes("macOS/Forward.svg")', "true", finishMediaControlsTest);
 
 </script>
 <script src="../../../resources/js-test-post.js"></script>
index 3f7c6fa..a09e52f 100644 (file)
@@ -62,6 +62,7 @@ media/modern-media-controls/background-tint [ Pass ]
 media/modern-media-controls/button [ Pass ]
 media/modern-media-controls/buttons-container [ Pass ]
 media/modern-media-controls/controls-visibility-support [ Pass ]
+media/modern-media-controls/forward-button [ Pass ]
 
 # AirPlay cannot be tested on iOS
 webkit.org/b/166062 media/modern-media-controls/airplay-support [ Skip ]
index b87c686..1d2141e 100644 (file)
@@ -1557,6 +1557,7 @@ media/modern-media-controls/background-tint [ Pass ]
 media/modern-media-controls/button [ Pass ]
 media/modern-media-controls/buttons-container [ Pass ]
 media/modern-media-controls/controls-visibility-support [ Pass ]
+media/modern-media-controls/forward-button [ Pass ]
 media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-drag-is-prevented-over-button.html [ Pass ]
 media/modern-media-controls/macos-fullscreen-media-controls/macos-fullscreen-media-controls-drag.html [ Pass ]
 media/modern-media-controls/volume-up-support [ Pass ]