Drop WorkerGlobalScope's custom GetOwnPropertySlot() implementation
authorcdumez@apple.com <cdumez@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 13 May 2016 06:28:36 +0000 (06:28 +0000)
committercdumez@apple.com <cdumez@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 13 May 2016 06:28:36 +0000 (06:28 +0000)
https://bugs.webkit.org/show_bug.cgi?id=157662

Reviewed by Darin Adler.

Drop WorkerGlobalScope's custom GetOwnPropertySlot() implementation as
it is no longer needed after <http://trac.webkit.org/changeset/196678>.

JSC::getStaticPropertySlot() now properly checks for overrides *before*
checking the static table.

No new tests, no web-exposed behavior change.

* bindings/js/JSWorkerGlobalScopeCustom.cpp:
(WebCore::JSWorkerGlobalScope::getOwnPropertySlotDelegate): Deleted.
* workers/WorkerGlobalScope.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@200814 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/WebCore/ChangeLog
Source/WebCore/bindings/js/JSWorkerGlobalScopeCustom.cpp
Source/WebCore/workers/WorkerGlobalScope.idl

index 7665043..3e03915 100644 (file)
@@ -1,3 +1,22 @@
+2016-05-12  Chris Dumez  <cdumez@apple.com>
+
+        Drop WorkerGlobalScope's custom GetOwnPropertySlot() implementation
+        https://bugs.webkit.org/show_bug.cgi?id=157662
+
+        Reviewed by Darin Adler.
+
+        Drop WorkerGlobalScope's custom GetOwnPropertySlot() implementation as
+        it is no longer needed after <http://trac.webkit.org/changeset/196678>.
+
+        JSC::getStaticPropertySlot() now properly checks for overrides *before*
+        checking the static table.
+
+        No new tests, no web-exposed behavior change.
+
+        * bindings/js/JSWorkerGlobalScopeCustom.cpp:
+        (WebCore::JSWorkerGlobalScope::getOwnPropertySlotDelegate): Deleted.
+        * workers/WorkerGlobalScope.idl:
+
 2016-05-12  Zan Dobersek  <zdobersek@igalia.com>
 
         CoordinatedGraphicsLayer::syncLayerState() should set the m_layerState.contentsOpaque flag
index 9b8e85c..d0fe4ab 100644 (file)
@@ -59,14 +59,6 @@ void JSWorkerGlobalScope::visitAdditionalChildren(SlotVisitor& visitor)
         visitor.addOpaqueRoot(navigator);
 }
 
-bool JSWorkerGlobalScope::getOwnPropertySlotDelegate(ExecState* exec, PropertyName propertyName, PropertySlot& slot)
-{
-    // Look for overrides before looking at any of our own properties.
-    if (JSGlobalObject::getOwnPropertySlot(this, exec, propertyName, slot))
-        return true;
-    return false;
-}
-
 JSValue JSWorkerGlobalScope::importScripts(ExecState& state)
 {
     if (!state.argumentCount())
index 681de3a..43eaf9e 100644 (file)
@@ -28,7 +28,6 @@
     Exposed=Worker,
     CustomProxyToJSObject,
     JSCustomMarkFunction,
-    JSCustomGetOwnPropertySlotAndDescriptor,
     JSLegacyParent=JSWorkerGlobalScopeBase,
 ] interface WorkerGlobalScope : EventTarget {