[selectors4] css/selectors4/focus-within-006.html test from WPT is failing
authorrego@igalia.com <rego@igalia.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 12 May 2017 09:43:44 +0000 (09:43 +0000)
committerrego@igalia.com <rego@igalia.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 12 May 2017 09:43:44 +0000 (09:43 +0000)
https://bugs.webkit.org/show_bug.cgi?id=170900

Reviewed by Sergio Villar Senin.

LayoutTests/imported/w3c:

The issue has been fixed in WPT repo:
https://github.com/w3c/web-platform-tests/pull/5786

This patch is importing the changes so we can close this bug on WebKit.

* web-platform-tests/css/selectors4/focus-within-006-expected.html:
* web-platform-tests/css/selectors4/focus-within-006.html:
* web-platform-tests/css/selectors4/w3c-import.log:

LayoutTests:

* TestExpectations: Remove test as it's passing now.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@216756 268f45cc-cd09-0410-ab3c-d52691b4dbfc

LayoutTests/ChangeLog
LayoutTests/TestExpectations
LayoutTests/imported/w3c/ChangeLog
LayoutTests/imported/w3c/web-platform-tests/css/selectors4/focus-within-006-expected.html
LayoutTests/imported/w3c/web-platform-tests/css/selectors4/focus-within-006.html
LayoutTests/imported/w3c/web-platform-tests/css/selectors4/w3c-import.log

index 3a9e3e8..d0912c6 100644 (file)
@@ -1,3 +1,12 @@
+2017-05-12  Manuel Rego Casasnovas  <rego@igalia.com>
+
+        [selectors4] css/selectors4/focus-within-006.html test from WPT is failing
+        https://bugs.webkit.org/show_bug.cgi?id=170900
+
+        Reviewed by Sergio Villar Senin.
+
+        * TestExpectations: Remove test as it's passing now.
+
 2017-05-11  Per Arne Vollan  <pvollan@apple.com>
 
         Geolocation requests should not be blocked when the security origin is local.
index 15ae457..ace13c6 100644 (file)
@@ -287,7 +287,6 @@ webkit.org/b/149891 imported/w3c/web-platform-tests/css/css-grid-1/grid-layout-p
 webkit.org/b/169271 imported/w3c/web-platform-tests/css/css-grid-1/grid-items/grid-items-sizing-alignment-001.html [ ImageOnlyFailure ]
 
 # selectors4
-webkit.org/b/170900 imported/w3c/web-platform-tests/css/selectors4/focus-within-006.html [ ImageOnlyFailure ]
 webkit.org/b/64861 imported/w3c/web-platform-tests/css/selectors4/selectors-dir-selector-ltr-001.html [ ImageOnlyFailure ]
 webkit.org/b/64861 imported/w3c/web-platform-tests/css/selectors4/selectors-dir-selector-rtl-001.html [ ImageOnlyFailure ]
 
index 915bad2..cbdf0e7 100644 (file)
@@ -1,3 +1,19 @@
+2017-05-12  Manuel Rego Casasnovas  <rego@igalia.com>
+
+        [selectors4] css/selectors4/focus-within-006.html test from WPT is failing
+        https://bugs.webkit.org/show_bug.cgi?id=170900
+
+        Reviewed by Sergio Villar Senin.
+
+        The issue has been fixed in WPT repo:
+        https://github.com/w3c/web-platform-tests/pull/5786
+
+        This patch is importing the changes so we can close this bug on WebKit.
+
+        * web-platform-tests/css/selectors4/focus-within-006-expected.html:
+        * web-platform-tests/css/selectors4/focus-within-006.html:
+        * web-platform-tests/css/selectors4/w3c-import.log:
+
 2017-05-11  Manuel Rego Casasnovas  <rego@igalia.com>
 
         [selectors4] :focus-within tests using shadow DOM don't pass on WK1
index 2913775..b93c156 100644 (file)
@@ -1,10 +1,19 @@
 <!DOCTYPE html>
-<html lang=en>
+<html lang=en class="reftest-wait">
 <meta charset="utf-8">
 <title>Selectors Level 4: focus-within Reference File</title>
-<link rel="author" title="Keyong Li" href="mailto:kli79@bloomberg.net">
-<link rel="author" title="Florian Rivoal" href="mailto:florian@rivoal.net">
+<link rel="author" title="Manuel Rego Casasnovas" href="mailto:rego@igalia.com">
 <style>
+:focus {
+  outline: none;
+
+  /* Make the caret invisible
+     since it matches the color of the text, which is transparent,
+     while keeping the text readable thanks to its shadow.
+     Not using the caret-color property as it is too new to be relied on. */
+  color: transparent; text-shadow: black 0px 0px 0px;
+}
+
 div {
   border: solid 15px green;
 }
@@ -12,5 +21,12 @@ div {
 <p>Test passes if, when the element below is focused,
 it is surrounded by a thick green border.
 There must be no red or blue once it is focused.</p>
-<div>Focus this element</div>
+<div>
+  <input id="focusme" value="Focus this element">
+</div>
+<script>
+var focusme = document.getElementById('focusme');
+focusme.focus();
+document.documentElement.classList.remove('reftest-wait');
+</script>
 </html>
index 4a515d7..ff63cce 100644 (file)
@@ -5,12 +5,10 @@
 <link rel="author" title="Keyong Li" href="mailto:kli79@bloomberg.net">
 <link rel="author" title="Florian Rivoal" href="mailto:florian@rivoal.net">
 <link rel="help" href="https://drafts.csswg.org/selectors-4/#focus-within-pseudo">
-<link rel="match" href="focus-within-001-ref.html">
+<link rel="match" href="focus-within-006-ref.html">
 <meta name="assert" content="Test that :focus-within works on form controls, using an input element.">
 <style>
-/* Suppress things that cannot be reproduced in the reference file */
 :focus {
-  all: initial;
   outline: none;
 
   /* Make the caret invisible
index 3dbe43d..c8e6290 100644 (file)
@@ -46,6 +46,8 @@ List of files:
 /LayoutTests/imported/w3c/web-platform-tests/css/selectors4/focus-within-shadow-004.html
 /LayoutTests/imported/w3c/web-platform-tests/css/selectors4/focus-within-shadow-005-expected.html
 /LayoutTests/imported/w3c/web-platform-tests/css/selectors4/focus-within-shadow-005.html
+/LayoutTests/imported/w3c/web-platform-tests/css/selectors4/focus-within-shadow-006-expected.html
+/LayoutTests/imported/w3c/web-platform-tests/css/selectors4/focus-within-shadow-006.html
 /LayoutTests/imported/w3c/web-platform-tests/css/selectors4/of-type-selectors-expected.xhtml
 /LayoutTests/imported/w3c/web-platform-tests/css/selectors4/of-type-selectors.xhtml
 /LayoutTests/imported/w3c/web-platform-tests/css/selectors4/selector-required-expected.html