2008-10-07 David Hyatt <hyatt@apple.com>

        https://bugs.webkit.org/show_bug.cgi?id=18989

        Remove global substitution from SunSpider regexp test, since only Firefox was honoring it and
        we want all browsers to be doing the same thing on the test.

        Reviewed by Maciej

        * tests/regexp-dna.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@37390 268f45cc-cd09-0410-ab3c-d52691b4dbfc

diff --git a/SunSpider/ChangeLog b/SunSpider/ChangeLog
index 022b76b..7acac80 100644 (file)
--- a/SunSpider/ChangeLog
+++ b/SunSpider/ChangeLog
@@ -1,3 +1,14 @@
+2008-10-07  David Hyatt  <hyatt@apple.com>
+
+        https://bugs.webkit.org/show_bug.cgi?id=18989
+
+        Remove global substitution from SunSpider regexp test, since only Firefox was honoring it and
+        we want all browsers to be doing the same thing on the test.
+
+        Reviewed by Maciej
+
+        * tests/regexp-dna.js:
+
 2008-09-09  Cameron Zwarich  <cwzwarich@uwaterloo.ca>
 
         Rubber-stamped by Maciej Stachowiak.

diff --git a/SunSpider/tests/regexp-dna.js b/SunSpider/tests/regexp-dna.js
index b1f9ece..b500e68 100644 (file)
--- a/SunSpider/tests/regexp-dna.js
+++ b/SunSpider/tests/regexp-dna.js
@@ -1708,5 +1708,5 @@ for(i in seqs)
  // match returns null if no matches, so replace with empty
 
 for(k in subs)
- dnaInput = dnaInput.replace(k, subs[k], "g")
+ dnaInput = dnaInput.replace(k, subs[k]) // FIXME: Would like this to be a global substitution in a future version of SunSpider.
  // search string, replacement string, flags