2009-03-27 Darin Adler <darin@apple.com>
authordarin@apple.com <darin@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 27 Mar 2009 23:55:17 +0000 (23:55 +0000)
committerdarin@apple.com <darin@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Fri, 27 Mar 2009 23:55:17 +0000 (23:55 +0000)
        Reviewed by Sam Weinig.

        Made our mailto form submission tests work more reliably by using the new
        layoutTestController.waitForPolicyDelegate function.

        * fast/encoding/mailto-always-utf-8.html: Updated test to use waitForPolicyDelegate
        rather than relying on the form submission happening immediately.
        * fast/forms/mailto/advanced-get.html: Ditto.
        * fast/forms/mailto/advanced-put.html: Ditto.
        * fast/forms/mailto/get-multiple-items-text-plain.html: Ditto.
        * fast/forms/mailto/get-multiple-items-x-www-form-urlencoded.html: Ditto.
        * fast/forms/mailto/get-multiple-items.html: Ditto.
        * fast/forms/mailto/get-non-ascii-always-utf-8.html: Ditto.
        * fast/forms/mailto/get-non-ascii-text-plain-latin-1.html: Ditto.
        * fast/forms/mailto/get-non-ascii-text-plain.html: Ditto.
        * fast/forms/mailto/get-non-ascii.html: Ditto.
        * fast/forms/mailto/get-overwrite-query.html: Ditto.
        * fast/forms/mailto/post-append-query.html: Ditto.
        * fast/forms/mailto/post-multiple-items-multipart-form-data.html: Ditto.
        * fast/forms/mailto/post-multiple-items-text-plain.html: Ditto.
        * fast/forms/mailto/post-multiple-items-x-www-form-urlencoded.html: Ditto.
        * fast/forms/mailto/post-multiple-items.html: Ditto.
        * fast/forms/mailto/post-text-plain-with-accept-charset.html: Ditto.
        * fast/forms/mailto/post-text-plain.html: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@42057 268f45cc-cd09-0410-ab3c-d52691b4dbfc

19 files changed:
LayoutTests/ChangeLog
LayoutTests/fast/encoding/mailto-always-utf-8.html
LayoutTests/fast/forms/mailto/advanced-get.html
LayoutTests/fast/forms/mailto/advanced-put.html
LayoutTests/fast/forms/mailto/get-multiple-items-text-plain.html
LayoutTests/fast/forms/mailto/get-multiple-items-x-www-form-urlencoded.html
LayoutTests/fast/forms/mailto/get-multiple-items.html
LayoutTests/fast/forms/mailto/get-non-ascii-always-utf-8.html
LayoutTests/fast/forms/mailto/get-non-ascii-text-plain-latin-1.html
LayoutTests/fast/forms/mailto/get-non-ascii-text-plain.html
LayoutTests/fast/forms/mailto/get-non-ascii.html
LayoutTests/fast/forms/mailto/get-overwrite-query.html
LayoutTests/fast/forms/mailto/post-append-query.html
LayoutTests/fast/forms/mailto/post-multiple-items-multipart-form-data.html
LayoutTests/fast/forms/mailto/post-multiple-items-text-plain.html
LayoutTests/fast/forms/mailto/post-multiple-items-x-www-form-urlencoded.html
LayoutTests/fast/forms/mailto/post-multiple-items.html
LayoutTests/fast/forms/mailto/post-text-plain-with-accept-charset.html
LayoutTests/fast/forms/mailto/post-text-plain.html

index 5403c59..73923bb 100644 (file)
@@ -1,3 +1,30 @@
+2009-03-27  Darin Adler  <darin@apple.com>
+
+        Reviewed by Sam Weinig.
+
+        Made our mailto form submission tests work more reliably by using the new
+        layoutTestController.waitForPolicyDelegate function.
+
+        * fast/encoding/mailto-always-utf-8.html: Updated test to use waitForPolicyDelegate
+        rather than relying on the form submission happening immediately.
+        * fast/forms/mailto/advanced-get.html: Ditto.
+        * fast/forms/mailto/advanced-put.html: Ditto.
+        * fast/forms/mailto/get-multiple-items-text-plain.html: Ditto.
+        * fast/forms/mailto/get-multiple-items-x-www-form-urlencoded.html: Ditto.
+        * fast/forms/mailto/get-multiple-items.html: Ditto.
+        * fast/forms/mailto/get-non-ascii-always-utf-8.html: Ditto.
+        * fast/forms/mailto/get-non-ascii-text-plain-latin-1.html: Ditto.
+        * fast/forms/mailto/get-non-ascii-text-plain.html: Ditto.
+        * fast/forms/mailto/get-non-ascii.html: Ditto.
+        * fast/forms/mailto/get-overwrite-query.html: Ditto.
+        * fast/forms/mailto/post-append-query.html: Ditto.
+        * fast/forms/mailto/post-multiple-items-multipart-form-data.html: Ditto.
+        * fast/forms/mailto/post-multiple-items-text-plain.html: Ditto.
+        * fast/forms/mailto/post-multiple-items-x-www-form-urlencoded.html: Ditto.
+        * fast/forms/mailto/post-multiple-items.html: Ditto.
+        * fast/forms/mailto/post-text-plain-with-accept-charset.html: Ditto.
+        * fast/forms/mailto/post-text-plain.html: Ditto.
+
 2009-03-27  Xiaomei Ji  <xji@chromium.org>
 
         Reviewed by Dan Bernstein.
index 44c96a1..0bb6206 100644 (file)
 function test() {
   if (window.layoutTestController) {
     layoutTestController.dumpAsText();
-    layoutTestController.setCustomPolicyDelegate(true);
+    layoutTestController.waitForPolicyDelegate();
     var a = document.getElementsByTagName("a")[0];
     eventSender.mouseMoveTo(a.offsetLeft + 5, a.offsetTop + 5);
     eventSender.mouseDown();
     eventSender.mouseUp();
-    layoutTestController.setCustomPolicyDelegate(false);
   }
 }
 </script>
index f974700..9db9040 100644 (file)
@@ -6,9 +6,8 @@
             function test() {
               if (window.layoutTestController) {
                 layoutTestController.dumpAsText();
-                layoutTestController.setCustomPolicyDelegate(true);
+                layoutTestController.waitForPolicyDelegate();
                 document.getElementsByTagName("form")[0].submit();
-                layoutTestController.setCustomPolicyDelegate(false);
               }
             }
         </script>
index fe07128..d2aec50 100644 (file)
@@ -6,9 +6,8 @@
             function test() {
               if (window.layoutTestController) {
                 layoutTestController.dumpAsText();
-                layoutTestController.setCustomPolicyDelegate(true);
+                layoutTestController.waitForPolicyDelegate();
                 document.getElementsByTagName("form")[0].submit();
-                layoutTestController.setCustomPolicyDelegate(false);
               }
             }
         </script>
index 6dd7b0d..d2604e5 100644 (file)
@@ -10,9 +10,8 @@ Line 2
 function test() {
   if (window.layoutTestController) {
     layoutTestController.dumpAsText();
-    layoutTestController.setCustomPolicyDelegate(true);
+    layoutTestController.waitForPolicyDelegate();
     document.getElementsByTagName("form")[0].submit();
-    layoutTestController.setCustomPolicyDelegate(false);
   }
 }
 </script>
index 1245394..d6c5064 100644 (file)
@@ -8,9 +8,8 @@ Field 2: <input type="text" size="10" maxlength="40" name="field2" value="value
 function test() {
   if (window.layoutTestController) {
     layoutTestController.dumpAsText();
-    layoutTestController.setCustomPolicyDelegate(true);
+    layoutTestController.waitForPolicyDelegate();
     document.getElementsByTagName("form")[0].submit();
-    layoutTestController.setCustomPolicyDelegate(false);
   }
 }
 </script>
index 2243589..1ff9f5d 100644 (file)
@@ -9,9 +9,8 @@ Field 2: <input type="text" size="10" maxlength="40" name="field2" value="value
 function test() {
   if (window.layoutTestController) {
     layoutTestController.dumpAsText();
-    layoutTestController.setCustomPolicyDelegate(true);
+    layoutTestController.waitForPolicyDelegate();
     document.getElementsByTagName("form")[0].submit();
-    layoutTestController.setCustomPolicyDelegate(false);
   }
 }
 </script>
index 546cca8..1dd0eb4 100644 (file)
@@ -9,9 +9,8 @@
 function test() {
   if (window.layoutTestController) {
     layoutTestController.dumpAsText();
-    layoutTestController.setCustomPolicyDelegate(true);
+    layoutTestController.waitForPolicyDelegate();
     document.getElementsByTagName("form")[0].submit();
-    layoutTestController.setCustomPolicyDelegate(false);
   }
 }
 </script>
index 9679446..353ac6d 100644 (file)
@@ -9,9 +9,8 @@
 function test() {
   if (window.layoutTestController) {
     layoutTestController.dumpAsText();
-    layoutTestController.setCustomPolicyDelegate(true);
+    layoutTestController.waitForPolicyDelegate();
     document.getElementsByTagName("form")[0].submit();
-    layoutTestController.setCustomPolicyDelegate(false);
   }
 }
 </script>
index 2b282b8..f5f2402 100644 (file)
@@ -9,9 +9,8 @@
 function test() {
   if (window.layoutTestController) {
     layoutTestController.dumpAsText();
-    layoutTestController.setCustomPolicyDelegate(true);
+    layoutTestController.waitForPolicyDelegate();
     document.getElementsByTagName("form")[0].submit();
-    layoutTestController.setCustomPolicyDelegate(false);
   }
 }
 </script>
index 2163245..450d889 100644 (file)
@@ -9,9 +9,8 @@
 function test() {
   if (window.layoutTestController) {
     layoutTestController.dumpAsText();
-    layoutTestController.setCustomPolicyDelegate(true);
+    layoutTestController.waitForPolicyDelegate();
     document.getElementsByTagName("form")[0].submit();
-    layoutTestController.setCustomPolicyDelegate(false);
   }
 }
 </script>
index bffe7ac..99a1934 100644 (file)
@@ -8,9 +8,8 @@
 function test() {
   if (window.layoutTestController) {
     layoutTestController.dumpAsText();
-    layoutTestController.setCustomPolicyDelegate(true);
+    layoutTestController.waitForPolicyDelegate();
     document.getElementsByTagName("form")[0].submit();
-    layoutTestController.setCustomPolicyDelegate(false);
   }
 }
 </script>
index 6fd130f..ef9141c 100644 (file)
@@ -8,9 +8,8 @@
 function test() {
   if (window.layoutTestController) {
     layoutTestController.dumpAsText();
-    layoutTestController.setCustomPolicyDelegate(true);
+    layoutTestController.waitForPolicyDelegate();
     document.getElementsByTagName("form")[0].submit();
-    layoutTestController.setCustomPolicyDelegate(false);
   }
 }
 </script>
index b0d970a..384483c 100644 (file)
@@ -10,9 +10,8 @@ Line 2
 function test() {
   if (window.layoutTestController) {
     layoutTestController.dumpAsText();
-    layoutTestController.setCustomPolicyDelegate(true);
+    layoutTestController.waitForPolicyDelegate();
     document.getElementsByTagName("form")[0].submit();
-    layoutTestController.setCustomPolicyDelegate(false);
   }
 }
 </script>
index 253b9c6..50ccc59 100644 (file)
@@ -10,9 +10,8 @@ Line 2
 function test() {
   if (window.layoutTestController) {
     layoutTestController.dumpAsText();
-    layoutTestController.setCustomPolicyDelegate(true);
+    layoutTestController.waitForPolicyDelegate();
     document.getElementsByTagName("form")[0].submit();
-    layoutTestController.setCustomPolicyDelegate(false);
   }
 }
 </script>
index 7216bcf..81f2eeb 100644 (file)
@@ -10,9 +10,8 @@ Line 2
 function test() {
   if (window.layoutTestController) {
     layoutTestController.dumpAsText();
-    layoutTestController.setCustomPolicyDelegate(true);
+    layoutTestController.waitForPolicyDelegate();
     document.getElementsByTagName("form")[0].submit();
-    layoutTestController.setCustomPolicyDelegate(false);
   }
 }
 </script>
index 24e80df..30cc5d9 100644 (file)
@@ -9,9 +9,8 @@ Field 2: <input type="text" size="10" maxlength="40" name="field2" value="value
 function test() {
   if (window.layoutTestController) {
     layoutTestController.dumpAsText();
-    layoutTestController.setCustomPolicyDelegate(true);
+    layoutTestController.waitForPolicyDelegate();
     document.getElementsByTagName("form")[0].submit();
-    layoutTestController.setCustomPolicyDelegate(false);
   }
 }
 </script>
index c2372d2..2c1a22c 100644 (file)
@@ -13,9 +13,8 @@
 function test() {
   if (window.layoutTestController) {
     layoutTestController.dumpAsText();
-    layoutTestController.setCustomPolicyDelegate(true);
+    layoutTestController.waitForPolicyDelegate();
     document.getElementsByTagName("form")[0].submit();
-    layoutTestController.setCustomPolicyDelegate(false);
   }
 }
 </script>
index df26d1d..41719ac 100644 (file)
@@ -13,9 +13,8 @@
 function test() {
   if (window.layoutTestController) {
     layoutTestController.dumpAsText();
-    layoutTestController.setCustomPolicyDelegate(true);
+    layoutTestController.waitForPolicyDelegate();
     document.getElementsByTagName("form")[0].submit();
-    layoutTestController.setCustomPolicyDelegate(false);
   }
 }
 </script>