Turn on threaded scrolling by default in the tests
authortimothy_horton@apple.com <timothy_horton@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 21 Sep 2015 18:00:20 +0000 (18:00 +0000)
committertimothy_horton@apple.com <timothy_horton@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 21 Sep 2015 18:00:20 +0000 (18:00 +0000)
https://bugs.webkit.org/show_bug.cgi?id=149377

Reviewed by Simon Fraser.

* WebKitTestRunner/mac/TestControllerMac.mm:
(WTR::TestController::updatePlatformSpecificTestOptionsForTest):
(WTR::shouldUseThreadedScrolling): Deleted.
Turn on threaded scrolling by default.

* compositing/geometry/fixed-position-flipped-writing-mode.html:
* compositing/layer-creation/no-compositing-for-sticky.html:
* compositing/overflow/automatically-opt-into-composited-scrolling.html:
* compositing/overflow/clipping-ancestor-with-accelerated-scrolling-ancestor.html:
* compositing/overflow/composited-scrolling-creates-a-stacking-container.html:
* compositing/overflow/composited-scrolling-paint-phases.html:
* compositing/overflow/do-not-paint-outline-into-composited-scrolling-contents.html:
* compositing/overflow/dynamic-composited-scrolling-status.html:
* compositing/overflow/iframe-inside-overflow-clipping.html:
* compositing/overflow/nested-scrolling.html:
* compositing/overflow/overflow-clip-with-accelerated-scrolling-ancestor.html:
* compositing/overflow/paint-neg-z-order-descendants-into-scrolling-contents-layer.html:
* compositing/overflow/scrolling-content-clip-to-viewport.html:
* compositing/overflow/scrolling-without-painting.html:
* compositing/overflow/textarea-scroll-touch.html:
* compositing/overflow/updating-scrolling-content.html:
* compositing/rtl/rtl-fixed-overflow-scrolled.html:
* compositing/rtl/rtl-overflow-scrolling.html:
* fast/block/positioning/rtl-fixed-positioning.html:
* fast/block/positioning/vertical-rl/fixed-positioning.html:
* fast/dom/horizontal-scrollbar-in-rtl.html:
* fast/dom/horizontal-scrollbar-when-dir-change.html:
* fast/dom/scroll-reveal-left-overflow.html:
* fast/dom/scroll-reveal-top-overflow.html:
* fast/dom/vertical-scrollbar-when-dir-change.html:
* fast/multicol/pagination/RightToLeft-rl-hittest.html:
* scrollingcoordinator/non-fast-scrollable-region-scaled-iframe.html:
* scrollingcoordinator/non-fast-scrollable-region-transformed-iframe.html:
* swipe/main-frame-pinning-requirement.html:
Turn off threaded scrolling in the cases where it sensibly affects the test result.
These cases are:
        - tests that use scrollTo or similar, and then depend on the
          scrolling happening synchronously

        - tests that use setAcceleratedCompositingForOverflowScrollEnabled,
          which asserts if combined with threaded scrolling

* fast/text/combining-character-sequence-vertical.html:
* fast/text/descent-clip-in-scaled-page.html:
* fast/text/descent-clip-in-scaled-page-expected.html:
* fast/text/vertical-quotation-marks.html:
Turn off threaded scrolling in three tests where it shouldn't affect the test result,
but for some reason does.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190060 268f45cc-cd09-0410-ab3c-d52691b4dbfc

36 files changed:
LayoutTests/ChangeLog
LayoutTests/compositing/geometry/fixed-position-flipped-writing-mode.html
LayoutTests/compositing/layer-creation/no-compositing-for-sticky.html
LayoutTests/compositing/overflow/automatically-opt-into-composited-scrolling.html
LayoutTests/compositing/overflow/clipping-ancestor-with-accelerated-scrolling-ancestor.html
LayoutTests/compositing/overflow/composited-scrolling-creates-a-stacking-container.html
LayoutTests/compositing/overflow/composited-scrolling-paint-phases.html
LayoutTests/compositing/overflow/do-not-paint-outline-into-composited-scrolling-contents.html
LayoutTests/compositing/overflow/dynamic-composited-scrolling-status.html
LayoutTests/compositing/overflow/iframe-inside-overflow-clipping.html
LayoutTests/compositing/overflow/nested-scrolling.html
LayoutTests/compositing/overflow/overflow-clip-with-accelerated-scrolling-ancestor.html
LayoutTests/compositing/overflow/paint-neg-z-order-descendants-into-scrolling-contents-layer.html
LayoutTests/compositing/overflow/scrolling-content-clip-to-viewport.html
LayoutTests/compositing/overflow/scrolling-without-painting.html
LayoutTests/compositing/overflow/textarea-scroll-touch.html
LayoutTests/compositing/overflow/updating-scrolling-content.html
LayoutTests/compositing/rtl/rtl-fixed-overflow-scrolled.html
LayoutTests/compositing/rtl/rtl-overflow-scrolling.html
LayoutTests/fast/block/positioning/rtl-fixed-positioning.html
LayoutTests/fast/block/positioning/vertical-rl/fixed-positioning.html
LayoutTests/fast/dom/horizontal-scrollbar-in-rtl.html
LayoutTests/fast/dom/horizontal-scrollbar-when-dir-change.html
LayoutTests/fast/dom/scroll-reveal-left-overflow.html
LayoutTests/fast/dom/scroll-reveal-top-overflow.html
LayoutTests/fast/dom/vertical-scrollbar-when-dir-change.html
LayoutTests/fast/multicol/pagination/RightToLeft-rl-hittest.html
LayoutTests/fast/text/combining-character-sequence-vertical.html
LayoutTests/fast/text/descent-clip-in-scaled-page-expected.html
LayoutTests/fast/text/descent-clip-in-scaled-page.html
LayoutTests/fast/text/vertical-quotation-marks.html
LayoutTests/scrollingcoordinator/non-fast-scrollable-region-scaled-iframe.html
LayoutTests/scrollingcoordinator/non-fast-scrollable-region-transformed-iframe.html
LayoutTests/swipe/main-frame-pinning-requirement.html
Tools/ChangeLog
Tools/WebKitTestRunner/mac/TestControllerMac.mm

index 1937c8e..9ab7461 100644 (file)
@@ -1,3 +1,54 @@
+2015-09-21  Tim Horton  <timothy_horton@apple.com>
+
+        Turn on threaded scrolling by default in the tests
+        https://bugs.webkit.org/show_bug.cgi?id=149377
+
+        Reviewed by Simon Fraser.
+
+        * compositing/geometry/fixed-position-flipped-writing-mode.html:
+        * compositing/layer-creation/no-compositing-for-sticky.html:
+        * compositing/overflow/automatically-opt-into-composited-scrolling.html:
+        * compositing/overflow/clipping-ancestor-with-accelerated-scrolling-ancestor.html:
+        * compositing/overflow/composited-scrolling-creates-a-stacking-container.html:
+        * compositing/overflow/composited-scrolling-paint-phases.html:
+        * compositing/overflow/do-not-paint-outline-into-composited-scrolling-contents.html:
+        * compositing/overflow/dynamic-composited-scrolling-status.html:
+        * compositing/overflow/iframe-inside-overflow-clipping.html:
+        * compositing/overflow/nested-scrolling.html:
+        * compositing/overflow/overflow-clip-with-accelerated-scrolling-ancestor.html:
+        * compositing/overflow/paint-neg-z-order-descendants-into-scrolling-contents-layer.html:
+        * compositing/overflow/scrolling-content-clip-to-viewport.html:
+        * compositing/overflow/scrolling-without-painting.html:
+        * compositing/overflow/textarea-scroll-touch.html:
+        * compositing/overflow/updating-scrolling-content.html:
+        * compositing/rtl/rtl-fixed-overflow-scrolled.html:
+        * compositing/rtl/rtl-overflow-scrolling.html:
+        * fast/block/positioning/rtl-fixed-positioning.html:
+        * fast/block/positioning/vertical-rl/fixed-positioning.html:
+        * fast/dom/horizontal-scrollbar-in-rtl.html:
+        * fast/dom/horizontal-scrollbar-when-dir-change.html:
+        * fast/dom/scroll-reveal-left-overflow.html:
+        * fast/dom/scroll-reveal-top-overflow.html:
+        * fast/dom/vertical-scrollbar-when-dir-change.html:
+        * fast/multicol/pagination/RightToLeft-rl-hittest.html:
+        * scrollingcoordinator/non-fast-scrollable-region-scaled-iframe.html:
+        * scrollingcoordinator/non-fast-scrollable-region-transformed-iframe.html:
+        * swipe/main-frame-pinning-requirement.html:
+        Turn off threaded scrolling in the cases where it sensibly affects the test result.
+        These cases are:
+                - tests that use scrollTo or similar, and then depend on the
+                  scrolling happening synchronously
+
+                - tests that use setAcceleratedCompositingForOverflowScrollEnabled,
+                  which asserts if combined with threaded scrolling
+
+        * fast/text/combining-character-sequence-vertical.html:
+        * fast/text/descent-clip-in-scaled-page.html:
+        * fast/text/descent-clip-in-scaled-page-expected.html:
+        * fast/text/vertical-quotation-marks.html:
+        Turn off threaded scrolling in three tests where it shouldn't affect the test result,
+        but for some reason does.
+
 2015-09-21  ChangSeok Oh  <changseok.oh@collabora.com>
 
         [GTK] media controls does not show up when playing video finishes.
index 1e67b5d..c6d4c33 100644 (file)
@@ -1,3 +1,4 @@
+<!-- webkit-test-runner [ useThreadedScrolling=false ] -->
 <!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN"
    "http://www.w3.org/TR/html4/loose.dtd">
 
index 6fe6519..fd13d4a 100644 (file)
@@ -1,3 +1,4 @@
+<!-- webkit-test-runner [ useThreadedScrolling=false ] -->
 <html>
 <head>
 <script type="text/javascript">
index 8c75f87..de0ad1b 100644 (file)
@@ -1,3 +1,4 @@
+<!-- webkit-test-runner [ useThreadedScrolling=false ] -->
 <html dir=rtl>
     <head>
         <script language="javascript">
index 4701712..19875d6 100644 (file)
@@ -1,3 +1,4 @@
+<!-- webkit-test-runner [ useThreadedScrolling=false ] -->
 <html>
     <head>
         <script>
index 3078158..482bbea 100644 (file)
@@ -1,3 +1,4 @@
+<!-- webkit-test-runner [ useThreadedScrolling=false ] -->
 <html dir=rtl style="-webkit-writing-mode:vertical-lr">
     <head>
         <script>
index bf3d5a3..7822a61 100644 (file)
@@ -1,3 +1,5 @@
+<!-- webkit-test-runner [ useThreadedScrolling=false ] -->
+<!-- FIXME: It's not clear why threaded scrolling causes this test to fail. -->
 <div style="width: 100px; font-family: 'geeza pro'; font-size: 48px; -webkit-writing-mode: vertical-rl;">
     &#x0628;&#x062d;&#x0653;
 </div>
index 90bbe50..c8bce7e 100644 (file)
@@ -1,3 +1,5 @@
+<!-- webkit-test-runner [ useThreadedScrolling=false ] -->
+<!-- FIXME: It's not clear why threaded scrolling causes this test to fail. -->
 <!DOCTYPE html>
 <html>
 <head>
index b2c86ef..fd85628 100644 (file)
@@ -1,3 +1,6 @@
+<!-- webkit-test-runner [ useThreadedScrolling=false ] -->
+<!-- FIXME: It's not clear why threaded scrolling causes this test to fail. -->
+<!-- Please note that the expected file also has threaded scrolling turned off. -->
 <!DOCTYPE html>
 <html>
 <head>
index 0366350..5bf2445 100644 (file)
@@ -1,3 +1,5 @@
+<!-- webkit-test-runner [ useThreadedScrolling=false ] -->
+<!-- FIXME: It's not clear why threaded scrolling causes this test to fail. -->
 <!DOCTYPE html>
 <html>
 <head>
index 9aa7afb..6215544 100644 (file)
@@ -1,7 +1,3 @@
-<!-- webkit-test-runner [ useThreadedScrolling=true ] -->
-<!-- This test has to use threaded scrolling because we don't
-properly support swipe pinning with the antique scrolling path. -->
-
 <head>
 <style>
 html {
index 076692c..93e1f93 100644 (file)
@@ -1,3 +1,15 @@
+2015-09-21  Tim Horton  <timothy_horton@apple.com>
+
+        Turn on threaded scrolling by default in the tests
+        https://bugs.webkit.org/show_bug.cgi?id=149377
+
+        Reviewed by Simon Fraser.
+
+        * WebKitTestRunner/mac/TestControllerMac.mm:
+        (WTR::TestController::updatePlatformSpecificTestOptionsForTest):
+        (WTR::shouldUseThreadedScrolling): Deleted.
+        Turn on threaded scrolling by default.
+
 2015-09-21  Carlos Garcia Campos  <cgarcia@igalia.com>
 
         [GTK] run-gtk-tests doesn't provide feedback about crashing google tests
index af393b2..11c5e85 100644 (file)
@@ -77,11 +77,6 @@ void TestController::initializeTestPluginDirectory()
     m_testPluginDirectory.adopt(WKStringCreateWithCFString((CFStringRef)[[NSBundle mainBundle] bundlePath]));
 }
 
-static bool shouldUseThreadedScrolling(const TestInvocation& test)
-{
-    return test.urlContains("tiled-drawing/");
-}
-
 void TestController::platformResetPreferencesToConsistentValues()
 {
 }
@@ -97,7 +92,7 @@ void TestController::platformResetStateToConsistentValues()
 
 void TestController::updatePlatformSpecificTestOptionsForTest(TestOptions& options, const TestInvocation& test) const
 {
-    options.useThreadedScrolling = shouldUseThreadedScrolling(test);
+    options.useThreadedScrolling = true;
     options.useRemoteLayerTree = shouldUseRemoteLayerTree();
     options.shouldShowWebView = shouldShowWebView();
 }