https://bugs.webkit.org/show_bug.cgi?id=149377
Reviewed by Simon Fraser.
* WebKitTestRunner/mac/TestControllerMac.mm:
(WTR::TestController::updatePlatformSpecificTestOptionsForTest):
(WTR::shouldUseThreadedScrolling): Deleted.
Turn on threaded scrolling by default.
* compositing/geometry/fixed-position-flipped-writing-mode.html:
* compositing/layer-creation/no-compositing-for-sticky.html:
* compositing/overflow/automatically-opt-into-composited-scrolling.html:
* compositing/overflow/clipping-ancestor-with-accelerated-scrolling-ancestor.html:
* compositing/overflow/composited-scrolling-creates-a-stacking-container.html:
* compositing/overflow/composited-scrolling-paint-phases.html:
* compositing/overflow/do-not-paint-outline-into-composited-scrolling-contents.html:
* compositing/overflow/dynamic-composited-scrolling-status.html:
* compositing/overflow/iframe-inside-overflow-clipping.html:
* compositing/overflow/nested-scrolling.html:
* compositing/overflow/overflow-clip-with-accelerated-scrolling-ancestor.html:
* compositing/overflow/paint-neg-z-order-descendants-into-scrolling-contents-layer.html:
* compositing/overflow/scrolling-content-clip-to-viewport.html:
* compositing/overflow/scrolling-without-painting.html:
* compositing/overflow/textarea-scroll-touch.html:
* compositing/overflow/updating-scrolling-content.html:
* compositing/rtl/rtl-fixed-overflow-scrolled.html:
* compositing/rtl/rtl-overflow-scrolling.html:
* fast/block/positioning/rtl-fixed-positioning.html:
* fast/block/positioning/vertical-rl/fixed-positioning.html:
* fast/dom/horizontal-scrollbar-in-rtl.html:
* fast/dom/horizontal-scrollbar-when-dir-change.html:
* fast/dom/scroll-reveal-left-overflow.html:
* fast/dom/scroll-reveal-top-overflow.html:
* fast/dom/vertical-scrollbar-when-dir-change.html:
* fast/multicol/pagination/RightToLeft-rl-hittest.html:
* scrollingcoordinator/non-fast-scrollable-region-scaled-iframe.html:
* scrollingcoordinator/non-fast-scrollable-region-transformed-iframe.html:
* swipe/main-frame-pinning-requirement.html:
Turn off threaded scrolling in the cases where it sensibly affects the test result.
These cases are:
- tests that use scrollTo or similar, and then depend on the
scrolling happening synchronously
- tests that use setAcceleratedCompositingForOverflowScrollEnabled,
which asserts if combined with threaded scrolling
* fast/text/combining-character-sequence-vertical.html:
* fast/text/descent-clip-in-scaled-page.html:
* fast/text/descent-clip-in-scaled-page-expected.html:
* fast/text/vertical-quotation-marks.html:
Turn off threaded scrolling in three tests where it shouldn't affect the test result,
but for some reason does.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@190060
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
+2015-09-21 Tim Horton <timothy_horton@apple.com>
+
+ Turn on threaded scrolling by default in the tests
+ https://bugs.webkit.org/show_bug.cgi?id=149377
+
+ Reviewed by Simon Fraser.
+
+ * compositing/geometry/fixed-position-flipped-writing-mode.html:
+ * compositing/layer-creation/no-compositing-for-sticky.html:
+ * compositing/overflow/automatically-opt-into-composited-scrolling.html:
+ * compositing/overflow/clipping-ancestor-with-accelerated-scrolling-ancestor.html:
+ * compositing/overflow/composited-scrolling-creates-a-stacking-container.html:
+ * compositing/overflow/composited-scrolling-paint-phases.html:
+ * compositing/overflow/do-not-paint-outline-into-composited-scrolling-contents.html:
+ * compositing/overflow/dynamic-composited-scrolling-status.html:
+ * compositing/overflow/iframe-inside-overflow-clipping.html:
+ * compositing/overflow/nested-scrolling.html:
+ * compositing/overflow/overflow-clip-with-accelerated-scrolling-ancestor.html:
+ * compositing/overflow/paint-neg-z-order-descendants-into-scrolling-contents-layer.html:
+ * compositing/overflow/scrolling-content-clip-to-viewport.html:
+ * compositing/overflow/scrolling-without-painting.html:
+ * compositing/overflow/textarea-scroll-touch.html:
+ * compositing/overflow/updating-scrolling-content.html:
+ * compositing/rtl/rtl-fixed-overflow-scrolled.html:
+ * compositing/rtl/rtl-overflow-scrolling.html:
+ * fast/block/positioning/rtl-fixed-positioning.html:
+ * fast/block/positioning/vertical-rl/fixed-positioning.html:
+ * fast/dom/horizontal-scrollbar-in-rtl.html:
+ * fast/dom/horizontal-scrollbar-when-dir-change.html:
+ * fast/dom/scroll-reveal-left-overflow.html:
+ * fast/dom/scroll-reveal-top-overflow.html:
+ * fast/dom/vertical-scrollbar-when-dir-change.html:
+ * fast/multicol/pagination/RightToLeft-rl-hittest.html:
+ * scrollingcoordinator/non-fast-scrollable-region-scaled-iframe.html:
+ * scrollingcoordinator/non-fast-scrollable-region-transformed-iframe.html:
+ * swipe/main-frame-pinning-requirement.html:
+ Turn off threaded scrolling in the cases where it sensibly affects the test result.
+ These cases are:
+ - tests that use scrollTo or similar, and then depend on the
+ scrolling happening synchronously
+
+ - tests that use setAcceleratedCompositingForOverflowScrollEnabled,
+ which asserts if combined with threaded scrolling
+
+ * fast/text/combining-character-sequence-vertical.html:
+ * fast/text/descent-clip-in-scaled-page.html:
+ * fast/text/descent-clip-in-scaled-page-expected.html:
+ * fast/text/vertical-quotation-marks.html:
+ Turn off threaded scrolling in three tests where it shouldn't affect the test result,
+ but for some reason does.
+
2015-09-21 ChangSeok Oh <changseok.oh@collabora.com>
[GTK] media controls does not show up when playing video finishes.
+<!-- webkit-test-runner [ useThreadedScrolling=false ] -->
<!DOCTYPE html>
<html>
+<!-- webkit-test-runner [ useThreadedScrolling=false ] -->
<!DOCTYPE html>
<html>
+<!-- webkit-test-runner [ useThreadedScrolling=false ] -->
<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN"
"http://www.w3.org/TR/html4/loose.dtd">
+<!-- webkit-test-runner [ useThreadedScrolling=false ] -->
<!DOCTYPE html>
<html>
<head>
+<!-- webkit-test-runner [ useThreadedScrolling=false ] -->
<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN"
"http://www.w3.org/TR/html4/loose.dtd">
+<!-- webkit-test-runner [ useThreadedScrolling=false ] -->
<!DOCTYPE html>
<html lang="en">
<head>
+<!-- webkit-test-runner [ useThreadedScrolling=false ] -->
<!DOCTYPE html>
<html lang="en">
<head>
+<!-- webkit-test-runner [ useThreadedScrolling=false ] -->
<!DOCTYPE html>
<html>
<head>
+<!-- webkit-test-runner [ useThreadedScrolling=false ] -->
<!DOCTYPE html>
<html>
<head>
+<!-- webkit-test-runner [ useThreadedScrolling=false ] -->
<!DOCTYPE html>
<html>
+<!-- webkit-test-runner [ useThreadedScrolling=false ] -->
<!DOCTYPE html>
<html>
<head>
+<!-- webkit-test-runner [ useThreadedScrolling=false ] -->
<!DOCTYPE html>
<html lang="en">
<head>
+<!-- webkit-test-runner [ useThreadedScrolling=false ] -->
<!DOCTYPE html>
<html>
<head>
+<!-- webkit-test-runner [ useThreadedScrolling=false ] -->
<!DOCTYPE html>
<!--
+<!-- webkit-test-runner [ useThreadedScrolling=false ] -->
<!DOCTYPE html>
<html>
<head>
+<!-- webkit-test-runner [ useThreadedScrolling=false ] -->
<!DOCTYPE html>
<!--
+<!-- webkit-test-runner [ useThreadedScrolling=false ] -->
<html>
<head>
<style>
+<!-- webkit-test-runner [ useThreadedScrolling=false ] -->
<html>
<head>
<script type="text/javascript">
+<!-- webkit-test-runner [ useThreadedScrolling=false ] -->
<!doctype html>
<html dir='rtl'>
<head>
+<!-- webkit-test-runner [ useThreadedScrolling=false ] -->
<!doctype html>
<html dir="rtl">
<head>
+<!-- webkit-test-runner [ useThreadedScrolling=false ] -->
<html dir=rtl>
<head>
<script language="javascript">
+<!-- webkit-test-runner [ useThreadedScrolling=false ] -->
<html>
<head>
<script>
+<!-- webkit-test-runner [ useThreadedScrolling=false ] -->
<html>
<head>
<script>
+<!-- webkit-test-runner [ useThreadedScrolling=false ] -->
<html dir=rtl style="-webkit-writing-mode:vertical-lr">
<head>
<script>
+<!-- webkit-test-runner [ useThreadedScrolling=false ] -->
<html>
<head>
<script>
+<!-- webkit-test-runner [ useThreadedScrolling=false ] -->
<!DOCTYPE html>
<html>
+<!-- webkit-test-runner [ useThreadedScrolling=false ] -->
+<!-- FIXME: It's not clear why threaded scrolling causes this test to fail. -->
<div style="width: 100px; font-family: 'geeza pro'; font-size: 48px; -webkit-writing-mode: vertical-rl;">
بحٓ
</div>
+<!-- webkit-test-runner [ useThreadedScrolling=false ] -->
+<!-- FIXME: It's not clear why threaded scrolling causes this test to fail. -->
<!DOCTYPE html>
<html>
<head>
+<!-- webkit-test-runner [ useThreadedScrolling=false ] -->
+<!-- FIXME: It's not clear why threaded scrolling causes this test to fail. -->
+<!-- Please note that the expected file also has threaded scrolling turned off. -->
<!DOCTYPE html>
<html>
<head>
+<!-- webkit-test-runner [ useThreadedScrolling=false ] -->
+<!-- FIXME: It's not clear why threaded scrolling causes this test to fail. -->
<!DOCTYPE html>
<html>
<head>
+<!-- webkit-test-runner [ useThreadedScrolling=false ] -->
<!DOCTYPE html>
<html>
<head>
+<!-- webkit-test-runner [ useThreadedScrolling=false ] -->
<!DOCTYPE html>
<html>
<head>
-<!-- webkit-test-runner [ useThreadedScrolling=true ] -->
-<!-- This test has to use threaded scrolling because we don't
-properly support swipe pinning with the antique scrolling path. -->
-
<head>
<style>
html {
+2015-09-21 Tim Horton <timothy_horton@apple.com>
+
+ Turn on threaded scrolling by default in the tests
+ https://bugs.webkit.org/show_bug.cgi?id=149377
+
+ Reviewed by Simon Fraser.
+
+ * WebKitTestRunner/mac/TestControllerMac.mm:
+ (WTR::TestController::updatePlatformSpecificTestOptionsForTest):
+ (WTR::shouldUseThreadedScrolling): Deleted.
+ Turn on threaded scrolling by default.
+
2015-09-21 Carlos Garcia Campos <cgarcia@igalia.com>
[GTK] run-gtk-tests doesn't provide feedback about crashing google tests
m_testPluginDirectory.adopt(WKStringCreateWithCFString((CFStringRef)[[NSBundle mainBundle] bundlePath]));
}
-static bool shouldUseThreadedScrolling(const TestInvocation& test)
-{
- return test.urlContains("tiled-drawing/");
-}
-
void TestController::platformResetPreferencesToConsistentValues()
{
}
void TestController::updatePlatformSpecificTestOptionsForTest(TestOptions& options, const TestInvocation& test) const
{
- options.useThreadedScrolling = shouldUseThreadedScrolling(test);
+ options.useThreadedScrolling = true;
options.useRemoteLayerTree = shouldUseRemoteLayerTree();
options.shouldShowWebView = shouldShowWebView();
}