Web Inspector: remove unused WI.DOMTreeDataGrid
authordrousso@apple.com <drousso@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 16 Apr 2019 19:37:27 +0000 (19:37 +0000)
committerdrousso@apple.com <drousso@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 16 Apr 2019 19:37:27 +0000 (19:37 +0000)
https://bugs.webkit.org/show_bug.cgi?id=196958
<rdar://problem/49931383>

Reviewed by Joseph Pecoraro.

* UserInterface/Views/DOMTreeDataGrid.css: Removed.
* UserInterface/Views/DOMTreeDataGrid.js: Removed.
* UserInterface/Views/DOMTreeDataGridNode.js: Removed.
* UserInterface/Main.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@244351 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/WebInspectorUI/ChangeLog
Source/WebInspectorUI/UserInterface/Main.html
Source/WebInspectorUI/UserInterface/Views/DOMTreeDataGrid.css [deleted file]
Source/WebInspectorUI/UserInterface/Views/DOMTreeDataGrid.js [deleted file]
Source/WebInspectorUI/UserInterface/Views/DOMTreeDataGridNode.js [deleted file]

index ad40971..26f6727 100644 (file)
@@ -1,5 +1,18 @@
 2019-04-16  Devin Rousso  <drousso@apple.com>
 
+        Web Inspector: remove unused WI.DOMTreeDataGrid
+        https://bugs.webkit.org/show_bug.cgi?id=196958
+        <rdar://problem/49931383>
+
+        Reviewed by Joseph Pecoraro.
+
+        * UserInterface/Views/DOMTreeDataGrid.css: Removed.
+        * UserInterface/Views/DOMTreeDataGrid.js: Removed.
+        * UserInterface/Views/DOMTreeDataGridNode.js: Removed.
+        * UserInterface/Main.html:
+
+2019-04-16  Devin Rousso  <drousso@apple.com>
+
         Web Inspector: Storage: values truncated in Local/Session table
         https://bugs.webkit.org/show_bug.cgi?id=178318
         <rdar://problem/34998581>
index 4f7a2d0..981655e 100644 (file)
@@ -83,7 +83,6 @@
     <link rel="stylesheet" href="Views/DOMNodeTreeElement.css">
     <link rel="stylesheet" href="Views/DOMStorageContentView.css">
     <link rel="stylesheet" href="Views/DOMTreeContentView.css">
-    <link rel="stylesheet" href="Views/DOMTreeDataGrid.css">
     <link rel="stylesheet" href="Views/DOMTreeOutline.css">
     <link rel="stylesheet" href="Views/DashboardContainerView.css">
     <link rel="stylesheet" href="Views/DataGrid.css">
     <script src="Views/DOMNodeTreeElement.js"></script>
     <script src="Views/DOMStorageContentView.js"></script>
     <script src="Views/DOMStorageTreeElement.js"></script>
-    <script src="Views/DOMTreeDataGrid.js"></script>
-    <script src="Views/DOMTreeDataGridNode.js"></script>
     <script src="Views/DOMTreeElement.js"></script>
     <script src="Views/DOMTreeElementPathComponent.js"></script>
     <script src="Views/DOMTreeOutline.js"></script>
diff --git a/Source/WebInspectorUI/UserInterface/Views/DOMTreeDataGrid.css b/Source/WebInspectorUI/UserInterface/Views/DOMTreeDataGrid.css
deleted file mode 100644 (file)
index f8fbee3..0000000
+++ /dev/null
@@ -1,35 +0,0 @@
-/*
- * Copyright (C) 2013 Apple Inc. All rights reserved.
- *
- * Redistribution and use in source and binary forms, with or without
- * modification, are permitted provided that the following conditions
- * are met:
- * 1. Redistributions of source code must retain the above copyright
- *    notice, this list of conditions and the following disclaimer.
- * 2. Redistributions in binary form must reproduce the above copyright
- *    notice, this list of conditions and the following disclaimer in the
- *    documentation and/or other materials provided with the distribution.
- *
- * THIS SOFTWARE IS PROVIDED BY APPLE INC. AND ITS CONTRIBUTORS ``AS IS''
- * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO,
- * THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
- * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR ITS CONTRIBUTORS
- * BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
- * CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
- * SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
- * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
- * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
- * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF
- * THE POSSIBILITY OF SUCH DAMAGE.
- */
-
-.dom-tree-data-grid .data-grid {
-    border-right: none;
-    border-left: none;
-    border-bottom: none;
-}
-
-.dom-tree-data-grid .name-column .icon {
-    /* FIXME: There can be multiple types of DOM nodes that we might need to support in the future. */
-    content: url(../Images/DOMElement.svg);
-}
diff --git a/Source/WebInspectorUI/UserInterface/Views/DOMTreeDataGrid.js b/Source/WebInspectorUI/UserInterface/Views/DOMTreeDataGrid.js
deleted file mode 100644 (file)
index b8cda5b..0000000
+++ /dev/null
@@ -1,62 +0,0 @@
-/*
- * Copyright (C) 2013 Adobe Systems Inc. All rights reserved.
- * Copyright (C) 2015 Apple Inc. All rights reserved.
- *
- * Redistribution and use in source and binary forms, with or without
- * modification, are permitted provided that the following conditions
- * are met:
- * 1. Redistributions of source code must retain the above copyright
- *    notice, this list of conditions and the following disclaimer.
- * 2. Redistributions in binary form must reproduce the above copyright
- *    notice, this list of conditions and the following disclaimer in the
- *    documentation and/or other materials provided with the distribution.
- *
- * THIS SOFTWARE IS PROVIDED BY APPLE INC. AND ITS CONTRIBUTORS ``AS IS''
- * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO,
- * THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
- * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR ITS CONTRIBUTORS
- * BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
- * CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
- * SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
- * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
- * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
- * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF
- * THE POSSIBILITY OF SUCH DAMAGE.
- */
-
-WI.DOMTreeDataGrid = class DOMTreeDataGrid extends WI.DataGrid
-{
-    constructor()
-    {
-        super({
-            name: {title: WI.UIString("Node"), sortable: false, icon: true}
-        });
-
-        this._previousHoveredElement = null;
-
-        this.inline = true;
-
-        this.element.classList.add("dom-tree-data-grid");
-
-        this.element.addEventListener("mousemove", this._onmousemove.bind(this), false);
-        this.element.addEventListener("mouseout", this._onmouseout.bind(this), false);
-    }
-
-    // Private
-
-    _onmousemove(event)
-    {
-        var gridNode = this.dataGridNodeFromNode(event.target);
-        if (!gridNode || this._previousHoveredElement === gridNode.domNode)
-            return;
-        this._previousHoveredElement = gridNode.domNode;
-        WI.domManager.highlightDOMNode(gridNode.domNode.id);
-    }
-
-    _onmouseout(event) {
-        if (!this._previousHoveredElement)
-            return;
-        WI.domManager.hideDOMNodeHighlight();
-        this._previousHoveredElement = null;
-    }
-};
diff --git a/Source/WebInspectorUI/UserInterface/Views/DOMTreeDataGridNode.js b/Source/WebInspectorUI/UserInterface/Views/DOMTreeDataGridNode.js
deleted file mode 100644 (file)
index 635dbda..0000000
+++ /dev/null
@@ -1,69 +0,0 @@
-/*
- * Copyright (C) 2013 Adobe Systems Inc. All rights reserved.
- * Copyright (C) 2015 Apple Inc. All rights reserved.
- *
- * Redistribution and use in source and binary forms, with or without
- * modification, are permitted provided that the following conditions
- * are met:
- * 1. Redistributions of source code must retain the above copyright
- *    notice, this list of conditions and the following disclaimer.
- * 2. Redistributions in binary form must reproduce the above copyright
- *    notice, this list of conditions and the following disclaimer in the
- *    documentation and/or other materials provided with the distribution.
- *
- * THIS SOFTWARE IS PROVIDED BY APPLE INC. AND ITS CONTRIBUTORS ``AS IS''
- * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO,
- * THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR
- * PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL APPLE INC. OR ITS CONTRIBUTORS
- * BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR
- * CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF
- * SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS
- * INTERRUPTION) HOWEVER CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN
- * CONTRACT, STRICT LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE)
- * ARISING IN ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF
- * THE POSSIBILITY OF SUCH DAMAGE.
- */
-
-WI.DOMTreeDataGridNode = class DOMTreeDataGridNode extends WI.DataGridNode
-{
-    constructor(domNode)
-    {
-        super();
-
-        this._domNode = domNode;
-    }
-
-    get domNode()
-    {
-        return this._domNode;
-    }
-
-    // DataGridNode Overrides.
-
-    createCellContent(columnIdentifier, cell)
-    {
-        if (columnIdentifier !== "name")
-            return super.createCellContent(columnIdentifier, cell);
-
-        return this._createNameCellDocumentFragment();
-    }
-
-    // Private
-
-    _createNameCellDocumentFragment()
-    {
-        let fragment = document.createDocumentFragment();
-        let mainTitle = this._domNode.displayName;
-        fragment.append(mainTitle);
-
-        let goToButton = fragment.appendChild(WI.createGoToArrowButton());
-        goToButton.addEventListener("click", this._goToArrowWasClicked.bind(this), false);
-
-        return fragment;
-    }
-
-    _goToArrowWasClicked()
-    {
-        WI.showMainFrameDOMTree(this._domNode, {ignoreSearchTab: true});
-    }
-};