Rename sortFileName{Ascending,Descending} to
authortimothy@apple.com <timothy@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 20 May 2008 17:12:10 +0000 (17:12 +0000)
committertimothy@apple.com <timothy@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 20 May 2008 17:12:10 +0000 (17:12 +0000)
sortFunctionName{Ascending,Descending}.

Reviewed by Kevin McCullough.

* JavaScriptCore.exp:
* kjs/config.h:
* profiler/Profile.h:
* profiler/ProfileNode.cpp:
(KJS::functionNameDescendingComparator):
(KJS::ProfileNode::sortFunctionNameDescending):
(KJS::functionNameAscendingComparator):
(KJS::ProfileNode::sortFunctionNameAscending):
* profiler/ProfileNode.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@33935 268f45cc-cd09-0410-ab3c-d52691b4dbfc

JavaScriptCore/ChangeLog
JavaScriptCore/JavaScriptCore.exp
JavaScriptCore/profiler/Profile.h
JavaScriptCore/profiler/ProfileNode.cpp
JavaScriptCore/profiler/ProfileNode.h

index e2fdfec..cf35e5f 100644 (file)
@@ -1,3 +1,20 @@
+2008-05-20  Timothy Hatcher  <timothy@apple.com>
+
+        Rename sortFileName{Ascending,Descending} to
+        sortFunctionName{Ascending,Descending}.
+
+        Reviewed by Kevin McCullough.
+
+        * JavaScriptCore.exp:
+        * kjs/config.h:
+        * profiler/Profile.h:
+        * profiler/ProfileNode.cpp:
+        (KJS::functionNameDescendingComparator):
+        (KJS::ProfileNode::sortFunctionNameDescending):
+        (KJS::functionNameAscendingComparator):
+        (KJS::ProfileNode::sortFunctionNameAscending):
+        * profiler/ProfileNode.h:
+
 2008-05-19  Timothy Hatcher  <timothy@apple.com>
 
         Make the profiler use higher than millisecond resolution time-stamps.
index 2ffd0ea..04806c6 100644 (file)
@@ -94,11 +94,11 @@ __ZN3KJS11JSImmediate8toStringEPKNS_7JSValueE
 __ZN3KJS11ProfileNode18sortCallsAscendingEv
 __ZN3KJS11ProfileNode19sortCallsDescendingEv
 __ZN3KJS11ProfileNode21sortSelfTimeAscendingEv
-__ZN3KJS11ProfileNode21sortFileNameAscendingEv
-__ZN3KJS11ProfileNode22sortFileNameDescendingEv
 __ZN3KJS11ProfileNode22sortSelfTimeDescendingEv
 __ZN3KJS11ProfileNode22sortTotalTimeAscendingEv
 __ZN3KJS11ProfileNode23sortTotalTimeDescendingEv
+__ZN3KJS11ProfileNode25sortFunctionNameAscendingEv
+__ZN3KJS11ProfileNode26sortFunctionNameDescendingEv
 __ZN3KJS11ProgramNode6createEPNS_14SourceElementsEPN3WTF6VectorISt4pairINS_10IdentifierEjELm16EEEPNS4_IPNS_12FuncDeclNodeELm16EEEbb
 __ZN3KJS11PropertyMap11getLocationERKNS_10IdentifierE
 __ZN3KJS11PropertyMap5clearEv
index 225c824..bd53d9b 100644 (file)
@@ -55,8 +55,8 @@ namespace KJS {
         void sortSelfTimeAscending() { m_callTree->sortSelfTimeAscending(); }
         void sortCallsDescending() { m_callTree->sortCallsDescending(); }
         void sortCallsAscending() { m_callTree->sortCallsAscending(); }
-        void sortFileNameDescending() { m_callTree->sortFileNameDescending(); }
-        void sortFileNameAscending() { m_callTree->sortFileNameAscending(); }
+        void sortFunctionNameDescending() { m_callTree->sortFunctionNameDescending(); }
+        void sortFunctionNameAscending() { m_callTree->sortFunctionNameAscending(); }
         
         void printDataInspectorStyle() const;
         void printDataSampleStyle() const;
index 508230d..0c4e756 100644 (file)
@@ -192,30 +192,30 @@ void ProfileNode::sortCallsAscending()
         (*currentChild)->sortCallsAscending();
 }
 
-static inline bool fileNameDescendingComparator(const RefPtr<ProfileNode>& a, const RefPtr<ProfileNode>& b)
+static inline bool functionNameDescendingComparator(const RefPtr<ProfileNode>& a, const RefPtr<ProfileNode>& b)
 {
     return compare(a->functionName(), b->functionName()) == 1 ? true : false ;
 }
 
-void ProfileNode::sortFileNameDescending()
+void ProfileNode::sortFunctionNameDescending()
 {
-    std::sort(m_children.begin(), m_children.end(), fileNameDescendingComparator);
+    std::sort(m_children.begin(), m_children.end(), functionNameDescendingComparator);
 
     for (StackIterator currentChild = m_children.begin(); currentChild != m_children.end(); ++currentChild)
-        (*currentChild)->sortFileNameDescending();
+        (*currentChild)->sortFunctionNameDescending();
 }
 
-static inline bool fileNameAscendingComparator(const RefPtr<ProfileNode>& a, const RefPtr<ProfileNode>& b)
+static inline bool functionNameAscendingComparator(const RefPtr<ProfileNode>& a, const RefPtr<ProfileNode>& b)
 {
     return compare(a->functionName(), b->functionName()) == -1 ? true : false ;
 }
 
-void ProfileNode::sortFileNameAscending()
+void ProfileNode::sortFunctionNameAscending()
 {
-    std::sort(m_children.begin(), m_children.end(), fileNameAscendingComparator);
+    std::sort(m_children.begin(), m_children.end(), functionNameAscendingComparator);
 
     for (StackIterator currentChild = m_children.begin(); currentChild != m_children.end(); ++currentChild)
-        (*currentChild)->sortFileNameAscending();
+        (*currentChild)->sortFunctionNameAscending();
 }
 
 void ProfileNode::endAndRecordCall()
index 46887f2..51de279 100644 (file)
@@ -69,8 +69,8 @@ namespace KJS {
         void sortSelfTimeAscending();
         void sortCallsDescending();
         void sortCallsAscending();
-        void sortFileNameDescending();
-        void sortFileNameAscending();
+        void sortFunctionNameDescending();
+        void sortFunctionNameAscending();
 
         void endAndRecordCall();