[V8] Remove GenerateSetDOMException() from CodeGeneratorV8.pm
authorharaken@chromium.org <haraken@chromium.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 22 May 2012 15:57:04 +0000 (15:57 +0000)
committerharaken@chromium.org <haraken@chromium.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Tue, 22 May 2012 15:57:04 +0000 (15:57 +0000)
https://bugs.webkit.org/show_bug.cgi?id=87114

Reviewed by Nate Chapin.

GenerateSetDOMException() is used by only one place. This patch removes it.

No tests. No change in behavior.

* bindings/scripts/CodeGeneratorV8.pm:
(GenerateNormalAttrGetter):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117979 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Source/WebCore/ChangeLog
Source/WebCore/bindings/scripts/CodeGeneratorV8.pm

index 203e69a..666c4bf 100644 (file)
@@ -1,3 +1,17 @@
+2012-05-22  Kentaro Hara  <haraken@chromium.org>
+
+        [V8] Remove GenerateSetDOMException() from CodeGeneratorV8.pm
+        https://bugs.webkit.org/show_bug.cgi?id=87114
+
+        Reviewed by Nate Chapin.
+
+        GenerateSetDOMException() is used by only one place. This patch removes it.
+
+        No tests. No change in behavior.
+
+        * bindings/scripts/CodeGeneratorV8.pm:
+        (GenerateNormalAttrGetter):
+
 2012-05-22  David Grogan  <dgrogan@chromium.org>
 
         IndexedDB: Fire error when there are problems opening a DB
index f3bed83..4a9df4f 100644 (file)
@@ -644,17 +644,6 @@ sub GenerateHeaderCustomCall
     }
 }
 
-sub GenerateSetDOMException
-{
-    my $indent = shift;
-    my $getIsolate = shift;
-    my $result = "";
-
-    $result .= $indent . "if (UNLIKELY(ec))\n";
-    $result .= $indent . "    return V8Proxy::setDOMException(ec, $getIsolate);\n";
-    return $result;
-}
-
 sub IsSubType
 {
     my $dataNode = shift;
@@ -898,7 +887,8 @@ END
         } else {
             push(@implContentDecls, "    $nativeType v = $getterString;\n");
         }
-        push(@implContentDecls, GenerateSetDOMException("    ", "info.GetIsolate()"));
+        push(@implContentDecls, "    if (UNLIKELY(ec))\n");
+        push(@implContentDecls, "        return V8Proxy::setDOMException(ec, info.GetIsolate());\n");
 
         if ($codeGenerator->ExtendedAttributeContains($attribute->signature->extendedAttributes->{"CallWith"}, "ScriptState")) {
             push(@implContentDecls, "    if (state.hadException())\n");