results.webkit.org: Show results which are missing expectations
authorjbedard@apple.com <jbedard@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 28 Oct 2019 20:50:47 +0000 (20:50 +0000)
committerjbedard@apple.com <jbedard@apple.com@268f45cc-cd09-0410-ab3c-d52691b4dbfc>
Mon, 28 Oct 2019 20:50:47 +0000 (20:50 +0000)
https://bugs.webkit.org/show_bug.cgi?id=203494
<rdar://problem/56436643>

Reviewed by Aakash Jain.

* resultsdbpy/resultsdbpy/view/static/css/timeline.css:
(.dot.warning): Add warning dot with dark-orange color.
* resultsdbpy/resultsdbpy/view/static/js/expectations.js:
(Expectations.colorMap): Add warning.
(Expectations.failureTypes): Ditto.
(Expectations.failureTypeMap): Ditto.
(Expectations.symbolMap): Ditto.
* resultsdbpy/resultsdbpy/view/static/js/timeline.js:
(Legend): Add warning bubble.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@251670 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Tools/ChangeLog
Tools/resultsdbpy/resultsdbpy/view/static/css/timeline.css
Tools/resultsdbpy/resultsdbpy/view/static/js/expectations.js
Tools/resultsdbpy/resultsdbpy/view/static/js/timeline.js

index 799eb1e..726a7d8 100644 (file)
@@ -1,3 +1,21 @@
+2019-10-28  Jonathan Bedard  <jbedard@apple.com>
+
+        results.webkit.org: Show results which are missing expectations
+        https://bugs.webkit.org/show_bug.cgi?id=203494
+        <rdar://problem/56436643>
+
+        Reviewed by Aakash Jain.
+
+        * resultsdbpy/resultsdbpy/view/static/css/timeline.css:
+        (.dot.warning): Add warning dot with dark-orange color.
+        * resultsdbpy/resultsdbpy/view/static/js/expectations.js:
+        (Expectations.colorMap): Add warning.
+        (Expectations.failureTypes): Ditto.
+        (Expectations.failureTypeMap): Ditto.
+        (Expectations.symbolMap): Ditto.
+        * resultsdbpy/resultsdbpy/view/static/js/timeline.js:
+        (Legend): Add warning bubble.
+
 2019-10-28  John Wilander  <wilander@apple.com>
 
         Storage Access API: Make the API work with the experimental 3rd-party cookie blocking
index ed8f1cb..a72a012 100644 (file)
  * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
  */
 
+.dot.warning {
+    background-color: var(--orangeDark);
+}
+
 .dot.timedout {
     background-color: var(--orangeLight);
 }
index fc387b2..811de7c 100644 (file)
@@ -27,6 +27,7 @@ class Expectations
         const computedStyle = getComputedStyle(document.body);
         return {
             success: computedStyle.getPropertyValue('--greenLight').trim(),
+            warning: computedStyle.getPropertyValue('--orangeDark').trim(),
             failed: computedStyle.getPropertyValue('--redLight').trim(),
             timedout: computedStyle.getPropertyValue('--orangeLight').trim(),
             crashed: computedStyle.getPropertyValue('--purpleLight').trim(),
@@ -87,8 +88,9 @@ Expectations.stateToIdMap = {
     WARNING: 0x38,
     PASS: 0x40,
 };
-Expectations.failureTypes = ['failed', 'timedout', 'crashed'];
+Expectations.failureTypes = ['warning', 'failed', 'timedout', 'crashed'];
 Expectations.failureTypeMap = {
+    warning: 'WARNING',
     failed: 'ERROR',
     timedout: 'TIMEOUT',
     crashed: 'CRASH',
@@ -100,6 +102,7 @@ timeoutImage.toString = function () {
 }
 Expectations.symbolMap = {
     success: '✓',
+    warning: '?',
     failed: '𝖷',
     timedout: timeoutImage,
     crashed: '!',
index 611bc72..2a45b13 100644 (file)
@@ -829,6 +829,10 @@ function Legend(callback=null, plural=false) {
             expected: plural ? 'No unexpected results' : 'Result expected',
             unexpected: plural ? 'All tests passed' : 'Test passed',
         },
+        warning: {
+            expected: plural ? 'Some tests unexpectedly reported warnings' : 'Unexpected warning',
+            unexpected: plural ? 'Some tests reported warnings' : 'Test warning',
+        },
         failed: {
             expected: plural ? 'Some tests unexpectedly failed' : 'Unexpectedly failed',
             unexpected: plural ? 'Some tests failed' : 'Test failed',